From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBD45C64ED6 for ; Mon, 27 Feb 2023 15:17:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229947AbjB0PRh (ORCPT ); Mon, 27 Feb 2023 10:17:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229557AbjB0PRf (ORCPT ); Mon, 27 Feb 2023 10:17:35 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EAB6722A00 for ; Mon, 27 Feb 2023 07:16:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677511006; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=e2HlQn8VggXQIctikuntg6nDNttpSf2H60bnmaDjpGM=; b=d5jws7UTPjk/jxGxTU/lNA4ZJOXqGMGh7MXWiHpQBzWG8asguRE6LABdYK4+adjt79ZiNi YZ5WmY8IR2EAEk1NLbXNnH6Eg0js/BNLcHIw6gPQXwF+XklHUe7EP7hgB7/G7GwbmG2A61 TdRwCOTeQ31+WAesQ8eQpLrFz4K6LKY= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-460-3zk3FmqAPAC5pxYiCeQoaA-1; Mon, 27 Feb 2023 10:16:45 -0500 X-MC-Unique: 3zk3FmqAPAC5pxYiCeQoaA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9071B3C18368; Mon, 27 Feb 2023 15:16:43 +0000 (UTC) Received: from localhost (unknown [10.45.226.217]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 475602166B2B; Mon, 27 Feb 2023 15:16:43 +0000 (UTC) From: Cornelia Huck To: Eric Auger , Peter Maydell , Thomas Huth , Laurent Vivier Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, kvm@vger.kernel.org, "Dr. David Alan Gilbert" , Juan Quintela , Gavin Shan , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Richard Henderson Subject: Re: [PATCH v5 3/3] qtests/arm: add some mte tests In-Reply-To: <87h6vt8rf3.fsf@redhat.com> Organization: Red Hat GmbH References: <20230203134433.31513-1-cohuck@redhat.com> <20230203134433.31513-4-cohuck@redhat.com> <87h6vt8rf3.fsf@redhat.com> User-Agent: Notmuch/0.37 (https://notmuchmail.org) Date: Mon, 27 Feb 2023 16:16:42 +0100 Message-ID: <87y1oj3zqd.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Fri, Feb 10 2023, Cornelia Huck wrote: > On Mon, Feb 06 2023, Eric Auger wrote: > >> Hi, >> >> On 2/3/23 14:44, Cornelia Huck wrote: >>> +static void mte_tests_default(QTestState *qts, const char *cpu_type) >>> +{ >>> + assert_has_feature(qts, cpu_type, "mte"); >>> + >>> + /* >>> + * Without tag memory, mte will be off under tcg. >>> + * Explicitly enabling it yields an error. >>> + */ >>> + assert_set_feature_str(qts, "max", "mte", "off", "{ 'mte': 'off' }"); >>> + assert_error(qts, cpu_type, "mte=on requires tag memory", >>> + "{ 'mte': 'on' }"); >> Sorry in v4 I reported I preferred the pauth msg, clarifying now: >> >> assert_error(qts, cpu_type, "cannot enable pauth-impdef without pauth", >> "{ 'pauth': false, 'pauth-impdef': true }"); >> >> Here would translate into cannot enable mte without tag memory. > > Oh, so you mean that I should adapt the message generated by the code? Friendly ping :) Did you mean to adapt the error messages in cpu64.c?