* [PATCH kvm-unit-tests] generators: unify header guards
@ 2021-06-14 9:07 Andrew Jones
2021-06-14 9:57 ` Cornelia Huck
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Jones @ 2021-06-14 9:07 UTC (permalink / raw)
To: kvm; +Cc: cohuck, pbonzini, thuth, lvivier, david
Signed-off-by: Andrew Jones <drjones@redhat.com>
---
configure | 4 ++--
scripts/asm-offsets.mak | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/configure b/configure
index 4ad5a4bcd782..b8442d61fb60 100755
--- a/configure
+++ b/configure
@@ -332,8 +332,8 @@ if [ "$arch" = "arm" ] || [ "$arch" = "arm64" ]; then
fi
cat <<EOF > lib/config.h
-#ifndef CONFIG_H
-#define CONFIG_H 1
+#ifndef _CONFIG_H_
+#define _CONFIG_H_
/*
* Generated file. DO NOT MODIFY.
*
diff --git a/scripts/asm-offsets.mak b/scripts/asm-offsets.mak
index 7b64162dd2e1..2b9be2b439f4 100644
--- a/scripts/asm-offsets.mak
+++ b/scripts/asm-offsets.mak
@@ -17,8 +17,8 @@ endef
define make_asm_offsets
(set -e; \
- echo "#ifndef __ASM_OFFSETS_H__"; \
- echo "#define __ASM_OFFSETS_H__"; \
+ echo "#ifndef _ASM_OFFSETS_H_"; \
+ echo "#define _ASM_OFFSETS_H_"; \
echo "/*"; \
echo " * Generated file. DO NOT MODIFY."; \
echo " *"; \
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH kvm-unit-tests] generators: unify header guards
2021-06-14 9:07 [PATCH kvm-unit-tests] generators: unify header guards Andrew Jones
@ 2021-06-14 9:57 ` Cornelia Huck
0 siblings, 0 replies; 2+ messages in thread
From: Cornelia Huck @ 2021-06-14 9:57 UTC (permalink / raw)
To: Andrew Jones, kvm; +Cc: pbonzini, thuth, lvivier, david
On Mon, Jun 14 2021, Andrew Jones <drjones@redhat.com> wrote:
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
> configure | 4 ++--
> scripts/asm-offsets.mak | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/configure b/configure
> index 4ad5a4bcd782..b8442d61fb60 100755
> --- a/configure
> +++ b/configure
> @@ -332,8 +332,8 @@ if [ "$arch" = "arm" ] || [ "$arch" = "arm64" ]; then
> fi
>
> cat <<EOF > lib/config.h
> -#ifndef CONFIG_H
> -#define CONFIG_H 1
> +#ifndef _CONFIG_H_
> +#define _CONFIG_H_
> /*
> * Generated file. DO NOT MODIFY.
> *
Already changed in "header guards: clean up some stragglers", seems that
patch has not been applied yet.
> diff --git a/scripts/asm-offsets.mak b/scripts/asm-offsets.mak
> index 7b64162dd2e1..2b9be2b439f4 100644
> --- a/scripts/asm-offsets.mak
> +++ b/scripts/asm-offsets.mak
> @@ -17,8 +17,8 @@ endef
>
> define make_asm_offsets
> (set -e; \
> - echo "#ifndef __ASM_OFFSETS_H__"; \
> - echo "#define __ASM_OFFSETS_H__"; \
> + echo "#ifndef _ASM_OFFSETS_H_"; \
> + echo "#define _ASM_OFFSETS_H_"; \
> echo "/*"; \
> echo " * Generated file. DO NOT MODIFY."; \
> echo " *"; \
For the second hunk:
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-14 9:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-06-14 9:07 [PATCH kvm-unit-tests] generators: unify header guards Andrew Jones
2021-06-14 9:57 ` Cornelia Huck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox