From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66515C49360 for ; Mon, 14 Jun 2021 09:57:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3EAAD6120F for ; Mon, 14 Jun 2021 09:57:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232734AbhFNJ7S (ORCPT ); Mon, 14 Jun 2021 05:59:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:20444 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232730AbhFNJ7R (ORCPT ); Mon, 14 Jun 2021 05:59:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623664634; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ljCWDPI+DdOXsJXVk0IodoSksgjdTbxJDmUUvdhHn1k=; b=HY8MxaV1OniVpZKWGxvnGyN6aaPG7HKFZIfGHbrWBiOKBbQFtRNCHrb/CnxlLlczwFkslZ UdHnJ7dED2UHDCzWcvg/anUNBxFuRsFOrbicu18yIAIRHiiH43xoQ2dChfdTk1rWVJpNcA 5seJyjza79JAN4yRYvTbvzFtYVB1M60= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-509-PR26syplPMWAfb2C04KEJQ-1; Mon, 14 Jun 2021 05:57:13 -0400 X-MC-Unique: PR26syplPMWAfb2C04KEJQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 703D4192376B for ; Mon, 14 Jun 2021 09:57:12 +0000 (UTC) Received: from localhost (ovpn-113-175.ams2.redhat.com [10.36.113.175]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CA2D660938; Mon, 14 Jun 2021 09:57:08 +0000 (UTC) From: Cornelia Huck To: Andrew Jones , kvm@vger.kernel.org Cc: pbonzini@redhat.com, thuth@redhat.com, lvivier@redhat.com, david@redhat.com Subject: Re: [PATCH kvm-unit-tests] generators: unify header guards In-Reply-To: <20210614090723.30208-1-drjones@redhat.com> Organization: Red Hat GmbH References: <20210614090723.30208-1-drjones@redhat.com> User-Agent: Notmuch/0.32.1 (https://notmuchmail.org) Date: Mon, 14 Jun 2021 11:57:06 +0200 Message-ID: <87y2bcydjh.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, Jun 14 2021, Andrew Jones wrote: > Signed-off-by: Andrew Jones > --- > configure | 4 ++-- > scripts/asm-offsets.mak | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/configure b/configure > index 4ad5a4bcd782..b8442d61fb60 100755 > --- a/configure > +++ b/configure > @@ -332,8 +332,8 @@ if [ "$arch" = "arm" ] || [ "$arch" = "arm64" ]; then > fi > > cat < lib/config.h > -#ifndef CONFIG_H > -#define CONFIG_H 1 > +#ifndef _CONFIG_H_ > +#define _CONFIG_H_ > /* > * Generated file. DO NOT MODIFY. > * Already changed in "header guards: clean up some stragglers", seems that patch has not been applied yet. > diff --git a/scripts/asm-offsets.mak b/scripts/asm-offsets.mak > index 7b64162dd2e1..2b9be2b439f4 100644 > --- a/scripts/asm-offsets.mak > +++ b/scripts/asm-offsets.mak > @@ -17,8 +17,8 @@ endef > > define make_asm_offsets > (set -e; \ > - echo "#ifndef __ASM_OFFSETS_H__"; \ > - echo "#define __ASM_OFFSETS_H__"; \ > + echo "#ifndef _ASM_OFFSETS_H_"; \ > + echo "#define _ASM_OFFSETS_H_"; \ > echo "/*"; \ > echo " * Generated file. DO NOT MODIFY."; \ > echo " *"; \ For the second hunk: Reviewed-by: Cornelia Huck