From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: Sean Christopherson <sean.j.christopherson@intel.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 16/61] KVM: x86: Encapsulate CPUID entries and metadata in struct
Date: Fri, 21 Feb 2020 15:58:47 +0100 [thread overview]
Message-ID: <87y2swq95k.fsf@vitty.brq.redhat.com> (raw)
In-Reply-To: <20200201185218.24473-17-sean.j.christopherson@intel.com>
Sean Christopherson <sean.j.christopherson@intel.com> writes:
> Add a struct to hold the array of CPUID entries and its associated
> metadata when handling KVM_GET_SUPPORTED_CPUID. Lookup and provide
> the correct entry in do_host_cpuid(), which eliminates the majority of
> array indexing shenanigans, e.g. entries[i -1], and generally makes the
> code more readable. The last array indexing holdout is kvm_get_cpuid(),
> which can't really be avoided without throwing the baby out with the
> bathwater.
>
> No functional change intended.
>
> Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
> ---
> arch/x86/kvm/cpuid.c | 138 ++++++++++++++++++++++++-------------------
> 1 file changed, 76 insertions(+), 62 deletions(-)
>
> diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c
> index d75d539da759..f9cfc69199f0 100644
> --- a/arch/x86/kvm/cpuid.c
> +++ b/arch/x86/kvm/cpuid.c
> @@ -287,13 +287,21 @@ static __always_inline void cpuid_mask(u32 *word, int wordnum)
> *word &= boot_cpu_data.x86_capability[wordnum];
> }
>
> -static struct kvm_cpuid_entry2 *do_host_cpuid(struct kvm_cpuid_entry2 *entry,
> - int *nent, int maxnent,
> +struct kvm_cpuid_array {
> + struct kvm_cpuid_entry2 *entries;
> + const int maxnent;
> + int nent;
> +};
> +
> +static struct kvm_cpuid_entry2 *do_host_cpuid(struct kvm_cpuid_array *array,
> u32 function, u32 index)
> {
> - if (*nent >= maxnent)
> + struct kvm_cpuid_entry2 *entry;
> +
> + if (array->nent >= array->maxnent)
> return NULL;
> - ++*nent;
> +
> + entry = &array->entries[array->nent++];
>
> entry->function = function;
> entry->index = index;
> @@ -325,9 +333,10 @@ static struct kvm_cpuid_entry2 *do_host_cpuid(struct kvm_cpuid_entry2 *entry,
> return entry;
> }
>
> -static int __do_cpuid_func_emulated(struct kvm_cpuid_entry2 *entry,
> - u32 func, int *nent, int maxnent)
> +static int __do_cpuid_func_emulated(struct kvm_cpuid_array *array, u32 func)
> {
> + struct kvm_cpuid_entry2 *entry = &array->entries[array->nent];
> +
> entry->function = func;
> entry->index = 0;
> entry->flags = 0;
> @@ -335,17 +344,17 @@ static int __do_cpuid_func_emulated(struct kvm_cpuid_entry2 *entry,
> switch (func) {
> case 0:
> entry->eax = 7;
> - ++*nent;
> + ++array->nent;
> break;
> case 1:
> entry->ecx = F(MOVBE);
> - ++*nent;
> + ++array->nent;
> break;
> case 7:
> entry->flags |= KVM_CPUID_FLAG_SIGNIFCANT_INDEX;
> entry->eax = 0;
> entry->ecx = F(RDPID);
> - ++*nent;
> + ++array->nent;
> default:
> break;
> }
> @@ -436,9 +445,9 @@ static inline void do_cpuid_7_mask(struct kvm_cpuid_entry2 *entry)
> }
> }
>
> -static inline int __do_cpuid_func(struct kvm_cpuid_entry2 *entry, u32 function,
> - int *nent, int maxnent)
> +static inline int __do_cpuid_func(struct kvm_cpuid_array *array, u32 function)
> {
> + struct kvm_cpuid_entry2 *entry;
> int r, i, max_idx;
> unsigned f_nx = is_efer_nx() ? F(NX) : 0;
> #ifdef CONFIG_X86_64
> @@ -514,7 +523,8 @@ static inline int __do_cpuid_func(struct kvm_cpuid_entry2 *entry, u32 function,
>
> r = -E2BIG;
>
> - if (WARN_ON(!do_host_cpuid(entry, nent, maxnent, function, 0)))
> + entry = do_host_cpuid(array, function, 0);
> + if (WARN_ON(!entry))
> goto out;
>
> switch (function) {
> @@ -539,7 +549,8 @@ static inline int __do_cpuid_func(struct kvm_cpuid_entry2 *entry, u32 function,
> entry->flags |= KVM_CPUID_FLAG_STATE_READ_NEXT;
>
> for (i = 1, max_idx = entry->eax & 0xff; i < max_idx; ++i) {
> - if (!do_host_cpuid(&entry[i], nent, maxnent, function, 0))
> + entry = do_host_cpuid(array, 2, 0);
I'd change this to
entry = do_host_cpuid(array, function, 0);
to match other call sites.
> + if (!entry)
> goto out;
> }
> break;
> @@ -550,8 +561,9 @@ static inline int __do_cpuid_func(struct kvm_cpuid_entry2 *entry, u32 function,
> * Read entries until the cache type in the previous entry is
> * zero, i.e. indicates an invalid entry.
> */
> - for (i = 1; entry[i - 1].eax & 0x1f; ++i) {
> - if (!do_host_cpuid(&entry[i], nent, maxnent, function, i))
> + for (i = 1; entry->eax & 0x1f; ++i) {
> + entry = do_host_cpuid(array, function, i);
> + if (!entry)
> goto out;
> }
> break;
> @@ -566,10 +578,11 @@ static inline int __do_cpuid_func(struct kvm_cpuid_entry2 *entry, u32 function,
> do_cpuid_7_mask(entry);
>
> for (i = 1, max_idx = entry->eax; i <= max_idx; i++) {
> - if (!do_host_cpuid(&entry[i], nent, maxnent, function, i))
> + entry = do_host_cpuid(array, function, i);
> + if (!entry)
> goto out;
>
> - do_cpuid_7_mask(&entry[i]);
> + do_cpuid_7_mask(entry);
> }
> break;
> case 9:
> @@ -610,15 +623,13 @@ static inline int __do_cpuid_func(struct kvm_cpuid_entry2 *entry, u32 function,
> case 0x1f:
> case 0xb:
> /*
> - * We filled in entry[0] for CPUID(EAX=<function>,
> - * ECX=00H) above. If its level type (ECX[15:8]) is
> - * zero, then the leaf is unimplemented, and we're
> - * done. Otherwise, continue to populate entries
> - * until the level type (ECX[15:8]) of the previously
> - * added entry is zero.
> + * Populate entries until the level type (ECX[15:8]) of the
> + * previous entry is zero. Note, CPUID EAX.{0x1f,0xb}.0 is
> + * the starting entry, filled by the primary do_host_cpuid().
> */
> - for (i = 1; entry[i - 1].ecx & 0xff00; ++i) {
> - if (!do_host_cpuid(&entry[i], nent, maxnent, function, i))
> + for (i = 1; entry->ecx & 0xff00; ++i) {
> + entry = do_host_cpuid(array, function, i);
> + if (!entry)
> goto out;
> }
> break;
> @@ -633,24 +644,26 @@ static inline int __do_cpuid_func(struct kvm_cpuid_entry2 *entry, u32 function,
> if (!supported)
> break;
>
> - if (!do_host_cpuid(&entry[1], nent, maxnent, function, 1))
> + entry = do_host_cpuid(array, function, 1);
> + if (!entry)
> goto out;
>
> - entry[1].eax &= kvm_cpuid_D_1_eax_x86_features;
> - cpuid_mask(&entry[1].eax, CPUID_D_1_EAX);
> - if (entry[1].eax & (F(XSAVES)|F(XSAVEC)))
> - entry[1].ebx = xstate_required_size(supported, true);
> + entry->eax &= kvm_cpuid_D_1_eax_x86_features;
> + cpuid_mask(&entry->eax, CPUID_D_1_EAX);
> + if (entry->eax & (F(XSAVES)|F(XSAVEC)))
> + entry->ebx = xstate_required_size(supported, true);
> else
> - entry[1].ebx = 0;
> + entry->ebx = 0;
> /* Saving XSS controlled state via XSAVES isn't supported. */
> - entry[1].ecx = 0;
> - entry[1].edx = 0;
> + entry->ecx = 0;
> + entry->edx = 0;
>
> - for (idx = 2, i = 2; idx < 64; ++idx) {
> + for (idx = 2; idx < 64; ++idx) {
> if (!(supported & BIT_ULL(idx)))
> continue;
>
> - if (!do_host_cpuid(&entry[i], nent, maxnent, function, idx))
> + entry = do_host_cpuid(array, function, idx);
> + if (!entry)
> goto out;
>
> /*
> @@ -660,14 +673,13 @@ static inline int __do_cpuid_func(struct kvm_cpuid_entry2 *entry, u32 function,
> * reach this point, and they should have a non-zero
> * save state size.
> */
> - if (WARN_ON_ONCE(!entry[i].eax || (entry[i].ecx & 1))) {
> - --*nent;
> + if (WARN_ON_ONCE(!entry->eax || (entry->ecx & 1))) {
> + --array->nent;
> continue;
> }
>
> - entry[i].ecx = 0;
> - entry[i].edx = 0;
> - ++i;
> + entry->ecx = 0;
> + entry->edx = 0;
> }
> break;
> }
> @@ -677,7 +689,7 @@ static inline int __do_cpuid_func(struct kvm_cpuid_entry2 *entry, u32 function,
> break;
>
> for (i = 1, max_idx = entry->eax; i <= max_idx; ++i) {
> - if (!do_host_cpuid(&entry[i], nent, maxnent, function, i))
> + if (!do_host_cpuid(array, function, i))
> goto out;
> }
> break;
> @@ -802,22 +814,22 @@ static inline int __do_cpuid_func(struct kvm_cpuid_entry2 *entry, u32 function,
> return r;
> }
>
> -static int do_cpuid_func(struct kvm_cpuid_entry2 *entry, u32 func,
> - int *nent, int maxnent, unsigned int type)
> +static int do_cpuid_func(struct kvm_cpuid_array *array, u32 func,
> + unsigned int type)
> {
> - if (*nent >= maxnent)
> + if (array->nent >= array->maxnent)
> return -E2BIG;
>
> if (type == KVM_GET_EMULATED_CPUID)
> - return __do_cpuid_func_emulated(entry, func, nent, maxnent);
> + return __do_cpuid_func_emulated(array, func);
Would it make sense to move 'if (array->nent >= array->maxnent)' check
to __do_cpuid_func_emulated() to match do_host_cpuid()?
>
> - return __do_cpuid_func(entry, func, nent, maxnent);
> + return __do_cpuid_func(array, func);
> }
>
> #define CENTAUR_CPUID_SIGNATURE 0xC0000000
>
> -static int get_cpuid_func(struct kvm_cpuid_entry2 *entries, u32 func,
> - int *nent, int maxnent, unsigned int type)
> +static int get_cpuid_func(struct kvm_cpuid_array *array, u32 func,
> + unsigned int type)
> {
> u32 limit;
> int r;
> @@ -826,16 +838,16 @@ static int get_cpuid_func(struct kvm_cpuid_entry2 *entries, u32 func,
> boot_cpu_data.x86_vendor != X86_VENDOR_CENTAUR)
> return 0;
>
> - r = do_cpuid_func(&entries[*nent], func, nent, maxnent, type);
> + r = do_cpuid_func(array, func, type);
> if (r)
> return r;
>
> - limit = entries[*nent - 1].eax;
> + limit = array->entries[array->nent - 1].eax;
> for (func = func + 1; func <= limit; ++func) {
> - if (*nent >= maxnent)
> + if (array->nent >= array->maxnent)
> return -E2BIG;
>
> - r = do_cpuid_func(&entries[*nent], func, nent, maxnent, type);
> + r = do_cpuid_func(array, func, type);
do_cpuid_func() above is already doing 'if (array->nent >=
array->maxnent)' check and returns -E2BIG when it fails, maybe the same
check here in get_cpuid_func() is not needed?
> if (r)
> break;
> }
> @@ -878,8 +890,11 @@ int kvm_dev_ioctl_get_cpuid(struct kvm_cpuid2 *cpuid,
> 0, 0x80000000, CENTAUR_CPUID_SIGNATURE, KVM_CPUID_SIGNATURE,
> };
>
> - struct kvm_cpuid_entry2 *cpuid_entries;
> - int nent = 0, r, i;
> + struct kvm_cpuid_array array = {
> + .nent = 0,
> + .maxnent = cpuid->nent,
> + };
> + int r, i;
>
> if (cpuid->nent < 1)
> return -E2BIG;
> @@ -889,25 +904,24 @@ int kvm_dev_ioctl_get_cpuid(struct kvm_cpuid2 *cpuid,
> if (sanity_check_entries(entries, cpuid->nent, type))
> return -EINVAL;
>
> - cpuid_entries = vzalloc(array_size(sizeof(struct kvm_cpuid_entry2),
> + array.entries = vzalloc(array_size(sizeof(struct kvm_cpuid_entry2),
> cpuid->nent));
> - if (!cpuid_entries)
> + if (!array.entries)
> return -ENOMEM;
>
> for (i = 0; i < ARRAY_SIZE(funcs); i++) {
> - r = get_cpuid_func(cpuid_entries, funcs[i], &nent, cpuid->nent,
> - type);
> + r = get_cpuid_func(&array, funcs[i], type);
> if (r)
> goto out_free;
> }
> - cpuid->nent = nent;
> + cpuid->nent = array.nent;
>
> - if (copy_to_user(entries, cpuid_entries,
> - nent * sizeof(struct kvm_cpuid_entry2)))
> + if (copy_to_user(entries, array.entries,
> + array.nent * sizeof(struct kvm_cpuid_entry2)))
> r = -EFAULT;
>
> out_free:
> - vfree(cpuid_entries);
> + vfree(array.entries);
> return r;
> }
Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
--
Vitaly
next prev parent reply other threads:[~2020-02-21 14:58 UTC|newest]
Thread overview: 168+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-01 18:51 [PATCH 00/61] KVM: x86: Introduce KVM cpu caps Sean Christopherson
2020-02-01 18:51 ` [PATCH 01/61] KVM: x86: Return -E2BIG when KVM_GET_SUPPORTED_CPUID hits max entries Sean Christopherson
2020-02-03 12:55 ` Vitaly Kuznetsov
2020-02-03 15:59 ` Sean Christopherson
2020-02-25 14:36 ` Paolo Bonzini
2020-02-01 18:51 ` [PATCH 02/61] KVM: x86: Refactor loop around do_cpuid_func() to separate helper Sean Christopherson
2020-02-06 14:59 ` Vitaly Kuznetsov
2020-02-07 19:53 ` Sean Christopherson
2020-02-25 14:37 ` Paolo Bonzini
2020-02-25 15:09 ` Vitaly Kuznetsov
2020-02-26 11:35 ` Paolo Bonzini
2020-02-01 18:51 ` [PATCH 03/61] KVM: x86: Simplify handling of Centaur CPUID leafs Sean Christopherson
2020-02-06 15:05 ` Vitaly Kuznetsov
2020-02-07 19:47 ` Sean Christopherson
2020-02-01 18:51 ` [PATCH 04/61] KVM: x86: Clean up error handling in kvm_dev_ioctl_get_cpuid() Sean Christopherson
2020-02-06 15:09 ` Vitaly Kuznetsov
2020-02-01 18:51 ` [PATCH 05/61] KVM: x86: Check userapce CPUID array size after validating sub-leaf Sean Christopherson
2020-02-06 15:24 ` Vitaly Kuznetsov
2020-02-01 18:51 ` [PATCH 06/61] KVM: x86: Move CPUID 0xD.1 handling out of the index>0 loop Sean Christopherson
2020-02-07 15:38 ` Vitaly Kuznetsov
2020-02-01 18:51 ` [PATCH 07/61] KVM: x86: Check for CPUID 0xD.N support before validating array size Sean Christopherson
2020-02-07 15:48 ` Vitaly Kuznetsov
2020-02-01 18:51 ` [PATCH 08/61] KVM: x86: Warn on zero-size save state for valid CPUID 0xD.N sub-leaf Sean Christopherson
2020-02-07 15:54 ` Vitaly Kuznetsov
2020-02-07 15:56 ` Sean Christopherson
2020-02-01 18:51 ` [PATCH 09/61] KVM: x86: Refactor CPUID 0xD.N sub-leaf entry creation Sean Christopherson
2020-02-07 15:56 ` Vitaly Kuznetsov
2020-02-01 18:51 ` [PATCH 10/61] KVM: x86: Clean up CPUID 0x7 sub-leaf loop Sean Christopherson
2020-02-21 14:20 ` Vitaly Kuznetsov
2020-02-01 18:51 ` [PATCH 11/61] KVM: x86: Drop the explicit @index from do_cpuid_7_mask() Sean Christopherson
2020-02-21 14:22 ` Vitaly Kuznetsov
2020-02-01 18:51 ` [PATCH 12/61] KVM: x86: Drop redundant boot cpu checks on SSBD feature bits Sean Christopherson
2020-02-01 18:51 ` [PATCH 13/61] KVM: x86: Consolidate CPUID array max num entries checking Sean Christopherson
2020-02-01 18:51 ` [PATCH 14/61] KVM: x86: Hoist loop counter and terminator to top of __do_cpuid_func() Sean Christopherson
2020-02-01 18:51 ` [PATCH 15/61] KVM: x86: Refactor CPUID 0x4 and 0x8000001d handling Sean Christopherson
2020-02-21 14:40 ` Vitaly Kuznetsov
2020-02-01 18:51 ` [PATCH 16/61] KVM: x86: Encapsulate CPUID entries and metadata in struct Sean Christopherson
2020-02-21 14:58 ` Vitaly Kuznetsov [this message]
2020-02-24 21:55 ` Sean Christopherson
2020-02-24 23:12 ` Vitaly Kuznetsov
2020-02-01 18:51 ` [PATCH 17/61] KVM: x86: Drop redundant array size check Sean Christopherson
2020-02-01 18:51 ` [PATCH 18/61] KVM: x86: Use common loop iterator when handling CPUID 0xD.N Sean Christopherson
2020-02-21 15:04 ` Vitaly Kuznetsov
2020-02-01 18:51 ` [PATCH 19/61] KVM: VMX: Add helpers to query Intel PT mode Sean Christopherson
[not found] ` <87pne8q8c0.fsf@vitty.brq.redhat.com>
2020-02-24 22:18 ` Sean Christopherson
2020-02-25 14:54 ` Paolo Bonzini
2020-03-03 22:41 ` Sean Christopherson
2020-02-01 18:51 ` [PATCH 20/61] KVM: x86: Calculate the supported xcr0 mask at load time Sean Christopherson
2020-02-13 14:21 ` Xiaoyao Li
2020-02-01 18:51 ` [PATCH 21/61] KVM: x86: Use supported_xcr0 to detect MPX support Sean Christopherson
2020-02-13 14:25 ` Xiaoyao Li
2020-02-21 15:32 ` Vitaly Kuznetsov
2020-02-01 18:51 ` [PATCH 22/61] KVM: x86: Make kvm_mpx_supported() an inline function Sean Christopherson
2020-02-13 14:26 ` Xiaoyao Li
2020-02-21 15:33 ` Vitaly Kuznetsov
2020-02-01 18:51 ` [PATCH 23/61] KVM: x86: Clear output regs for CPUID 0x14 if PT isn't exposed to guest Sean Christopherson
2020-02-21 15:36 ` Vitaly Kuznetsov
2020-02-01 18:51 ` [PATCH 24/61] KVM: x86: Drop explicit @func param from ->set_supported_cpuid() Sean Christopherson
2020-02-21 15:39 ` Vitaly Kuznetsov
2020-02-01 18:51 ` [PATCH 25/61] KVM: x86: Use u32 for holding CPUID register value in helpers Sean Christopherson
2020-02-21 15:43 ` Vitaly Kuznetsov
2020-02-01 18:51 ` [PATCH 26/61] KVM: x86: Introduce cpuid_entry_{get,has}() accessors Sean Christopherson
2020-02-14 9:44 ` Xiaoyao Li
2020-02-14 17:09 ` Sean Christopherson
2020-02-21 15:57 ` Vitaly Kuznetsov
2020-02-21 16:29 ` Sean Christopherson
2020-02-01 18:51 ` [PATCH 27/61] KVM: x86: Introduce cpuid_entry_{change,set,clear}() mutators Sean Christopherson
[not found] ` <87ftf0p0d0.fsf@vitty.brq.redhat.com>
2020-02-24 22:42 ` Sean Christopherson
2020-02-01 18:51 ` [PATCH 28/61] KVM: x86: Refactor cpuid_mask() to auto-retrieve the register Sean Christopherson
2020-02-24 13:49 ` Vitaly Kuznetsov
2020-02-01 18:51 ` [PATCH 29/61] KVM: x86: Add Kconfig-controlled auditing of reverse CPUID lookups Sean Christopherson
2020-02-24 13:54 ` Vitaly Kuznetsov
2020-02-24 22:46 ` Sean Christopherson
2020-02-25 15:02 ` Paolo Bonzini
2020-02-25 15:00 ` Paolo Bonzini
2020-02-01 18:51 ` [PATCH 30/61] KVM: x86: Handle MPX CPUID adjustment in VMX code Sean Christopherson
2020-02-13 13:51 ` Xiaoyao Li
2020-02-13 17:37 ` Sean Christopherson
2020-02-24 15:14 ` Vitaly Kuznetsov
2020-02-24 15:45 ` Sean Christopherson
2020-02-01 18:51 ` [PATCH 31/61] KVM: x86: Handle INVPCID " Sean Christopherson
2020-02-24 15:19 ` Vitaly Kuznetsov
2020-02-01 18:51 ` [PATCH 32/61] KVM: x86: Handle UMIP emulation " Sean Christopherson
2020-02-24 15:21 ` Vitaly Kuznetsov
2020-02-01 18:51 ` [PATCH 33/61] KVM: x86: Handle PKU " Sean Christopherson
2020-02-24 15:24 ` Vitaly Kuznetsov
2020-02-01 18:51 ` [PATCH 34/61] KVM: x86: Handle RDTSCP " Sean Christopherson
2020-02-24 15:28 ` Vitaly Kuznetsov
2020-02-01 18:51 ` [PATCH 35/61] KVM: x86: Handle Intel PT " Sean Christopherson
2020-02-24 15:30 ` Vitaly Kuznetsov
2020-02-01 18:51 ` [PATCH 36/61] KVM: x86: Handle GBPAGE CPUID adjustment for EPT " Sean Christopherson
2020-02-24 15:34 ` Vitaly Kuznetsov
2020-02-01 18:51 ` [PATCH 37/61] KVM: x86: Refactor handling of XSAVES CPUID adjustment Sean Christopherson
2020-02-24 15:39 ` Vitaly Kuznetsov
2020-02-01 18:51 ` [PATCH 38/61] KVM: x86: Introduce kvm_cpu_caps to replace runtime CPUID masking Sean Christopherson
2020-02-24 16:32 ` Vitaly Kuznetsov
2020-02-24 22:57 ` Sean Christopherson
2020-02-24 23:20 ` Vitaly Kuznetsov
2020-02-24 23:25 ` Sean Christopherson
2020-02-01 18:51 ` [PATCH 39/61] KVM: SVM: Convert feature updates from CPUID to KVM cpu caps Sean Christopherson
2020-02-24 21:33 ` Vitaly Kuznetsov
2020-02-25 15:10 ` Paolo Bonzini
2020-02-28 0:28 ` Sean Christopherson
2020-02-28 0:36 ` Sean Christopherson
2020-02-28 7:03 ` Paolo Bonzini
2020-02-28 15:09 ` Sean Christopherson
2020-02-01 18:51 ` [PATCH 40/61] KVM: VMX: " Sean Christopherson
2020-02-24 21:40 ` Vitaly Kuznetsov
2020-02-01 18:51 ` [PATCH 41/61] KVM: x86: Move XSAVES CPUID adjust to VMX's KVM cpu cap update Sean Christopherson
2020-02-24 21:43 ` Vitaly Kuznetsov
2020-02-01 18:51 ` [PATCH 42/61] KVM: x86: Add a helper to check kernel support when setting cpu cap Sean Christopherson
2020-02-24 21:47 ` Vitaly Kuznetsov
2020-02-01 18:52 ` [PATCH 43/61] KVM: x86: Use KVM cpu caps to mark CR4.LA57 as not-reserved Sean Christopherson
2020-02-24 22:08 ` Vitaly Kuznetsov
2020-02-24 23:23 ` Sean Christopherson
2020-02-25 15:12 ` Paolo Bonzini
2020-02-25 15:19 ` David Laight
2020-02-25 21:22 ` Sean Christopherson
2020-02-26 11:35 ` Paolo Bonzini
2020-02-01 18:52 ` [PATCH 44/61] KVM: x86: Use KVM cpu caps to track UMIP emulation Sean Christopherson
2020-02-24 22:13 ` Vitaly Kuznetsov
2020-02-01 18:52 ` [PATCH 45/61] KVM: x86: Fold CPUID 0x7 masking back into __do_cpuid_func() Sean Christopherson
2020-02-24 22:21 ` Vitaly Kuznetsov
2020-02-01 18:52 ` [PATCH 46/61] KVM: x86: Remove the unnecessary loop on CPUID 0x7 sub-leafs Sean Christopherson
2020-02-24 22:25 ` Vitaly Kuznetsov
2020-02-01 18:52 ` [PATCH 47/61] KVM: x86: Squash CPUID 0x2.0 insanity for modern CPUs Sean Christopherson
2020-02-24 22:35 ` Vitaly Kuznetsov
2020-02-25 15:17 ` Paolo Bonzini
2020-02-01 18:52 ` [PATCH 48/61] KVM: x86: Do host CPUID at load time to mask KVM cpu caps Sean Christopherson
[not found] ` <87o8tnmwni.fsf@vitty.brq.redhat.com>
2020-02-24 23:31 ` Sean Christopherson
2020-02-25 13:53 ` Vitaly Kuznetsov
2020-02-25 15:18 ` Paolo Bonzini
2020-02-25 21:08 ` Sean Christopherson
2020-02-29 18:38 ` Sean Christopherson
2020-02-01 18:52 ` [PATCH 49/61] KVM: x86: Override host CPUID results with kvm_cpu_caps Sean Christopherson
2020-02-24 22:57 ` Vitaly Kuznetsov
2020-02-01 18:52 ` [PATCH 50/61] KVM: x86: Set emulated/transmuted feature bits via kvm_cpu_caps Sean Christopherson
2020-02-25 13:59 ` Vitaly Kuznetsov
2020-02-01 18:52 ` [PATCH 51/61] KVM: x86: Use kvm_cpu_caps to detect Intel PT support Sean Christopherson
2020-02-25 14:06 ` Vitaly Kuznetsov
2020-02-01 18:52 ` [PATCH 52/61] KVM: x86: Use KVM cpu caps to detect MSR_TSC_AUX virt support Sean Christopherson
2020-02-25 14:08 ` Vitaly Kuznetsov
2020-02-01 18:52 ` [PATCH 53/61] KVM: VMX: Directly use VMX capabilities helper to detect RDTSCP support Sean Christopherson
2020-02-25 14:10 ` Vitaly Kuznetsov
2020-02-01 18:52 ` [PATCH 54/61] KVM: x86: Check for Intel PT MSR virtualization using KVM cpu caps Sean Christopherson
2020-02-25 14:11 ` Vitaly Kuznetsov
2020-02-01 18:52 ` [PATCH 55/61] KVM: VMX: Directly query Intel PT mode when refreshing PMUs Sean Christopherson
2020-02-25 14:16 ` Vitaly Kuznetsov
2020-02-01 18:52 ` [PATCH 56/61] KVM: SVM: Refactor logging of NPT enabled/disabled Sean Christopherson
2020-02-25 14:21 ` Vitaly Kuznetsov
2020-02-01 18:52 ` [PATCH 57/61] KVM: x86/mmu: Merge kvm_{enable,disable}_tdp() into a common function Sean Christopherson
2020-02-25 14:27 ` Vitaly Kuznetsov
2020-02-01 18:52 ` [PATCH 58/61] KVM: x86/mmu: Configure max page level during hardware setup Sean Christopherson
2020-02-25 14:43 ` Vitaly Kuznetsov
2020-02-25 21:01 ` Sean Christopherson
2020-02-26 14:55 ` Vitaly Kuznetsov
2020-02-26 15:56 ` Sean Christopherson
2020-02-01 18:52 ` [PATCH 59/61] KVM: x86: Don't propagate MMU lpage support to memslot.disallow_lpage Sean Christopherson
2020-02-25 14:55 ` Vitaly Kuznetsov
2020-02-01 18:52 ` [PATCH 60/61] KVM: Drop largepages_enabled and its accessor/mutator Sean Christopherson
2020-02-25 14:56 ` Vitaly Kuznetsov
2020-02-01 18:52 ` [PATCH 61/61] KVM: x86: Move VMX's host_efer to common x86 code Sean Christopherson
2020-02-25 15:02 ` Vitaly Kuznetsov
[not found] ` <87wo8ak84x.fsf@vitty.brq.redhat.com>
2020-02-25 15:25 ` [PATCH 00/61] KVM: x86: Introduce KVM cpu caps Paolo Bonzini
2020-02-28 1:37 ` Sean Christopherson
2020-02-28 7:04 ` Paolo Bonzini
2020-02-29 18:32 ` Sean Christopherson
2020-03-02 9:03 ` Vitaly Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2swq95k.fsf@vitty.brq.redhat.com \
--to=vkuznets@redhat.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).