From: Rusty Russell <rusty@rustcorp.com.au>
To: Sasha Levin <levinsasha928@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] virtio-blk: allow toggling host cache between writeback and writethrough
Date: Mon, 09 Jul 2012 09:15:11 +0930 [thread overview]
Message-ID: <87y5mt3ji0.fsf@rustcorp.com.au> (raw)
In-Reply-To: <1341471743.18786.12.camel@lappy>
On Thu, 05 Jul 2012 09:02:23 +0200, Sasha Levin <levinsasha928@gmail.com> wrote:
> On Thu, 2012-07-05 at 08:47 +0200, Paolo Bonzini wrote:
> > Il 04/07/2012 23:11, Sasha Levin ha scritto:
> > > There are two things going on here:
> > > 1. Rename VIRTIO_BLK_F_FLUSH to VIRTIO_BLK_F_WCE
> > > 2. Add a new VIRTIO_BLK_F_CONFIG_WCE
> > >
> > > I'm concerned that the first change is going to break compilation for
> > > any code that included linux/virtio-blk.h and used VIRTIO_BLK_F_FLUSH.
> >
> > That would be nlkt, right? :)
>
> nlkt, lguest, and probably others.
>
> linux/virtio_blk.h is a public kernel header, which is supposed to be
> used from userspace - so I assume many others who implemented virtio-blk
> for any reason took advantage of that header.
lguest doesn't have an API, so it can be patched.
But if someone else breaks, then yes, we need to define the old name
too.
Cheers,
Rusty.
next prev parent reply other threads:[~2012-07-08 23:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-03 13:19 [PATCH] virtio-blk: allow toggling host cache between writeback and writethrough Paolo Bonzini
2012-07-04 5:55 ` Rusty Russell
2012-07-04 6:24 ` Rusty Russell
2012-07-04 15:13 ` Michael S. Tsirkin
2012-07-04 15:42 ` Michael S. Tsirkin
2012-07-04 15:54 ` Paolo Bonzini
2012-07-04 16:02 ` Michael S. Tsirkin
2012-07-04 16:08 ` Paolo Bonzini
2012-07-04 21:30 ` Michael S. Tsirkin
2012-07-05 6:45 ` Paolo Bonzini
2012-07-04 16:26 ` Sasha Levin
2012-07-04 16:32 ` Paolo Bonzini
2012-07-04 21:11 ` Sasha Levin
2012-07-05 6:47 ` Paolo Bonzini
2012-07-05 7:02 ` Sasha Levin
2012-07-08 23:45 ` Rusty Russell [this message]
2012-07-25 1:02 ` Rusty Russell
2012-07-05 18:39 ` Badari Pulavarty
2012-07-06 6:47 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y5mt3ji0.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=kvm@vger.kernel.org \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox