From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QIbU+Lr7" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E8ABB2 for ; Wed, 13 Dec 2023 11:39:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702496375; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pKJ2gmaWxKAK6Y/wvzA1srhiIXS0NochFPI0HVkNASs=; b=QIbU+Lr7B8/Bj0t6vXZJFT6Bmoq39y+tN10ts0xUlbxp+C3JQxqLUNrJROsJzODiHk1Esx OQQVYqnXqumY2EzLL7JbwOl4/li+QrCIro6WCePE9G9JIp7uVbKwx2SeWBG1KTe+KreLhR 1p4X3NnKmvIDx69OH1qYtEbxdJN4A1g= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-636-HANLME-LOSCusGI_e2kGGg-1; Wed, 13 Dec 2023 14:39:29 -0500 X-MC-Unique: HANLME-LOSCusGI_e2kGGg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E444488FC26; Wed, 13 Dec 2023 19:39:28 +0000 (UTC) Received: from p1.localdomain.some.host.somewhere.org (ovpn-114-21.gru2.redhat.com [10.97.114.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 104BE1121306; Wed, 13 Dec 2023 19:39:20 +0000 (UTC) From: Cleber Rosa To: Akihiko Odaki , qemu-devel@nongnu.org Cc: Jiaxun Yang , Radoslaw Biernacki , Paul Durrant , Leif Lindholm , Peter Maydell , Paolo Bonzini , Alex =?utf-8?Q?Benn=C3=A9e?= , kvm@vger.kernel.org, qemu-arm@nongnu.org, Philippe =?utf-8?Q?Mathieu-Daud?= =?utf-8?Q?=C3=A9?= , Beraldo Leal , Wainer dos Santos Moschetta , Sriram Yagnaraman , Marcin Juszkiewicz , David Woodhouse Subject: Re: [PATCH 02/10] tests/avocado: mips: add hint for fetchasset plugin In-Reply-To: <8717f71f-5350-45ef-9712-89c1240bc77c@daynix.com> References: <20231208190911.102879-1-crosa@redhat.com> <20231208190911.102879-3-crosa@redhat.com> <8717f71f-5350-45ef-9712-89c1240bc77c@daynix.com> Date: Wed, 13 Dec 2023 14:39:05 -0500 Message-ID: <87zfydvqna.fsf@p1.localdomain> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 Akihiko Odaki writes: > On 2023/12/09 4:09, Cleber Rosa wrote: >> Avocado's fetchasset plugin runs before the actual Avocado job (and >> any test). It analyses the test's code looking for occurrences of >> "self.fetch_asset()" in the either the actual test or setUp() method. >> It's not able to fully analyze all code, though. >> >> The way these tests are written, make the fetchasset plugin blind to >> the assets. This adds redundant code, true, but one that doesn't hurt >> the test and aids the fetchasset plugin to download or verify the >> existence of these assets in advance. >> >> Signed-off-by: Cleber Rosa > > Why not delete fetch_asset() in do_test_mips_malta32el_nanomips()? I was trying to preserve do_test_mips_malta32el_nanomips() in such a way that with the eventual migration to the "dependency" system in newer Avocado, the lines added here could simply be reversed. But, that's not a strong enough reason to justify the duplication. I'll follow your suggestion on v2. Thanks! - Cleber.