From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 745BFC43460 for ; Fri, 9 Apr 2021 07:38:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4679761107 for ; Fri, 9 Apr 2021 07:38:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229545AbhDIHiV (ORCPT ); Fri, 9 Apr 2021 03:38:21 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:50367 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229621AbhDIHiU (ORCPT ); Fri, 9 Apr 2021 03:38:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617953887; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fkrozLMJPACVkdmHi98evbnJXUcRYylIKOGu+prd3Vg=; b=AVV5gxNk0ddxwfb/hc6IA7CKtMu465VgViEyqjZ4ZZFvbM3CZoyw5SA/IHNk9yycKIY8F2 cvkdlWoAb0PsLQ32V8TD/bYTMYEBlK+5QT0GfpLe1IcdzZKmfhsAOp8R5OKE0R1/B2jFhP Ns7NTa2nrSQt6o1NZNt+1/AdKX2nGFs= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-469-KOTh75VGP0eT9VYto1GaSw-1; Fri, 09 Apr 2021 03:38:06 -0400 X-MC-Unique: KOTh75VGP0eT9VYto1GaSw-1 Received: by mail-ed1-f72.google.com with SMTP id w8so2256015edx.0 for ; Fri, 09 Apr 2021 00:38:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=fkrozLMJPACVkdmHi98evbnJXUcRYylIKOGu+prd3Vg=; b=W8LIOczbjnaciJkQISjXxJvTPAcd2fCh7U6Z74BixALyLaUNKaefg7H8rSzukM6reN cF/vgmo6m+ffgTGtZWiXETlUacDRxW1xOAYVlH3zKtRDbeATspy61ION8WgcSRQi5sRz nE6firzCprpHHjT6Y/bubsK9HrfcFAC5QUjOcLumXyv78RK0UyFNqbst8X/E92ygkNmU /vIgGRv6DDslRXhatRq5Nmc7TWpFxOx8uCx++BwEWMssahQXd2IuAeANcQ0rMEArZ/zt 0ZXdHdjtNLrmvoWhhDwurv5YgNU3fflLSOdVF3lEp8nVCRyQixE7OfaMtZI2S+cioUCw iI7w== X-Gm-Message-State: AOAM532MgEVr+fHS6hEqFV1oS1hV9S9ZU5rrE8A/oEFyi6O9CHS1jqEE c+i8/aYhX/E078WtCFPtMM6Dbvzr+aNZ5Nu+G0C1aAOaFnCQN+7Z3JtgiFDJ2TmaWCsv1eJJqOY WcqK/k2tAAT1X X-Received: by 2002:a17:906:170d:: with SMTP id c13mr14557524eje.491.1617953884853; Fri, 09 Apr 2021 00:38:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw0b2ZoUfqjNAa81uHiiZD1Mdm+c8bRsxSc++bCivJSOo+DhWfXVhlCJ950VqISuyzIOO5GyQ== X-Received: by 2002:a17:906:170d:: with SMTP id c13mr14557510eje.491.1617953884680; Fri, 09 Apr 2021 00:38:04 -0700 (PDT) Received: from vitty.brq.redhat.com (g-server-2.ign.cz. [91.219.240.2]) by smtp.gmail.com with ESMTPSA id q18sm920852edr.26.2021.04.09.00.38.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Apr 2021 00:38:04 -0700 (PDT) From: Vitaly Kuznetsov To: Siddharth Chandrasekaran Cc: Alexander Graf , Evgeny Iakovlev , linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Paolo Bonzini , Sean Christopherson , Wanpeng Li , Jim Mattson , Joerg Roedel Subject: Re: [PATCH 4/4] KVM: hyper-v: Advertise support for fast XMM hypercalls In-Reply-To: <20210408155220.GB32315@u366d62d47e3651.ant.amazon.com> References: <20210407211954.32755-1-sidcha@amazon.de> <20210407211954.32755-5-sidcha@amazon.de> <87blap7zha.fsf@vitty.brq.redhat.com> <20210408142053.GA10636@u366d62d47e3651.ant.amazon.com> <8735w096pk.fsf@vitty.brq.redhat.com> <20210408155220.GB32315@u366d62d47e3651.ant.amazon.com> Date: Fri, 09 Apr 2021 09:38:03 +0200 Message-ID: <87zgy77vs4.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Siddharth Chandrasekaran writes: > On Thu, Apr 08, 2021 at 04:44:23PM +0200, Vitaly Kuznetsov wrote: >> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. >> >> >> >> Siddharth Chandrasekaran writes: >> >> > On Thu, Apr 08, 2021 at 02:05:53PM +0200, Vitaly Kuznetsov wrote: >> >> Siddharth Chandrasekaran writes: >> >> >> >> > Now that all extant hypercalls that can use XMM registers (based on >> >> > spec) for input/outputs are patched to support them, we can start >> >> > advertising this feature to guests. >> >> > >> >> > Cc: Alexander Graf >> >> > Cc: Evgeny Iakovlev >> >> > Signed-off-by: Siddharth Chandrasekaran >> >> > --- >> >> > arch/x86/include/asm/hyperv-tlfs.h | 4 ++-- >> >> > arch/x86/kvm/hyperv.c | 1 + >> >> > 2 files changed, 3 insertions(+), 2 deletions(-) >> >> > >> >> > diff --git a/arch/x86/include/asm/hyperv-tlfs.h b/arch/x86/include/asm/hyperv-tlfs.h >> >> > index e6cd3fee562b..1f160ef60509 100644 >> >> > --- a/arch/x86/include/asm/hyperv-tlfs.h >> >> > +++ b/arch/x86/include/asm/hyperv-tlfs.h >> >> > @@ -49,10 +49,10 @@ >> >> > /* Support for physical CPU dynamic partitioning events is available*/ >> >> > #define HV_X64_CPU_DYNAMIC_PARTITIONING_AVAILABLE BIT(3) >> >> > /* >> >> > - * Support for passing hypercall input parameter block via XMM >> >> > + * Support for passing hypercall input and output parameter block via XMM >> >> > * registers is available >> >> > */ >> >> > -#define HV_X64_HYPERCALL_PARAMS_XMM_AVAILABLE BIT(4) >> >> > +#define HV_X64_HYPERCALL_PARAMS_XMM_AVAILABLE BIT(4) | BIT(15) >> >> >> >> TLFS 6.0b states that there are two distinct bits for input and output: >> >> >> >> CPUID Leaf 0x40000003.EDX: >> >> Bit 4: support for passing hypercall input via XMM registers is available. >> >> Bit 15: support for returning hypercall output via XMM registers is available. >> >> >> >> and HV_X64_HYPERCALL_PARAMS_XMM_AVAILABLE is not currently used >> >> anywhere, I'd suggest we just rename >> >> >> >> HV_X64_HYPERCALL_PARAMS_XMM_AVAILABLE to HV_X64_HYPERCALL_XMM_INPUT_AVAILABLE >> >> and add HV_X64_HYPERCALL_XMM_OUTPUT_AVAILABLE (bit 15). >> > >> > That is how I had it initially; but then noticed that we would never >> > need to use either of them separately. So it seemed like a reasonable >> > abstraction to put them together. >> > >> >> Actually, we may. In theory, KVM userspace may decide to expose just >> one of these two to the guest as it is not obliged to copy everything >> from KVM_GET_SUPPORTED_HV_CPUID so we will need separate >> guest_cpuid_has() checks. > > Makes sense. I'll split them and add the checks. > >> (This reminds me of something I didn't see in your series: >> we need to check that XMM hypercall parameters support was actually >> exposed to the guest as it is illegal for a guest to use it otherwise -- >> and we will likely need two checks, for input and output). > > We observed that Windows expects Hyper-V to support XMM params even if > we don't advertise this feature but if userspace wants to hide this > feature and the guest does it anyway, then it makes sense to treat it as > an illegal OP. > Out of pure curiosity, which Windows version behaves like that? And how does this work with KVM without your patches? Sane KVM userspaces will certainly expose both XMM input and output capabilities together but having an ability to hide one or both of them may come handy while debugging. Also, we weren't enforcing the rule that enlightenments not exposed to the guest don't work, even the whole Hyper-V emulation interface was available to all guests who were smart enough to know how to enable it! I don't like this for two reasons: security (large attack surface) and the fact that someone 'smart' may decide to use Hyper-V emulation features on KVM as 'general purpose' features saying 'they're always available anyway', this risks becoming an ABI. Let's at least properly check if the feature was exposed to the guest for all new enlightenments. -- Vitaly