From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E9D4CDB465 for ; Mon, 16 Oct 2023 18:33:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231678AbjJPSdo (ORCPT ); Mon, 16 Oct 2023 14:33:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229459AbjJPSdn (ORCPT ); Mon, 16 Oct 2023 14:33:43 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC095E8 for ; Mon, 16 Oct 2023 11:32:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697481172; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=gBhtjMAahK7qNJnTRYjQLrDa8WMVo0BlvR/U7mFKyww=; b=Jv69N8ooSjKBFHnSGtFbjAvDWGd49CxSrDrtI8rIEzsmzqgvzwC5CkR0s79+hiA0qyangG L5RhtkxrPvcbt+5n/ZU9tHBR+GW+GnF3/TzPIvb30H3TOXxI4+bJnn0seyK5dQwKy2k7+a LDf+XKu/DbhsbEp2at0ArnNN7t1v3vY= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-377-FuYQUqYMN8-_M63kP1i0iA-1; Mon, 16 Oct 2023 14:32:51 -0400 X-MC-Unique: FuYQUqYMN8-_M63kP1i0iA-1 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-77409676d7dso509434885a.1 for ; Mon, 16 Oct 2023 11:32:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697481171; x=1698085971; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gBhtjMAahK7qNJnTRYjQLrDa8WMVo0BlvR/U7mFKyww=; b=IY7Dt/ALGmHFdM/RkbBnh2UzFrzv77rlqB0xRuOzaXdOaHiYGkId4lt2jwaTvPdPCu tYyRoUPpCiArCMQF6afm+DisO+7LPNihC6aQwUzwtVdYGK0mTDUdrs15S6jeOe5HrXJz 1xqg5Fuh+/pe1JuwGP+uXEyymcb66LWX3Wv+gT8n46bLeTB1ddmuRuWe0vtN3+rHvBTU 0PMZgm4UHvICzSviWQz9tFyrszaAxlQLp7+XeKiqEysqR4sp9+K6pjya6tRYUVwbXu00 InS7moPJyCgBwW3/W+IQNkVlHGlw38YXuBFay4aGkRUqyZs4CDf8R2Q6qJzh3dGWMRiz KYjA== X-Gm-Message-State: AOJu0YwP2VXFd4FeSm58jnYLea9RBXfrtPkV+YeNWnNR1qL9QoTU+URz /faoeW44f17sX+lEy6Ao57zkpk+XBvrFny4l/AsZH7AdoTzp7YpsvbSO1mFhVqoaZ87kgKcEky3 hPbl1hdPxXyiS X-Received: by 2002:ac8:5f10:0:b0:410:8bfd:1696 with SMTP id x16-20020ac85f10000000b004108bfd1696mr129150qta.49.1697481170976; Mon, 16 Oct 2023 11:32:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG/pxf7JrrbLE9/gQKQ1x4oZTHjcOIP+tJwX/R050WisaoDxfjG/Y/B2joPZFl0aWdFoxfsCA== X-Received: by 2002:ac8:5f10:0:b0:410:8bfd:1696 with SMTP id x16-20020ac85f10000000b004108bfd1696mr129139qta.49.1697481170707; Mon, 16 Oct 2023 11:32:50 -0700 (PDT) Received: from [192.168.0.5] (ip-109-43-176-176.web.vodafone.de. [109.43.176.176]) by smtp.gmail.com with ESMTPSA id l18-20020ac84592000000b0041b0b869511sm3216282qtn.65.2023.10.16.11.32.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Oct 2023 11:32:50 -0700 (PDT) Message-ID: <880f77b3-2af1-43fb-bfa9-a80a7fc8053c@redhat.com> Date: Mon, 16 Oct 2023 20:32:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [kvm-unit-tests PATCH 2/3] migration: Fix test harness hang if source does not reach migration point Content-Language: en-US To: Nico Boehr , Nicholas Piggin , kvm@vger.kernel.org Cc: Paolo Bonzini References: <20230725033937.277156-1-npiggin@gmail.com> <20230725033937.277156-3-npiggin@gmail.com> <169052965551.15205.2179571087904012453@t14-nrb> <169564046337.31925.7932230191015216618@t14-nrb> From: Thomas Huth Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <169564046337.31925.7932230191015216618@t14-nrb> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 25/09/2023 13.14, Nico Boehr wrote: > Quoting Nicholas Piggin (2023-07-30 12:03:36) >> On Fri Jul 28, 2023 at 5:34 PM AEST, Nico Boehr wrote: >>> Quoting Nicholas Piggin (2023-07-25 05:39:36) >>>> After starting the test, the harness waits polling for "migrate" in the >>>> output. If the test does not print for some reason, the harness hangs. >>>> >>>> Test that the pid is still alive while polling to fix this hang. >>>> >>>> While here, wait for the full string "Now migrate the VM", which I think >>>> makes it more obvious to read and could avoid an unfortunate collision >>>> with some debugging output in a test case. >>>> >>>> Signed-off-by: Nicholas Piggin >>> >>> Thanks for attempting to fix this! >>> >>>> --- >>>> scripts/arch-run.bash | 10 +++++++++- >>>> 1 file changed, 9 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/scripts/arch-run.bash b/scripts/arch-run.bash >>>> index 518607f4..30e535c7 100644 >>>> --- a/scripts/arch-run.bash >>>> +++ b/scripts/arch-run.bash >>>> @@ -142,6 +142,7 @@ run_migration () >>>> >>>> eval "$@" -chardev socket,id=mon1,path=${qmp1},server=on,wait=off \ >>>> -mon chardev=mon1,mode=control | tee ${migout1} & >>>> + live_pid=`jobs -l %+ | grep "eval" | awk '{print$2}'` >>> >>> Pardon my ignorance, but why would $! not work here? >> >> My mastery of bash is poor, I copied the incoming_pid line. It seems >> to work, but if you think $! is better I can try it. > > Sorry, this fell off of my radar after going to summer holiday... > > Reviewed-by: Nico Boehr Hi Nicholas & Nico, do you want me to pick up this patch as is, or do you want to respin with $! instead? Thomas