From: Paolo Bonzini <pbonzini@redhat.com>
To: Tianrui Zhao <zhaotianrui@loongson.cn>
Cc: Huacai Chen <chenhuacai@kernel.org>,
WANG Xuerui <kernel@xen0n.name>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
loongarch@lists.linux.dev, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Mark Brown <broonie@kernel.org>,
Alex Deucher <alexander.deucher@amd.com>,
Oliver Upton <oliver.upton@linux.dev>,
maobibo@loongson.cn
Subject: Re: [PATCH v2 27/29] LoongArch: KVM: Implement vcpu world switch
Date: Tue, 21 Feb 2023 09:18:23 +0100 [thread overview]
Message-ID: <884fdf34-e675-2ebe-e37f-6aeb696a0922@redhat.com> (raw)
In-Reply-To: <20230220065735.1282809-28-zhaotianrui@loongson.cn>
On 2/20/23 07:57, Tianrui Zhao wrote:
> + or a0, s0, zero
> + or a1, s1, zero
> + ld.d t8, a2, KVM_ARCH_HANDLE_EXIT
> + jirl ra,t8, 0
> + ori t0, zero, CSR_CRMD_IE
> + csrxchg zero, t0, LOONGARCH_CSR_CRMD
_kvm_handle_exit returns with the interrupts disabled.
Can you please add a comment to explain why CRMD.IE needs to be cleared
here, or remove these two instructions if unnecessary?
Paolo
> + or a2, s1, zero
> + addi.d a2, a2, KVM_VCPU_ARCH
> +
> + andi t0, a0, RESUME_HOST
> + bnez t0, ret_to_host
next prev parent reply other threads:[~2023-02-21 8:19 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 6:57 [PATCH v2 00/29] Add KVM LoongArch support Tianrui Zhao
2023-02-20 6:57 ` [PATCH v2 01/29] LoongArch: KVM: Add kvm related header files Tianrui Zhao
2023-02-20 18:22 ` Paolo Bonzini
2023-02-21 2:56 ` Tianrui Zhao
2023-02-21 6:49 ` Paolo Bonzini
2023-02-20 18:54 ` WANG Xuerui
2023-02-21 4:36 ` Xi Ruoyao
2023-02-24 1:27 ` Tianrui Zhao
2023-02-20 6:57 ` [PATCH v2 02/29] LoongArch: KVM: Implement kvm module related interface Tianrui Zhao
2023-02-20 17:46 ` Paolo Bonzini
2023-02-21 3:02 ` Tianrui Zhao
2023-02-21 6:59 ` maobibo
2023-02-21 8:14 ` Paolo Bonzini
2023-02-21 10:18 ` maobibo
2023-02-21 10:37 ` WANG Xuerui
2023-02-21 11:39 ` maobibo
2023-02-21 12:38 ` WANG Xuerui
2023-02-20 6:57 ` [PATCH v2 03/29] LoongArch: KVM: Implement kvm hardware enable, disable interface Tianrui Zhao
2023-02-20 6:57 ` [PATCH v2 04/29] LoongArch: KVM: Implement VM related functions Tianrui Zhao
2023-02-20 6:57 ` [PATCH v2 05/29] LoongArch: KVM: Add vcpu related header files Tianrui Zhao
2023-02-20 18:57 ` WANG Xuerui
2023-02-27 1:39 ` Tianrui Zhao
2023-02-21 4:44 ` Xi Ruoyao
2023-02-21 6:46 ` maobibo
2023-02-21 6:48 ` Paolo Bonzini
2023-02-21 7:12 ` Xi Ruoyao
2023-02-21 7:35 ` Paolo Bonzini
2023-02-20 6:57 ` [PATCH v2 06/29] LoongArch: KVM: Implement vcpu create and destroy interface Tianrui Zhao
2023-02-20 17:53 ` Paolo Bonzini
2023-02-22 1:52 ` Tianrui Zhao
2023-02-22 12:17 ` Paolo Bonzini
2023-02-23 1:23 ` Tianrui Zhao
2023-02-20 6:57 ` [PATCH v2 07/29] LoongArch: KVM: Implement vcpu run interface Tianrui Zhao
2023-02-20 18:44 ` Paolo Bonzini
2023-02-22 2:08 ` Tianrui Zhao
2023-02-20 6:57 ` [PATCH v2 08/29] LoongArch: KVM: Implement vcpu handle exit interface Tianrui Zhao
2023-02-20 17:46 ` Paolo Bonzini
2023-02-20 18:45 ` Paolo Bonzini
2023-02-21 3:17 ` Tianrui Zhao
2023-02-20 6:57 ` [PATCH v2 09/29] LoongArch: KVM: Implement vcpu get, vcpu set registers Tianrui Zhao
2023-02-20 6:57 ` [PATCH v2 10/29] LoongArch: KVM: Implement vcpu ENABLE_CAP, CHECK_EXTENSION ioctl interface Tianrui Zhao
2023-02-20 6:57 ` [PATCH v2 11/29] LoongArch: KVM: Implement fpu related operations for vcpu Tianrui Zhao
2023-02-20 6:57 ` [PATCH v2 12/29] LoongArch: KVM: Implement vcpu interrupt operations Tianrui Zhao
2023-02-20 6:57 ` [PATCH v2 13/29] LoongArch: KVM: Implement misc vcpu related interfaces Tianrui Zhao
2023-02-20 18:50 ` Paolo Bonzini
2023-02-21 3:19 ` Tianrui Zhao
2023-02-20 6:57 ` [PATCH v2 14/29] LoongArch: KVM: Implement vcpu load and vcpu put operations Tianrui Zhao
2023-02-20 6:57 ` [PATCH v2 15/29] LoongArch: KVM: Implement vcpu status description Tianrui Zhao
2023-02-20 6:57 ` [PATCH v2 16/29] LoongArch: KVM: Implement update VM id function Tianrui Zhao
2023-02-20 6:57 ` [PATCH v2 17/29] LoongArch: KVM: Implement virtual machine tlb operations Tianrui Zhao
2023-02-20 6:57 ` [PATCH v2 18/29] LoongArch: KVM: Implement vcpu timer operations Tianrui Zhao
2023-02-20 6:57 ` [PATCH v2 19/29] LoongArch: KVM: Implement kvm mmu operations Tianrui Zhao
2023-02-20 6:57 ` [PATCH v2 20/29] LoongArch: KVM: Implement handle csr excption Tianrui Zhao
2023-02-20 6:57 ` [PATCH v2 21/29] LoongArch: KVM: Implement handle iocsr exception Tianrui Zhao
2023-02-20 6:57 ` [PATCH v2 22/29] LoongArch: KVM: Implement handle idle exception Tianrui Zhao
2023-02-20 18:40 ` Paolo Bonzini
2023-02-21 9:48 ` Tianrui Zhao
2023-02-20 6:57 ` [PATCH v2 23/29] LoongArch: KVM: Implement handle gspr exception Tianrui Zhao
2023-02-20 6:57 ` [PATCH v2 24/29] LoongArch: KVM: Implement handle mmio exception Tianrui Zhao
2023-02-20 6:57 ` [PATCH v2 25/29] LoongArch: KVM: Implement handle fpu exception Tianrui Zhao
2023-02-20 6:57 ` [PATCH v2 26/29] LoongArch: KVM: Implement kvm exception vector Tianrui Zhao
2023-02-20 6:57 ` [PATCH v2 27/29] LoongArch: KVM: Implement vcpu world switch Tianrui Zhao
2023-02-21 7:45 ` Paolo Bonzini
2023-02-21 13:00 ` Tianrui Zhao
2023-02-21 8:18 ` Paolo Bonzini [this message]
2023-02-21 12:58 ` Tianrui Zhao
2023-02-20 6:57 ` [PATCH v2 28/29] LoongArch: KVM: Implement probe virtualization when loongarch cpu init Tianrui Zhao
2023-02-20 6:57 ` [PATCH v2 29/29] LoongArch: KVM: Enable kvm config and add the makefile Tianrui Zhao
2023-02-20 9:47 ` kernel test robot
2023-02-20 11:09 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=884fdf34-e675-2ebe-e37f-6aeb696a0922@redhat.com \
--to=pbonzini@redhat.com \
--cc=alexander.deucher@amd.com \
--cc=axboe@kernel.dk \
--cc=broonie@kernel.org \
--cc=chenhuacai@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@xen0n.name \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=maobibo@loongson.cn \
--cc=oliver.upton@linux.dev \
--cc=zhaotianrui@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).