Re: [PATCH 4/6] sched: Add get_current_state()

Peter Zijlstra
2021-06-02T14:16:47Z

On Wed, Jun 02, 2021 at 10:01:29AM -0400, Mathieu Desnoyers wrote:
> ----- On Jun 2, 2021, at 9:12 AM, Peter Zijlstra peterz@infradead.org wrote:
>
> > Remove yet another few p->state accesses.
>
> [...]
>
> >
> > --- a/include/linux/sched.h
> > +++ b/include/linux/sched.h
> > @@ -212,6 +212,8 @@ struct task_group;
> >
> > #endif
> >
> > +#define get_current_state() READ_ONCE(current->state)
>
> Why use a macro rather than a static inline here ?

Mostly to be consistent, all that state stuff is macros. I suppose we
could try and make them inlines at the end or so -- if the header maze
allows.