Re: [PATCH 6/6] sched: Change task_struct::state

Will Deacon
2021-06-02T15:10:34Z

On Wed, Jun 02, 2021 at 03:12:31PM +0200, Peter Zijlstra wrote:
> Change the type and name of task_struct::state. Drop the volatile and
> shrink it to an 'unsigned int'. Rename it in order to find all uses
> such that we can use READ_ONCE/WRITE_ONCE as appropriate.
>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> ---
> block/blk-mq.c | 2 -
> drivers/md/dm.c | 6 ++--
> fs/binfmt_elf.c | 8 +++---
> fs/userfaultfd.c | 4 +--
> include/linux/sched.h | 31 +++++++++++------------
> include/linux/sched/debug.h | 2 -
> include/linux/sched/signal.h | 2 -
> init/init_task.c | 2 -
> kernel/cgroup/cgroup-v1.c | 2 -
> kernel/debug/kdb/kdb_support.c | 18 +++++++------
> kernel/fork.c | 4 +--
> kernel/hung_task.c | 2 -
> kernel/kthread.c | 4 +--
> kernel/locking/mutex.c | 6 ++--
> kernel/locking/rtmutex.c | 4 +--
> kernel/locking/rwsem.c | 2 -
> kernel/ptrace.c | 12 ++++-----
> kernel/rcu/rcutorture.c | 4 +--
> kernel/rcu/tree_stall.h | 12 ++++-----
> kernel/sched/core.c | 53 +++++++++++++++++++++--------------------
> kernel/sched/deadline.c | 10 +++----
> kernel/sched/fair.c | 11 +++++---
> lib/syscall.c | 4 +--
> net/core/dev.c | 2 -
> 24 files changed, 108 insertions(+), 99 deletions(-)

I think this makes the code a _lot_ easier to understand, so:

Acked-by: Will Deacon <will@kernel.org>

on the assumption that you'll fix get_wchan() for !x86 as well.

Cheers,

Will