Re: [PATCH 2/6] sched: Introduce task_is_running()

Will Deacon
2021-06-02T14:59:38Z

On Wed, Jun 02, 2021 at 03:12:27PM +0200, Peter Zijlstra wrote:
> Replace a bunch of 'p->state == TASK_RUNNING' with a new helper:
> task_is_running(p).
>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> ---
> arch/x86/kernel/process.c | 4 ++--
> block/blk-mq.c | 2 +-
> include/linux/sched.h | 2 ++
> kernel/locking/lockdep.c | 2 +-
> kernel/rcu/tree_plugin.h | 2 +-
> kernel/sched/core.c | 6 +++---
> kernel/sched/stats.h | 2 +-
> kernel/signal.c | 2 +-
> kernel/softirq.c | 3 +--
> mm/compaction.c | 2 +-
> 10 files changed, 14 insertions(+), 13 deletions(-)
>
> --- a/arch/x86/kernel/process.c
> +++ b/arch/x86/kernel/process.c
> @@ -931,7 +931,7 @@ unsigned long get_wchan(struct task_stru
> unsigned long start, bottom, top, sp, fp, ip, ret = 0;
> int count = 0;
>
> - if (p == current || p->state == TASK_RUNNING)
> + if (p == current || task_is_running(p))

Looks like this one in get_wchan() has been cargo-culted across most of
arch/ so they'll need fixing up before you rename the struct member.

There's also a weird one in tools/bpf/runqslower/runqslower.bpf.c (!)

Will