From: Tadeusz Struk <tadeusz.struk@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>,
Sean Christopherson <seanjc@google.com>
Cc: Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+8112db3ab20e70d50c31@syzkaller.appspotmail.com
Subject: Re: [PATCH] KVM: x86: Forcibly leave nested virt when SMM state is toggled
Date: Thu, 24 Feb 2022 10:59:53 -0800 [thread overview]
Message-ID: <8d3a11be-a7eb-5ad0-2ef6-abc9276ced2f@linaro.org> (raw)
In-Reply-To: <6cef7c8a-10d3-9fc6-f68d-220fdfc079c1@redhat.com>
On 2/18/22 10:14, Paolo Bonzini wrote:
> On 2/18/22 18:22, Tadeusz Struk wrote:
>> On 2/18/22 08:58, Sean Christopherson wrote:
>>> This SMM-specific patch fixes something different, the bug that you are still
>>> hitting is the FNAME(cmpxchg_gpte) mess. The uaccess CMPXCHG series[*] that
>>> properly fixes that issue hasn't been merged yet.
>>>
>>> ==================================================================
>>> BUG: KASAN: use-after-free in ept_cmpxchg_gpte.constprop.0+0x3c3/0x590
>>> Write of size 8 at addr ffff888010000000 by task repro/5633
>>>
>>> [*]https://lore.kernel.org/all/20220202004945.2540433-1-seanjc@google.com
>>>
>>
>> Ok, that's good. I will keep an eye on it and give it a try then.
>
> I'll poke PeterZ for a review next week.
>
Paulo, do you know if PeterZ had a chance to look at the uaccess patches yet?
--
Thanks,
Tadeusz
prev parent reply other threads:[~2022-02-24 18:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-25 22:03 [PATCH] KVM: x86: Forcibly leave nested virt when SMM state is toggled Sean Christopherson
2022-01-26 8:26 ` Maxim Levitsky
2022-01-26 16:08 ` Sean Christopherson
2022-01-26 11:24 ` Paolo Bonzini
2022-02-17 20:21 ` Tadeusz Struk
2022-02-18 16:58 ` Sean Christopherson
2022-02-18 17:22 ` Tadeusz Struk
2022-02-18 18:14 ` Paolo Bonzini
2022-02-24 18:59 ` Tadeusz Struk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d3a11be-a7eb-5ad0-2ef6-abc9276ced2f@linaro.org \
--to=tadeusz.struk@linaro.org \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=syzbot+8112db3ab20e70d50c31@syzkaller.appspotmail.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox