From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0579EC56201 for ; Tue, 24 Nov 2020 09:07:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9360020782 for ; Tue, 24 Nov 2020 09:07:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="1TYjrVTN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731086AbgKXJHJ (ORCPT ); Tue, 24 Nov 2020 04:07:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:33000 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730956AbgKXJHJ (ORCPT ); Tue, 24 Nov 2020 04:07:09 -0500 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3FB8A2075A; Tue, 24 Nov 2020 09:07:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606208828; bh=YKBAEa1S7x5XyrSw9i58+TYmKcHvXHjT1wTkrq7seHc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=1TYjrVTNfjqRUqQ/Iq86CER/48R56RG15mANFIvrlo9mW1LXuq4cPU6J1UPtrskq+ Y/4ztGT3YKOQUxjApd/8IVwhnC1II+KQXMqYOUxLDqarudt1tbzm7u4Jx2fQvqEsLC Dsp1C5/QeN917gO0flLsoG/WxZDDD3SzTT8JrL3c= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94) (envelope-from ) id 1khUHy-00DCBp-50; Tue, 24 Nov 2020 09:07:06 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 24 Nov 2020 09:07:06 +0000 From: Marc Zyngier To: Jianyong Wu Cc: netdev@vger.kernel.org, yangbo.lu@nxp.com, john.stultz@linaro.org, tglx@linutronix.de, pbonzini@redhat.com, sean.j.christopherson@intel.com, richardcochran@gmail.com, Mark Rutland , will@kernel.org, Suzuki Poulose , Andre Przywara , Steven Price , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Steve Capper , Justin He , nd Subject: Re: [PATCH v15 6/9] arm64/kvm: Add hypercall service for kvm ptp. In-Reply-To: References: <20201111062211.33144-1-jianyong.wu@arm.com> <20201111062211.33144-7-jianyong.wu@arm.com> User-Agent: Roundcube Webmail/1.4.9 Message-ID: <9133f26699c5fc08d0ea72acfa9aca3b@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: Jianyong.Wu@arm.com, netdev@vger.kernel.org, yangbo.lu@nxp.com, john.stultz@linaro.org, tglx@linutronix.de, pbonzini@redhat.com, sean.j.christopherson@intel.com, richardcochran@gmail.com, Mark.Rutland@arm.com, will@kernel.org, Suzuki.Poulose@arm.com, Andre.Przywara@arm.com, Steven.Price@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Steve.Capper@arm.com, Justin.He@arm.com, nd@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 2020-11-24 05:20, Jianyong Wu wrote: > Hi Marc, [...] >> > +/* ptp_kvm counter type ID */ >> > +#define ARM_PTP_VIRT_COUNTER 0 >> > +#define ARM_PTP_PHY_COUNTER 1 >> > +#define ARM_PTP_NONE_COUNTER 2 >> >> The architecture definitely doesn't have this last counter. > > Yeah, this is just represent no counter data needed from guest. > Some annotation should be added here. I'd rather you remove it entirely, or explain why you really cannot do without a fake counter. M. -- Jazz is not dead. It just smells funny...