From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5DCBC54EBE for ; Tue, 10 Jan 2023 08:39:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230423AbjAJIip (ORCPT ); Tue, 10 Jan 2023 03:38:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238064AbjAJIh6 (ORCPT ); Tue, 10 Jan 2023 03:37:58 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D91C848CEC for ; Tue, 10 Jan 2023 00:36:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673339795; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OA5uFXsjy9VOrtOt4v6gI0JId1gSQ8b6AXjXO1XR9p4=; b=YdJZv3mKgVgyettOlhoYR+Oc8//ShJiIpqQ/7VKJb3Ve4KS5U2zO3w71togoSatkHTMFKa ks2JBCmgLMfY3lXDcK1UtFhYoVZG++VK+XZUOoG2WL+dU+MdSSF+zVbp+alKg9WeJwLPl1 RZHtAJidUvnjr2Xyp290KkeUlkiI/dI= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-624-youporiqMguz7v0xXgc_jw-1; Tue, 10 Jan 2023 03:36:31 -0500 X-MC-Unique: youporiqMguz7v0xXgc_jw-1 Received: by mail-qv1-f71.google.com with SMTP id cx11-20020a056214188b00b00531cacde854so6497520qvb.6 for ; Tue, 10 Jan 2023 00:36:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=OA5uFXsjy9VOrtOt4v6gI0JId1gSQ8b6AXjXO1XR9p4=; b=PziUddjCnpHL2KxhJAjmwwmMl+aRqWiawy6wMAM5t4vOwsr6DCp+5o2fikyYpC43Vu legoksl7vweZRHIN66mFDn98+3K7p32xci0Xkm1vq1aUfTmsrApbMCissgAyZj8Wq+Pf mS0IdOTmDpu5kXdsgxpi2Fr86s39PCLq1DLy2InQs2fQLHhRYokuRkY6YtgboACpVZdA U6+V4O3QtmUSQkMJrcxClrUFSvQdHZNT8L/TZVi1luarDB+dykVD70Ny9BPyYQxJ4Bjj Ekn/V8IDcxQvVCB96x7TsCtnRDerWBtlmLDP/5bM1oa+bQd6TtpndQtyDOO7+1wLG5FJ fI6Q== X-Gm-Message-State: AFqh2kpLWYtDAsugEWxfSGkGrQ2Z+qSzk0uPhprxp3W6Xn6cyj1nhr1c Cm+D9UdNhD2veuRu4ktsy4Wgf1C+477AWdrh3Weu0+N131KJ2InG+ezclQa0Muxx5sU+xTPpk+R iy2xjbDiens3a X-Received: by 2002:ac8:6e87:0:b0:3a8:11f3:b81c with SMTP id c7-20020ac86e87000000b003a811f3b81cmr92473607qtv.53.1673339790900; Tue, 10 Jan 2023 00:36:30 -0800 (PST) X-Google-Smtp-Source: AMrXdXtHKXcGwIf1YTV+2xcYytzlbmWmXvkPsMytlZlxe1TCEXregd5S2XFcyMVIu2vtJs6MCGLTzg== X-Received: by 2002:ac8:6e87:0:b0:3a8:11f3:b81c with SMTP id c7-20020ac86e87000000b003a811f3b81cmr92473590qtv.53.1673339790644; Tue, 10 Jan 2023 00:36:30 -0800 (PST) Received: from gerbillo.redhat.com (146-241-120-128.dyn.eolo.it. [146.241.120.128]) by smtp.gmail.com with ESMTPSA id s24-20020ac87598000000b003a7e9db074asm5687861qtq.67.2023.01.10.00.36.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jan 2023 00:36:30 -0800 (PST) Message-ID: <91593e9c8a475a26a465369f6caff86ac5d662e3.camel@redhat.com> Subject: Re: [PATCH net-next v9] virtio/vsock: replace virtio_vsock_pkt with sk_buff From: Paolo Abeni To: Bobby Eshleman Cc: Bobby Eshleman , Cong Wang , Stefano Garzarella , Stefan Hajnoczi , "Michael S. Tsirkin" , Jason Wang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 10 Jan 2023 09:36:26 +0100 In-Reply-To: <20230107002937.899605-1-bobby.eshleman@bytedance.com> References: <20230107002937.899605-1-bobby.eshleman@bytedance.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Sat, 2023-01-07 at 00:29 +0000, Bobby Eshleman wrote: > This commit changes virtio/vsock to use sk_buff instead of > virtio_vsock_pkt. Beyond better conforming to other net code, using > sk_buff allows vsock to use sk_buff-dependent features in the future > (such as sockmap) and improves throughput. > > This patch introduces the following performance changes: > > Tool/Config: uperf w/ 64 threads, SOCK_STREAM > Test Runs: 5, mean of results > Before: commit 95ec6bce2a0b ("Merge branch 'net-ipa-more-endpoints'") > > Test: 64KB, g2h > Before: 21.63 Gb/s > After: 25.59 Gb/s (+18%) > > Test: 16B, g2h > Before: 11.86 Mb/s > After: 17.41 Mb/s (+46%) > > Test: 64KB, h2g > Before: 2.15 Gb/s > After: 3.6 Gb/s (+67%) > > Test: 16B, h2g > Before: 14.38 Mb/s > After: 18.43 Mb/s (+28%) > > Signed-off-by: Bobby Eshleman > Reviewed-by: Stefano Garzarella > Acked-by: Paolo Abeni > --- > > Tested using vsock_test g2h and h2g. I'm not sure if it is standard > practice here to carry Acks and Reviews forward to future versions, but > I'm doing that here to hopefully make life easier for maintainers. > Please let me know if it is not standard practice. As Jakub noted, there is no clear rule for tag passing across different patch revisions. Here, given the complexity of the patch and the not trivial list of changes, I would have preferred you would have dropped my tag. > Changes in v9: > - check length in rx header > - guard alloactor from small requests > - squashed fix for v8 bug reported by syzbot: > syzbot+30b72abaa17c07fe39dd@syzkaller.appspotmail.com It's not clear to me what/where is the fix exactly, could you please clarify? Thanks! Paolo