From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Sebastian Herbszt" <herbszt@gmx.de>
Subject: Re: [PATCH 1/4] BIOS changes for configuring irq0->inti2 override
Date: Tue, 5 May 2009 23:38:34 +0200
Message-ID: <919A9099171C4C8DA5E9F653FEB82124@FSCPC>
References: <1241471352-1642-1-git-send-email-eak@us.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain;
	format=flowed;
	charset="iso-8859-1";
	reply-type=original
Content-Transfer-Encoding: 7bit
Cc: "Beth Kon" <eak@us.ibm.com>
To: "Beth Kon" <eak@us.ibm.com>, <kvm@vger.kernel.org>,
	"Gleb Natapov" <gleb@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail.gmx.net ([213.165.64.20]:55207 "HELO mail.gmx.net"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP
	id S1751619AbZEEVkd (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 5 May 2009 17:40:33 -0400
In-Reply-To: <1241471352-1642-1-git-send-email-eak@us.ibm.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Beth Kon wrote:
> @@ -477,6 +480,7 @@ void wrmsr_smp(uint32_t index, uint64_t val)
> #define QEMU_CFG_SIGNATURE  0x00
> #define QEMU_CFG_ID         0x01
> #define QEMU_CFG_UUID       0x02
> +#define QEMU_CFG_IRQ0_OVERRIDE 0x0e

Small thing to consider before you resubmit:
In his patch "read-additional-acpi-tables-from-a-vm.patch" Gleb introduced:

#define QEMU_CFG_ARCH_LOCAL     0x8000
#define QEMU_CFG_ACPI_TABLES  (QEMU_CFG_ARCH_LOCAL + 0)

I think the idea behind this was to seperate the generic part from arch specific.
The IRQ0 override seems to be arch specific (x86 only?) just like the ACPI tables, right?

- Sebastian