From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>,
"Thomas Huth" <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
"Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
kvm@vger.kernel.org, "Paul Durrant" <paul@xen.org>,
"Cornelia Huck" <cohuck@redhat.com>,
"Marcelo Tosatti" <mtosatti@redhat.com>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Halil Pasic" <pasic@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
qemu-s390x@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Willian Rampazzo" <wrampazz@redhat.com>,
"Huacai Chen" <chenhc@lemote.com>,
"Anthony Perard" <anthony.perard@citrix.com>,
xen-devel@lists.xenproject.org,
"David Gibson" <david@gibson.dropbear.id.au>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Claudio Fontana" <cfontana@suse.de>
Subject: Re: [PATCH 5/8] gitlab-ci: Add KVM s390x cross-build jobs
Date: Mon, 7 Dec 2020 11:26:58 +0100 [thread overview]
Message-ID: <9233fe7f-8d56-e1ad-b67e-40b3ce5fcabb@redhat.com> (raw)
In-Reply-To: <20201207102450.GG3102898@redhat.com>
On 12/7/20 11:25 AM, Daniel P. Berrangé wrote:
> On Mon, Dec 07, 2020 at 06:46:01AM +0100, Thomas Huth wrote:
>> On 06/12/2020 19.55, Philippe Mathieu-Daudé wrote:
>>> Cross-build s390x target with only KVM accelerator enabled.
>>>
>>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>>> ---
>>> .gitlab-ci.d/crossbuilds-kvm-s390x.yml | 6 ++++++
>>> .gitlab-ci.yml | 1 +
>>> MAINTAINERS | 1 +
>>> 3 files changed, 8 insertions(+)
>>> create mode 100644 .gitlab-ci.d/crossbuilds-kvm-s390x.yml
>>>
>>> diff --git a/.gitlab-ci.d/crossbuilds-kvm-s390x.yml b/.gitlab-ci.d/crossbuilds-kvm-s390x.yml
>>> new file mode 100644
>>> index 00000000000..1731af62056
>>> --- /dev/null
>>> +++ b/.gitlab-ci.d/crossbuilds-kvm-s390x.yml
>>> @@ -0,0 +1,6 @@
>>> +cross-s390x-kvm:
>>> + extends: .cross_accel_build_job
>>> + variables:
>>> + IMAGE: debian-s390x-cross
>>> + TARGETS: s390x-softmmu
>>> + ACCEL_CONFIGURE_OPTS: --disable-tcg
>>> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
>>> index 573afceb3c7..a69619d7319 100644
>>> --- a/.gitlab-ci.yml
>>> +++ b/.gitlab-ci.yml
>>> @@ -14,6 +14,7 @@ include:
>>> - local: '/.gitlab-ci.d/crossbuilds.yml'
>>> - local: '/.gitlab-ci.d/crossbuilds-kvm-x86.yml'
>>> - local: '/.gitlab-ci.d/crossbuilds-kvm-arm.yml'
>>> + - local: '/.gitlab-ci.d/crossbuilds-kvm-s390x.yml'
>>
>> KVM code is already covered by the "cross-s390x-system" job, but an
>> additional compilation test with --disable-tcg makes sense here. I'd then
>> rather name it "cross-s390x-no-tcg" or so instead of "cross-s390x-kvm".
>>
>> And while you're at it, I'd maybe rather name the new file just
>> crossbuilds-s390x.yml and also move the other s390x related jobs into it?
>
> I don't think we really should split it up so much - just put these
> jobs in the existing crosbuilds.yml file.
Don't we want to leverage MAINTAINERS file?
next prev parent reply other threads:[~2020-12-07 10:28 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-06 18:55 [PATCH 0/8] gitlab-ci: Add accelerator-specific Linux jobs Philippe Mathieu-Daudé
2020-12-06 18:55 ` [PATCH 1/8] gitlab-ci: Replace YAML anchors by extends (cross_system_build_job) Philippe Mathieu-Daudé
2020-12-07 5:11 ` Thomas Huth
2020-12-06 18:55 ` [PATCH 2/8] gitlab-ci: Introduce 'cross_accel_build_job' template Philippe Mathieu-Daudé
2020-12-06 19:23 ` Claudio Fontana
2020-12-06 23:44 ` Philippe Mathieu-Daudé
2020-12-06 18:55 ` [PATCH 3/8] gitlab-ci: Add KVM X86 cross-build jobs Philippe Mathieu-Daudé
2020-12-07 5:20 ` Thomas Huth
2020-12-07 10:04 ` Philippe Mathieu-Daudé
2020-12-06 18:55 ` [PATCH 4/8] gitlab-ci: Add KVM ARM " Philippe Mathieu-Daudé
2020-12-07 5:41 ` Thomas Huth
2020-12-06 18:55 ` [PATCH 5/8] gitlab-ci: Add KVM s390x " Philippe Mathieu-Daudé
2020-12-07 5:46 ` Thomas Huth
2020-12-07 10:00 ` Philippe Mathieu-Daudé
2020-12-07 10:26 ` Philippe Mathieu-Daudé
2020-12-07 10:33 ` Thomas Huth
2020-12-07 10:37 ` Philippe Mathieu-Daudé
2020-12-07 10:25 ` Daniel P. Berrangé
2020-12-07 10:26 ` Philippe Mathieu-Daudé [this message]
2020-12-07 10:34 ` Daniel P. Berrangé
2020-12-07 11:14 ` Philippe Mathieu-Daudé
2020-12-07 11:26 ` Philippe Mathieu-Daudé
2020-12-06 18:55 ` [PATCH 6/8] gitlab-ci: Add KVM PPC " Philippe Mathieu-Daudé
2020-12-07 1:38 ` David Gibson
2020-12-07 5:57 ` Thomas Huth
2020-12-06 18:55 ` [PATCH 7/8] gitlab-ci: Add KVM MIPS " Philippe Mathieu-Daudé
2020-12-07 5:58 ` Thomas Huth
2020-12-06 18:55 ` [PATCH 8/8] gitlab-ci: Add Xen " Philippe Mathieu-Daudé
2020-12-07 10:23 ` [PATCH 0/8] gitlab-ci: Add accelerator-specific Linux jobs Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9233fe7f-8d56-e1ad-b67e-40b3ce5fcabb@redhat.com \
--to=philmd@redhat.com \
--cc=aleksandar.rikalo@syrmia.com \
--cc=alex.bennee@linaro.org \
--cc=anthony.perard@citrix.com \
--cc=aurelien@aurel32.net \
--cc=berrange@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cfontana@suse.de \
--cc=chenhc@lemote.com \
--cc=cohuck@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
--cc=wrampazz@redhat.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox