From: Paolo Bonzini <pbonzini@redhat.com>
To: "Vitaly Kuznetsov" <vkuznets@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Tom Lendacky <thomas.lendacky@amd.com>,
Joerg Roedel <joro@8bytes.org>,
x86@kernel.org
Subject: Re: [PATCH] KVM: x86: svm: report MSR_IA32_MCG_EXT_CTL as unsupported
Date: Fri, 21 Dec 2018 12:18:10 +0100 [thread overview]
Message-ID: <92c7795c-8d0c-bfb6-e272-27e8441783dd@redhat.com> (raw)
In-Reply-To: <8736qrw5vn.fsf@vitty.brq.redhat.com>
On 21/12/18 11:06, Vitaly Kuznetsov wrote:
>> Btw, I would prefer this without the
>>
>> default: break;
>>
>> as I don't think we'll ever add something there.
>
> "640K ought to be enough for anybody" :-)
>
> But in case you commit it as
>
> return index != MSR_IA32_MCG_EXT_CTL;
>
> I won't object. Thanks,
Radim committed it as it, but I think he did want the switch statement
(hey, vmx_has_emulated_msr has *two* cases!). It's just the "default:
break;" that is unnecessary or could be "default: return true;".
Paolo
prev parent reply other threads:[~2018-12-21 11:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-19 11:06 [PATCH] KVM: x86: svm: report MSR_IA32_MCG_EXT_CTL as unsupported Vitaly Kuznetsov
2018-12-20 20:06 ` Radim Krčmář
2018-12-21 10:06 ` Vitaly Kuznetsov
2018-12-21 11:18 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92c7795c-8d0c-bfb6-e272-27e8441783dd@redhat.com \
--to=pbonzini@redhat.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rkrcmar@redhat.com \
--cc=thomas.lendacky@amd.com \
--cc=vkuznets@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox