public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Feiner <pfeiner@google.com>
Cc: kvm@vger.kernel.org, David Matlack <dmatlack@google.com>
Subject: Re: [PATCH kvm-unit-tests 2/2] vmx: fix expected results of new EPT tests
Date: Thu, 11 May 2017 13:30:26 -0400 (EDT)	[thread overview]
Message-ID: <95409579.6813190.1494523826371.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <CAM3pwhEag1o7u5SujY1ATqYoOf6tcciz11eFM4XyUjscx2N8cA@mail.gmail.com>



----- Original Message -----
> From: "Peter Feiner" <pfeiner@google.com>
> To: "Paolo Bonzini" <pbonzini@redhat.com>
> Cc: kvm@vger.kernel.org, "David Matlack" <dmatlack@google.com>
> Sent: Thursday, May 11, 2017 5:58:49 PM
> Subject: Re: [PATCH kvm-unit-tests 2/2] vmx: fix expected results of new EPT tests
> 
> On Thu, May 11, 2017 at 4:23 AM, Paolo Bonzini <pbonzini@redhat.com> wrote:
> > Remove RD/EX exchange hack which we can fix in KVM; mark page table
> > accesses as read/write when EPT A/D is enabled, and expect them to
> > be handled as read/write even with disabled EPT A/D bits (even though
> > the exit qualification says otherwise).
> 
> I assume this is a stopgap change. I mean, you're asserting for the
> wrong behavior just so the tests pass. Correct?

No, I've tried the tests on upstream Linux with eptad=0 (so that EPT A/D
is not used by KVM on the host) and they also hang with an infinite stream
of EPT violations.  See the KVM patch I sent which also explains the hang
in the comments ("[PATCH 2/2] KVM: nVMX: fix nEPT handling of guest page
table accesses").

So it seems to me that this is the expected behavior of the processor
even when A/D bits are disabled.  I haven't tested on a processor with
EPT but without A/D bits though.

Paolo

  reply	other threads:[~2017-05-11 17:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-11 11:23 [PATCH kvm-unit-tests 0/2] vmx: fixes to v2 tests Paolo Bonzini
2017-05-11 11:23 ` [PATCH kvm-unit-tests 1/2] vmx: always perform access with modified page table for PADDR tests Paolo Bonzini
2017-05-11 11:23 ` [PATCH kvm-unit-tests 2/2] vmx: fix expected results of new EPT tests Paolo Bonzini
2017-05-11 15:58   ` Peter Feiner
2017-05-11 17:30     ` Paolo Bonzini [this message]
2017-05-11 19:51       ` David Matlack
2017-05-12  8:45         ` Paolo Bonzini
2017-05-12 23:45           ` David Matlack
2017-05-13 12:44             ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=95409579.6813190.1494523826371.JavaMail.zimbra@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=dmatlack@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=pfeiner@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox