From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [kvm-unit-tests PATCH v8 08/12] x86: Cleanup PAGE_* constants Date: Wed, 8 Jun 2016 06:19:31 -0400 (EDT) Message-ID: <969743849.20781952.1465381171054.JavaMail.zimbra@redhat.com> References: <67978bcc43b1e15d826583ce26b828ea4bdc6b7e.1465207665.git.agordeev@redhat.com> <20160608075940.GC1565@agordeev.lab.eng.brq.redhat.com> <1259165288.20762327.1465372687004.JavaMail.zimbra@redhat.com> <20160608100741.aomfv4ue6rsxml7r@hawk.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Alexander Gordeev , kvm@vger.kernel.org, Thomas Huth , Radim =?utf-8?B?S3LEjW3DocWZ?= To: Andrew Jones Return-path: Received: from mx5-phx2.redhat.com ([209.132.183.37]:36986 "EHLO mx5-phx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423317AbcFHKTc convert rfc822-to-8bit (ORCPT ); Wed, 8 Jun 2016 06:19:32 -0400 In-Reply-To: <20160608100741.aomfv4ue6rsxml7r@hawk.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: ----- Original Message ----- > From: "Andrew Jones" > To: "Paolo Bonzini" > Cc: "Alexander Gordeev" , kvm@vger.kernel.org, "= Thomas Huth" , "Radim Kr=C4=8Dm=C3=A1=C5=99" > > Sent: Wednesday, June 8, 2016 12:07:41 PM > Subject: Re: [kvm-unit-tests PATCH v8 08/12] x86: Cleanup PAGE_* cons= tants >=20 > On Wed, Jun 08, 2016 at 03:58:07AM -0400, Paolo Bonzini wrote: > >=20 > > > We have page constants defined this way for every other arch: > > >=20 > > > lib/arm/asm/page.h > > > lib/arm64/asm/page.h > > > lib/asm-generic/page.h (covers ppc64) > > >=20 > > > Why not to bring x86 in line also? > >=20 > > The bug is in the others. :) There's no reason for kvm-unit-tests = to > > depend on Linux, and PAGE_SIZE is never used in assembly either. >=20 > kvm-unit-tests isn't depending on linux when including . > We have our own copies of a few Linux uapi headers in there, like > const.h. Doh, brain fart then, the patch is good. Paolo