From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25B0FC3F2D2 for ; Fri, 28 Feb 2020 09:36:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F052F246A8 for ; Fri, 28 Feb 2020 09:36:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NC1u/Aoa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726918AbgB1JgS (ORCPT ); Fri, 28 Feb 2020 04:36:18 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:58560 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726614AbgB1JgP (ORCPT ); Fri, 28 Feb 2020 04:36:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582882574; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xGQ30kUvc7fIP0RyINOYfwYjQETpcqZNSK+cVjV0fQQ=; b=NC1u/AoaRwfKzkEGtvQ+Q/3URcJfhhSFpgKANRQKmLu3sNhvqaMrYH6VMNBvLjiELnwO4N C3gV1GFRQataJIHbZBWUQuagvzhWYf0C80HVRTEhnYtXqRb5lnVWyCsoIaJqt1SQQX2vei Zm2hw1T/rvB9n4A0uo7vZDSJqH1sVzY= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-143-8mOUnVyNP3uU7l9s5_VnbQ-1; Fri, 28 Feb 2020 04:36:12 -0500 X-MC-Unique: 8mOUnVyNP3uU7l9s5_VnbQ-1 Received: by mail-wr1-f72.google.com with SMTP id u18so1084263wrn.11 for ; Fri, 28 Feb 2020 01:36:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xGQ30kUvc7fIP0RyINOYfwYjQETpcqZNSK+cVjV0fQQ=; b=bLcL1xGTLIuQRByf9mktawy1pAY3QNgbm2GivqcpZx5Ii8vGGfado5yR5CaEp/k4NN APUG/DCujUAt2ETjxEY0QPY8Z4R0tq7cr0V4ypnie1TPRC2CV6NN1CpZP9U7DBywgNdT 9uNzN5PBlFZuxmA9ANBAMSuqN18P5el3fP7YX1PlJoxp4yYOxpaDy42dsWrdXbWFrMMQ D4ni26TDuqgQics/738TUoALlO2nRc3T2oADAjbU+x6Si7KfdNW6J28YqfQAIa1dtbHi tPlSzULkh+W6ZacTiuyxmH7JypUazqAh4nVk8vEO8pzwUyH4kMWY47VQvX1rgwBcvHYf +OSQ== X-Gm-Message-State: APjAAAUVi0OuuN9EBFJpD8gaD91tPjAD3TVtfvyrJlb3u/HrBLBOSABS BOjzSesgHm/KzJtOeFvWXbf044xqIcQpkSXZeVr3jMATpNRjm0YouB8zb+KXUZ0mFIgLSTEwIBl HxsqcIVgwpHRx X-Received: by 2002:a05:600c:3d1:: with SMTP id z17mr4119294wmd.90.1582882571462; Fri, 28 Feb 2020 01:36:11 -0800 (PST) X-Google-Smtp-Source: APXvYqwMpaEMR5F3/oHm6BUQh6V6cohnmDW6MF7pyQrno3k4L7OwqhL0nlcd2ky/TZgElcMLgwXadw== X-Received: by 2002:a05:600c:3d1:: with SMTP id z17mr4119276wmd.90.1582882571220; Fri, 28 Feb 2020 01:36:11 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:d0d9:ea10:9775:f33f? ([2001:b07:6468:f312:d0d9:ea10:9775:f33f]) by smtp.gmail.com with ESMTPSA id u23sm1371280wmu.14.2020.02.28.01.36.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Feb 2020 01:36:10 -0800 (PST) Subject: Re: [PATCH] KVM: nVMX: allow compiling with W=1 To: =?UTF-8?Q?Valdis_Kl=c4=93tnieks?= , Thomas Gleixner , Ingo Molnar Cc: x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org References: <263441.1582858192@turing-police> From: Paolo Bonzini Message-ID: <96d8eb48-2961-8b85-9687-6bbc27e443a9@redhat.com> Date: Fri, 28 Feb 2020 10:36:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <263441.1582858192@turing-police> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 28/02/20 03:49, Valdis Klētnieks wrote: > Compile error with CONFIG_KVM_INTEL=y and W=1: > > CC arch/x86/kvm/vmx/vmx.o > arch/x86/kvm/vmx/vmx.c:68:32: error: 'vmx_cpu_id' defined but not used [-Werror=unused-const-variable=] > 68 | static const struct x86_cpu_id vmx_cpu_id[] = { > | ^~~~~~~~~~ > cc1: all warnings being treated as errors > > When building with =y, the MODULE_DEVICE_TABLE macro doesn't generate a > reference to the structure (or any code at all). This makes W=1 compiles > unhappy. > > Wrap both in a #ifdef to avoid the issue. > > Signed-off-by: Valdis Kletnieks > > diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c > index 40a1467d1655..5c2fc2177b0d 100644 > --- a/arch/x86/kvm/vmx/vmx.c > +++ b/arch/x86/kvm/vmx/vmx.c > @@ -65,11 +65,13 @@ > MODULE_AUTHOR("Qumranet"); > MODULE_LICENSE("GPL"); > > +#ifdef MODULE > static const struct x86_cpu_id vmx_cpu_id[] = { > X86_FEATURE_MATCH(X86_FEATURE_VMX), > {} > }; > MODULE_DEVICE_TABLE(x86cpu, vmx_cpu_id); > +#endif > > bool __read_mostly enable_vpid = 1; > module_param_named(vpid, enable_vpid, bool, 0444); > Queued, and doing the same for AMD. Paolo