From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4EC878F36 for ; Mon, 14 Apr 2025 10:00:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744624826; cv=none; b=OcqQpJQt+YALIFoQ7QRwKhu5ChezVmcfp3FQTRIyEeLlPeAK6c1i9H/v/COW57EcoYG84SoFY6PkcPRBFMCg9bgNRT1pP9COrw25sneVG8HGhNMZ6heMpfrh4EabXLuEkpxCJEO8ED4yBVdRV3F012u8K1vcLso2IwgXrYhyxtM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744624826; c=relaxed/simple; bh=E2ulgG8qf7wPn46Y2lAa5uVy4QqnKmHl6sR0Ix0GsYI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AINGIB45AMNN3cbIeTbu82aVUHwgdy0UBDA16L5A1KWzeS4Yvo+67WCMAtuUeWnOJXubshKj2/M/QQsl6PNTHvY+ijsb8UuqQPO9+YEXitE1q1qm3pnm+ZNR5kISla1i6fsqKlLSS//PBo5EowJZtlFqIgym/jq/W3z13h1dACk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=QAAzPYpg; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QAAzPYpg" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744624823; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=L4Idrt5jhlWOKQwE/zTHaJzLfRmeFRmEybrkysjcruE=; b=QAAzPYpgUbAhQ1F34Bw7jcEet3aV6TPdLJLNLkbM1+LStdFaWGHTXrRF/0IP05k/FztH/3 QSmsR3voIkVgrNCqkYzbXDpXVTukAGrc+4DsxMyQAb+/5JGTDDoFZIqjCJxoWxmaR9FjSX q2hErEZdeDtYk1PE3gkdJX/Fjcx0jk0= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-606-yYX_1y6qMQKT6NEpO2ZN3w-1; Mon, 14 Apr 2025 06:00:22 -0400 X-MC-Unique: yYX_1y6qMQKT6NEpO2ZN3w-1 X-Mimecast-MFC-AGG-ID: yYX_1y6qMQKT6NEpO2ZN3w_1744624821 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43cf44b66f7so27924125e9.1 for ; Mon, 14 Apr 2025 03:00:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744624821; x=1745229621; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=L4Idrt5jhlWOKQwE/zTHaJzLfRmeFRmEybrkysjcruE=; b=w6hwWU4JSR4aW4iegBZDgcDw4pZrKpWcPwHPZp1tA4iuOFVrjb74UGSVEa9IhqCk9k QwJ4SBznCiGFPK9oKthrwiQ7oyEKYkn7W01rJ/bhMMSKxWrjNAjc5hbUJF83JhxjgWpP /WHR+fqN/5FrLnuLYAMXl/OGFh64SqljYwD1sUopLjO6zum+HG2dG72vgnmb18ZkyV5X VBvhJUD/X507Bt9K4waK5ArvMCoBsnfyJOE1MRsyNwsonE4rPdxCzCRPoIf+cBwKrSrg P4SvqsXjlBkciryN18eKECHYqd8t8M0bJSsLfy3e3COtuNtMkZ5oCrkG9gsIYOunHYtR fL9Q== X-Forwarded-Encrypted: i=1; AJvYcCX2BOaaf0tZnwXBXn/6P++kqTqtQ+q7EWLk82i8HUrKPz9XpI+mz8VmAe6r/pzlk/WJR1o=@vger.kernel.org X-Gm-Message-State: AOJu0YwhI67AJBMNNi03VfEa8M/yvyCLWuoknkOKyKAbEX77oqMcYZ5c b1Wo+Xc6un5QBWa9Xac8FJRy+4MEc8/w8Rb7KSX4CD4vzaeEOjf3fmJUoTIH2MedDQ6RDKDN60e 3LhBhyC2MWMREaLZHVBX7bsw+dzqNkY97aIx8/H5qg9KQO/CZdw== X-Gm-Gg: ASbGncu1uKlX68Z8mknl5fiKeywsD09ooc4NKwa3nUfAqun43YKyPzLME/y84RdfP+z 5JqQUMmk3IqgWp0+l9OfgXxGbfouSdZzHk9b5rDkJo+rTrx3Y76dkZbWD2OO1e0c7mqIrBf0Gl1 y7FJkA0ZOyJ6Z46hbbrkMwBrvU1ezRverZ3qUZNPlr5aNVDS4Mxg2VE3s92hkdANHZX6gCO2uq6 xNfg/qBmM5iloDWea4XYBbriZ9desI1mjdYdjEP+XdTOA+EebvgSyTIc/URnmgVv6x3yOAjWhxH +/toM4X4DM8Q6vV+K3ACdJI2XM0dZIZes0ayBH2rfKO7Sld86nKxNkFsspNa21f18L0hxlzltk0 OlEKzqnz1y785fgTryW6epWqPFRRv5D8f3JC4pQ== X-Received: by 2002:a05:600c:3b10:b0:43c:ec4c:25b1 with SMTP id 5b1f17b1804b1-43f3a9aafafmr81664085e9.23.1744624819887; Mon, 14 Apr 2025 03:00:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGyhYzyPNehTd4v1p4+Sh2300WZZI+TtxBPATJRETBckgmoME/MwenniNO9Zxg98EcULt2d5A== X-Received: by 2002:a05:600c:3b10:b0:43c:ec4c:25b1 with SMTP id 5b1f17b1804b1-43f3a9aafafmr81663625e9.23.1744624819297; Mon, 14 Apr 2025 03:00:19 -0700 (PDT) Received: from ?IPV6:2003:d8:2f02:2900:f54f:bad7:c5f4:9404? (p200300d82f022900f54fbad7c5f49404.dip0.t-ipconnect.de. [2003:d8:2f02:2900:f54f:bad7:c5f4:9404]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39eaf43cc72sm10766875f8f.67.2025.04.14.03.00.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Apr 2025 03:00:18 -0700 (PDT) Message-ID: <96ed1b7e-a4ec-417f-a766-237229231017@redhat.com> Date: Mon, 14 Apr 2025 12:00:15 +0200 Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 1/9] mm: Consolidate freeing of typed folios on final folio_put() To: Fuad Tabba , kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org Cc: pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com References: <20250318161823.4005529-1-tabba@google.com> <20250318161823.4005529-2-tabba@google.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250318161823.4005529-2-tabba@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 18.03.25 17:18, Fuad Tabba wrote: > Some folio types, such as hugetlb, handle freeing their own > folios. Moreover, guest_memfd will require being notified once a > folio's reference count reaches 0 to facilitate shared to private > folio conversion, without the folio actually being freed at that > point. > > As a first step towards that, this patch consolidates freeing > folios that have a type. The first user is hugetlb folios. Later > in this patch series, guest_memfd will become the second user of > this. > > Suggested-by: David Hildenbrand > Acked-by: Vlastimil Babka > Acked-by: David Hildenbrand > Signed-off-by: Fuad Tabba > --- As discussed in the last upstream meeting, we should focus on using the folio_put() hook only for the post-truncate case where required (e.g., re-assemble hugetlb). For shared->private conversion doing it synchronously (unmap, try freezing refcount) and failing if impossible to signal user space to retry is a better first approach. So this patch will be dropped from your series for now, correct? -- Cheers, David / dhildenb