Re: [PATCH 23/29] arm64: KVM: 32bit GP register access

Geoff Levand
2013-03-16T00:24:31Z

Hi Marc,

On Tue, 2013-03-05 at 03:47 +0000, Marc Zyngier wrote:
> diff --git a/arch/arm64/kvm/regmap.c b/arch/arm64/kvm/regmap.c
> new file mode 100644
> index 0000000..f8d4a0c
> --- /dev/null
> +++ b/arch/arm64/kvm/regmap.c

...

> + switch (mode) {
> + case COMPAT_PSR_MODE_USR...COMPAT_PSR_MODE_SVC:

I think it would be safer to have this with spaces in case someone
changes the macro defs or copies this to make some new code and screws
up their defs:

case COMPAT_PSR_MODE_USR ... COMPAT_PSR_MODE_SVC:

See: http://gcc.gnu.org/onlinedocs/gcc-4.1.2/gcc/Case-Ranges.html

-Geoff