Re: [PATCH 1/2] arch/x86: Rename config X86_INTEL_MEMORY_PROTECTION_KEYS to generic x86

Babu Moger
2020-05-07T16:06:18Z

On 5/7/20 10:16 AM, Paolo Bonzini wrote:
> On 07/05/20 16:44, Dave Hansen wrote:
>>> You could add a new option (X86_MEMORY_PROTECTION_KEYS) which is
>>> def_bool X86_INTEL_MEMORY_PROTECTION_KEYS and avoiding the prompt line.
>>> Soo it is selected based on the old option and the user isn't bother. A
>>> few cycles later you could remove intel option and add prompt to other.
>>> But still little work for…
>> That does sound viable, if we decide it's all worth it.
>>
>> So, for now my preference would be to change the prompt, but leave the
>> CONFIG_ naming in place.
>
> I agree.
>
> What's in a name? An Intel rose by any other name would smell as sweet.

How about X86_MPK? Or I will use already proposed name
X86_MEMORY_PROTECTION_KEYS.

> Oh wait... :)
>
> Paolo
>
>> If we decide that transitioning the config is
>> the right thing (I don't feel super strongly either way), let's use
>> Sebastian's trick to avoid the Kconfig prompts.
>>
>