Re: [PATCH 1/2] arch/x86: Rename config X86_INTEL_MEMORY_PROTECTION_KEYS to generic x86

Dave Hansen
2020-05-07T14:44:51Z

On 5/7/20 12:29 AM, Sebastian Andrzej Siewior wrote:
>>> -config X86_INTEL_MEMORY_PROTECTION_KEYS
>>> - prompt "Intel Memory Protection Keys"
>>> +config X86_MEMORY_PROTECTION_KEYS
>>> + prompt "Memory Protection Keys"
>>> def_bool y
>>> # Note: only available in 64-bit mode
>>> - depends on CPU_SUP_INTEL && X86_64
>>> + depends on X86_64 && (CPU_SUP_INTEL || CPU_SUP_AMD)
>>> select ARCH_USES_HIGH_VMA_FLAGS
>>> select ARCH_HAS_PKEYS
>>> ---help---
>> It's a bit of a bummer that we're going to prompt everybody doing
>> oldconfig's for this new option. But, I don't know any way for Kconfig
>> to suppress it if the name is changed. Also, I guess the def_bool=y
>> means that menuconfig and olddefconfig will tend to do the right thing.
> You could add a new option (X86_MEMORY_PROTECTION_KEYS) which is
> def_bool X86_INTEL_MEMORY_PROTECTION_KEYS and avoiding the prompt line.
> Soo it is selected based on the old option and the user isn't bother. A
> few cycles later you could remove intel option and add prompt to other.
> But still little work for…

That does sound viable, if we decide it's all worth it.

So, for now my preference would be to change the prompt, but leave the
CONFIG_ naming in place. If we decide that transitioning the config is
the right thing (I don't feel super strongly either way), let's use
Sebastian's trick to avoid the Kconfig prompts.