public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: "Yang, Weijiang" <weijiang.yang@intel.com>
To: Like Xu <like.xu.linux@gmail.com>
Cc: kvm@vger.kernel.org,
	"Paolo Bonzini - Distinguished Engineer (kernel-recipes.org)
	(KVM HoF)"  <pbonzini@redhat.com>
Subject: Re: [kvm-unit-tests PATCH 3/3] x86: Skip perf related tests when pmu is disabled
Date: Fri, 10 Jun 2022 09:47:14 +0800	[thread overview]
Message-ID: <987d8a3d-19ef-094d-5c0e-007133362c30@intel.com> (raw)
In-Reply-To: <587f8bc5-76fc-6cd7-d3d7-3a712c3f1274@gmail.com>


On 6/10/2022 8:14 AM, Like Xu wrote:
> On 9/6/2022 4:39 pm, Yang Weijiang wrote:
>> executing rdpmc leads to #GP,
>
> RDPMC still works on processors that do not support architectural 
> performance monitoring.
>
> The #GP will violate ISA, and try to treat it as NOP (plus EAX=EDX=0) 
> if !enable_pmu.

After a quick check in SDM, I cannot find wordings supporting your above 
comments, can you

point me to it?

Another concern is, when !enable_pmu, should we make RDPMC "work" with 
returning EAX=EDX=0?

Or just simply inject #GP to VM in this case?


  reply	other threads:[~2022-06-10  1:47 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-09  8:39 [kvm-unit-tests PATCH 0/3] Fix up test failures induced by !enable_pmu Yang Weijiang
2022-06-09  8:39 ` [kvm-unit-tests PATCH 1/3] x86: Remove perf enable bit from default config Yang Weijiang
2022-06-09  8:39 ` [kvm-unit-tests PATCH 2/3] x86: Skip running test when pmu is disabled Yang Weijiang
2022-06-09 23:57   ` Like Xu
2022-06-10  1:40     ` Yang, Weijiang
2022-06-09  8:39 ` [kvm-unit-tests PATCH 3/3] x86: Skip perf related tests " Yang Weijiang
2022-06-10  0:14   ` Like Xu
2022-06-10  1:47     ` Yang, Weijiang [this message]
2022-06-10  2:24       ` Jim Mattson
2022-06-10  2:48         ` Like Xu
2022-06-10  4:16           ` Jim Mattson
2022-06-10  4:22             ` Jim Mattson
2022-06-10  4:56               ` Like Xu
2022-06-10  6:03                 ` Yang, Weijiang
2022-06-10  0:02 ` [kvm-unit-tests PATCH 0/3] Fix up test failures induced by !enable_pmu Like Xu
2022-06-10  6:29   ` Yang, Weijiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=987d8a3d-19ef-094d-5c0e-007133362c30@intel.com \
    --to=weijiang.yang@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=like.xu.linux@gmail.com \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox