From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 3/3] KVM: x86: do not scan IRR twice on APICv vmentry Date: Fri, 14 Oct 2016 09:45:57 +0200 Message-ID: <993cab93-393e-b850-9bb5-db21c98f03e9@redhat.com> References: <1475011213-34225-1-git-send-email-pbonzini@redhat.com> <1475011213-34225-4-git-send-email-pbonzini@redhat.com> <30768946-c4f6-f9bd-5495-2a3adefffc69@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: feng.wu@intel.com, mst@redhat.com, rkrcmar@redhat.com To: Yang Zhang , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Return-path: In-Reply-To: <30768946-c4f6-f9bd-5495-2a3adefffc69@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 14/10/2016 09:32, Yang Zhang wrote: >> >> -void __kvm_apic_update_irr(u32 *pir, void *regs) >> +int __kvm_apic_update_irr(u32 *pir, void *regs) >> { >> - u32 i, pir_val; >> + u32 i, vec; >> + u32 pir_val, irr_val; >> + int max_irr = -1; >> >> - for (i = 0; i <= 7; i++) { >> + for (i = vec = 0; i <= 7; i++, vec += 32) { > > how about ignore the first 32 vectors since they cannot be used as > normal interrupt except nmi interrupt which is special handled. I think that, while they should not be used as normal interrupts, there's nothing that prevents you from misusing them as normal interrupts. Paolo