From: Janis Schoetterl-Glausch <scgl@linux.vnet.ibm.com>
To: Janosch Frank <frankja@linux.ibm.com>, kvm@vger.kernel.org
Cc: linux-s390@vger.kernel.org, imbrenda@linux.ibm.com,
david@redhat.com, thuth@redhat.com, seiden@linux.ibm.com
Subject: Re: [kvm-unit-tests PATCH 2/2] lib: s390x: snippet.h: Add a few constants that will make our life easier
Date: Wed, 13 Oct 2021 15:15:41 +0200 [thread overview]
Message-ID: <9a59c435-f717-784f-48c0-13ff9c3f0251@linux.vnet.ibm.com> (raw)
In-Reply-To: <20211013102722.17160-3-frankja@linux.ibm.com>
On 10/13/21 12:27 PM, Janosch Frank wrote:
> The variable names for the snippet objects are of gigantic length so
> let's define a few macros to make them easier to read.
>
> Also add a standard PSW which should be used to start the snippet.
>
> Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
> ---
> lib/s390x/snippet.h | 40 ++++++++++++++++++++++++++++++++++++++++
> s390x/mvpg-sie.c | 13 ++++++-------
> 2 files changed, 46 insertions(+), 7 deletions(-)
> create mode 100644 lib/s390x/snippet.h
>
> diff --git a/lib/s390x/snippet.h b/lib/s390x/snippet.h
> new file mode 100644
> index 00000000..9ead4fe3
> --- /dev/null
> +++ b/lib/s390x/snippet.h
> @@ -0,0 +1,40 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/*
> + * Snippet definitions
> + *
> + * Copyright IBM, Corp. 2021
^
That comma should not be there.
> + * Author: Janosch Frank <frankja@linux.ibm.com>
> + */
> +
[...]
next prev parent reply other threads:[~2021-10-13 13:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 10:27 [kvm-unit-tests PATCH 0/2] s390x: Cleanup and maintenance 3 Janosch Frank
2021-10-13 10:27 ` [kvm-unit-tests PATCH 1/2] lib: s390x: Fix PSW constant Janosch Frank
2021-10-13 10:32 ` Claudio Imbrenda
2021-10-13 11:17 ` Thomas Huth
2021-10-13 10:27 ` [kvm-unit-tests PATCH 2/2] lib: s390x: snippet.h: Add a few constants that will make our life easier Janosch Frank
2021-10-13 10:35 ` Claudio Imbrenda
2021-10-13 10:38 ` Janosch Frank
2021-10-13 13:15 ` Janis Schoetterl-Glausch [this message]
2021-10-13 13:21 ` Janosch Frank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a59c435-f717-784f-48c0-13ff9c3f0251@linux.vnet.ibm.com \
--to=scgl@linux.vnet.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=seiden@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox