Re: [PATCH 1 of 6] [PATCH] kvm-userspace: ppc: fix compatfd build decision

Christian Ehrhardt
2008-12-15T12:43:44Z

Avi Kivity wrote:
>
>> qemu-kvm.c uses qemu_eventfd/qemu_signalfd. The code of compatfd
>> takes care
>> if CONFIG_eventfd/CONFIG_signalfd is really enabled. But currently
>> compatfd is
>> not build if --disable-aio is set. This patch lets compatfd.c build
>> if USE_KVM
>> is set to allow qemu-kvm to be linked in all cases (with/without
>> --disable-aio)
>>
>
> This breaks x86, so I dropped it.
>
On the other Hand x86 it is broken atm too.
If you compile current upstream for x86 with --disable-aio you'll get
this too:
ibqemu.a(qemu-kvm.o): In function `kvm_main_loop':

/home/paelzer/Desktop/KVM/ppc_port/kvm-userspace-ppc.hg-testbuild/qemu/qemu-kvm.c:565:
undefined reference to `qemu_eventfd'

/home/paelzer/Desktop/KVM/ppc_port/kvm-userspace-ppc.hg-testbuild/qemu/qemu-kvm.c:580:
undefined reference to `qemu_signalfd'
collect2: ld returned 1 exit status

Which was exactly what I had with power :-/

I checked for the error you reported Avi, and the problem seems to be
that USE_KVM was not set even if KVM support is enabled (weird?).
However looking at this more in detail I realized that I don't have to
care about USE_KVM in this csae. As I mentioned before compatfd.c takes
care if CONFIG_signalfd/CONFIG_eventfd are set. Therefore we can savely
remove the makefile guard completely and just always build compatfd.c.

This updated patch works for x86&powerpc with/without --disable-aio in
my tests.
It should appear on the list shortly.

--

Grüsse / regards,
Christian Ehrhardt
IBM Linux Technology Center, Open Virtualization

--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html