Re: [PATCH v2 10/10] s390: Enable KVM_S390_UCONTROL config in debug_defconfig

Christoph Schlameuss
2024-07-23T12:48:12Z

On Tue, 23 Jul 2024 11:40:35 +0200
Christian Borntraeger <borntraeger@linux.ibm.com> wrote:

> Am 23.07.24 um 11:31 schrieb Christoph Schlameuss:
> > To simplify testing enable UCONTROL KVM by default in debug kernels.
> >
> > Signed-off-by: Christoph Schlameuss <schlameuss@linux.ibm.com>
> > ---
> > arch/s390/Kconfig.debug | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/arch/s390/Kconfig.debug b/arch/s390/Kconfig.debug
> > index c4300ea4abf8..4798dded6d76 100644
> > --- a/arch/s390/Kconfig.debug
> > +++ b/arch/s390/Kconfig.debug
> > @@ -20,3 +20,6 @@ config CIO_INJECT
> > This option provides a debugging facility to inject certain artificial events
> > and instruction responses to the CIO layer of Linux kernel. The newly created
> > debugfs user-interfaces will be at /sys/kernel/debug/s390/cio/*
> > +
> > +config KVM_S390_UCONTROL
> > + def_bool y
>
> Isnt that enabling ucontrol for all configs? YOu probably wanted to patch
> arch/s390/configs/debug_defconfig

Yes, I double checked. You are of cause right.
I did verify that is generated into the ".config" with "make
debug_defconfig". But then I missed to check that it does not get added
with "make defconfig".

I will correct that in the next version.

Christoph