Re: [PATCH v2 06/10] selftests: kvm: s390: Add VM run test case

Christoph Schlameuss
2024-07-25T14:07:15Z

On Thu, 25 Jul 2024 14:03:12 +0200
Janosch Frank <frankja@linux.ibm.com> wrote:

> On 7/23/24 11:31, Christoph Schlameuss wrote:
> > Add test case running code interacting with registers within a
> > ucontrol VM.
> >
> > * Add uc_gprs test case
> >
> > The test uses the same VM setup using the fixture and debug macros
> > introduced in earlier patches in this series.
> >
> > Signed-off-by: Christoph Schlameuss <schlameuss@linux.ibm.com>
> > ---
> > .../selftests/kvm/s390x/ucontrol_test.c | 132 ++++++++++++++++++
> > 1 file changed, 132 insertions(+)
> >
> > diff --git a/tools/testing/selftests/kvm/s390x/ucontrol_test.c b/tools/testing/selftests/kvm/s390x/ucontrol_test.c
> > index 527c431a9758..c98d5a3a315b 100644
> > --- a/tools/testing/selftests/kvm/s390x/ucontrol_test.c
> > +++ b/tools/testing/selftests/kvm/s390x/ucontrol_test.c
> > @@ -43,6 +43,23 @@ void require_ucontrol_admin(void)
> > TEST_REQUIRE(kvm_has_cap(KVM_CAP_S390_UCONTROL));
> > }
> >
> > +/* Test program setting some registers and looping */
> > +extern char test_gprs_pgm[];
> > +asm("test_gprs_pgm:\n"
> > + "xgr %r0, %r0\n"
> > + "lgfi %r1,1\n"
> [...]
>
> Naming something PGM for handling anything else than Program Exceptions
> is not recommendable. PGM has been a stable name on s390 for code
> related to PGM exceptions
>
> When first reading this I expected to find some kind of exception code.
>

Ok, I get it now. Previously I was thinking only "test_pgm" was the
hangup. But I do understand now.
I will rename these here and in the other patches to "test_xxx_asm" to
hopefully reduce the confusion.

Christoph