From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C03FC433E0 for ; Fri, 5 Jun 2020 11:17:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EA3C1206FA for ; Fri, 5 Jun 2020 11:17:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QFKhVKO5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726653AbgFELRJ (ORCPT ); Fri, 5 Jun 2020 07:17:09 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:46613 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726612AbgFELRI (ORCPT ); Fri, 5 Jun 2020 07:17:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591355826; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RzGbqSL35ilUIrPGSPIeyg9y7kmtyuP/TetCRHblnU4=; b=QFKhVKO5ukgptcoIovDLEqRxYwIbCoI+SxDkC27XF0vtHZTagQBHHvMVdbpTET/7IUTWyo Fr2rMAWQ7hcBw6PP+6PI7Mg4Gf5Fwh5FLpfld7SmtQ60NDCTq+zmbGDONzfXxxFKMZaMIZ jwgv6zo0sl4Tf4GQlYFMkmNfJtjntvg= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-142-6s3TiV1gMS6PRVmyQVO8WA-1; Fri, 05 Jun 2020 07:17:03 -0400 X-MC-Unique: 6s3TiV1gMS6PRVmyQVO8WA-1 Received: by mail-wm1-f72.google.com with SMTP id 11so2622414wmj.6 for ; Fri, 05 Jun 2020 04:17:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RzGbqSL35ilUIrPGSPIeyg9y7kmtyuP/TetCRHblnU4=; b=WDzKiDGWdeu87IwO4K/YPoMDe3pP0YrjiUbrP0aet7GD4/YpGcAu1wDBtVthGrvRn4 ZgSPYrWs0SUpIewWMfvep+wBbdIECn1GUTWCdNrZYlj4jv++emYnJNyd4XOG0mEUwNBm ZirVfkW8+KeA2w0dPyRNStopsP/8TFolwKdzmL6UgfaZphOTPNA5c7biYQe5BrPba0eG 8spox3MLpPHrma9IDayvzpd+GUvfx6VS/FN57r/i77v1BBMzu76Uk3rFc8BQjdKuQXqV POLNuOtpp157CdRW5qS4Y8I4KhHD9b/pSBRL9KMtL0tWquyRovxwHCL1wjsdr/DZ5yQI vSsw== X-Gm-Message-State: AOAM530+25yK8Jma/+td6sohWYVe6eJB2OyK5dmaZ/X4+hbEtw10t9de VgYfOMaVICrfnxe9LKKpLeFi4chQsJOjstxBvotS+vKKvd1Y8KznoCa3FU8KnZbjZMZZWvg7Q4M wuPHWYr6o5ZT1 X-Received: by 2002:a5d:684a:: with SMTP id o10mr8428651wrw.4.1591355822346; Fri, 05 Jun 2020 04:17:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwoWCY4kIj3NwURBaGZZ95zPlotZFEwtkK4J/GiE+YPjhOoebb8RUzODqnboUSiNMmXSnQIpA== X-Received: by 2002:a5d:684a:: with SMTP id o10mr8428638wrw.4.1591355822101; Fri, 05 Jun 2020 04:17:02 -0700 (PDT) Received: from [192.168.178.58] ([151.20.243.176]) by smtp.gmail.com with ESMTPSA id 30sm11840903wrd.47.2020.06.05.04.17.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Jun 2020 04:17:01 -0700 (PDT) Subject: Re: [PATCH] KVM: selftests: delete some dead code To: Dan Carpenter , Ben Gardon Cc: Shuah Khan , Peter Xu , kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20200605110048.GB978434@mwanda> From: Paolo Bonzini Message-ID: <9f20e25d-599d-c203-e3d4-905b122ef5a3@redhat.com> Date: Fri, 5 Jun 2020 13:16:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200605110048.GB978434@mwanda> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On 05/06/20 13:00, Dan Carpenter wrote: > The "uffd_delay" variable is unsigned so it's always going to be >= 0. > > Fixes: 0119cb365c93 ("KVM: selftests: Add configurable demand paging delay") > Signed-off-by: Dan Carpenter > --- > tools/testing/selftests/kvm/demand_paging_test.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/tools/testing/selftests/kvm/demand_paging_test.c b/tools/testing/selftests/kvm/demand_paging_test.c > index 360cd3ea4cd67..4eb79621434e6 100644 > --- a/tools/testing/selftests/kvm/demand_paging_test.c > +++ b/tools/testing/selftests/kvm/demand_paging_test.c > @@ -615,8 +615,6 @@ int main(int argc, char *argv[]) > break; > case 'd': > uffd_delay = strtoul(optarg, NULL, 0); > - TEST_ASSERT(uffd_delay >= 0, > - "A negative UFFD delay is not supported."); > break; > case 'b': > vcpu_memory_bytes = parse_size(optarg); > The bug is that strtoul is "impossible" to use correctly. The right fix would be to have a replacement for strtoul. Paolo