From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82A5EC10F0E for ; Mon, 15 Apr 2019 23:04:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 466AD206B6 for ; Mon, 15 Apr 2019 23:04:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="I0dEchvA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727911AbfDOXEP (ORCPT ); Mon, 15 Apr 2019 19:04:15 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:39304 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726593AbfDOXEP (ORCPT ); Mon, 15 Apr 2019 19:04:15 -0400 Received: by mail-pf1-f193.google.com with SMTP id i17so9365919pfo.6 for ; Mon, 15 Apr 2019 16:04:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=8OhQXbOh8YSpDhZqGfzl6ZMGNVmFZsMHs5WtDbaSN4M=; b=I0dEchvAmpovWkwKWYlmGWE2L192F/3P9tsl2WfR0Ou4IWdMlJ/4RUIwwZOD5g61Nk LcpqiO8F1kq8tMuzb3Xd/71eh9HO6Q50L/UbehE6q6WE7JJB55zz9NpVv/VMt9YydaEz Y3aNMRxOqKGx6EnuJsi18vjk0XIy3SFpCmfbvOIPZLPS46T6kaWrxbT084F/dv6rX8jE 66n34Biv4pr/Xo/4luWSEQsFouBDikTpo51OT2FEs3a79wzn1AoEn9wgOy7A0kLPYOb0 2PMoilcRfIPNU71UfjSOaNXW7wHLEg8w+nRbRq89GBfQRi7k+h3WuhP/D4faQC+3yeA1 PXHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=8OhQXbOh8YSpDhZqGfzl6ZMGNVmFZsMHs5WtDbaSN4M=; b=X6FnlT/X6rcMHLeRwhb/XrTYl8y+dt/mPmYl4v0WGgGYoWjR4W8GlpVA//jb0O8RCJ 4NJ2ZTJen5RIHEv7LW8ln3m5oMJmCJBqs9GPEYJCqsK9sxDSkEjht4d8smL5Wuwx+/zU qxP8h31WC9xjObIyV0i3FzSm5SFN+REvWt7j7HcOf+RDrucbUPxw33Tgk6kNMSUoD/dI VbzIy0VqXo65v6r/ZhHIfVUoMkrji9I21rMwjtSbZlgyEgR/qIWdXprAr2g1Gilam4Sm hgbNIlcpoFR499ndfQ5gEz7SbrWs3x0aaCLajzToEM4V9ObDj5+tu/kgfhnhIHeEUrtB BU5A== X-Gm-Message-State: APjAAAX5KEMMNH8oKO2vtuJa+MrpFoxTAvtiSvMTw3VFkNulDV6UN7UX zxFVAFW44Id2x2nl33/WrgE= X-Google-Smtp-Source: APXvYqyLgV4ovhtB9EbXDkijupTxtlPcF7WgsOKQxp7aFIEIxnLs4FlhMxrNj1ncrFsEYLMOpbjIJg== X-Received: by 2002:a65:6655:: with SMTP id z21mr37260492pgv.33.1555369454309; Mon, 15 Apr 2019 16:04:14 -0700 (PDT) Received: from [10.2.189.129] ([66.170.99.2]) by smtp.gmail.com with ESMTPSA id r87sm111508958pfa.71.2019.04.15.16.04.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Apr 2019 16:04:12 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: Re: [PATCH] x86: Wait for self IPI From: Nadav Amit In-Reply-To: <20190415230327.23949-1-nadav.amit@gmail.com> Date: Mon, 15 Apr 2019 16:04:11 -0700 Cc: kvm@vger.kernel.org, Sean Christopherson Content-Transfer-Encoding: quoted-printable Message-Id: References: <20190415230327.23949-1-nadav.amit@gmail.com> To: Paolo Bonzini X-Mailer: Apple Mail (2.3445.102.3) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org > On Apr 15, 2019, at 4:03 PM, nadav.amit@gmail.com wrote: >=20 > From: Nadav Amit >=20 > There is no architectural requirement that self-IPI would be received = on > the next instruction after it is generated. Make the test more robust = by > not requiring it, and instead wait for some time or until it is > received. >=20 > Signed-off-by: Nadav Amit > --- > x86/apic.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) >=20 > diff --git a/x86/apic.c b/x86/apic.c > index 0849f87..de5990c 100644 > --- a/x86/apic.c > +++ b/x86/apic.c > @@ -255,13 +255,18 @@ static void self_ipi_isr(isr_regs_t *regs) >=20 > static void test_self_ipi(void) > { > + u64 start =3D rdtsc(); > int vec =3D 0xf1; >=20 > handle_irq(vec, self_ipi_isr); > irq_enable(); > apic_icr_write(APIC_DEST_SELF | APIC_DEST_PHYSICAL | APIC_DM_FIXED = | vec, > 0); > - asm volatile ("nop"); > + > + do { > + pause(); > + } while (rdtsc() - start < 1000000000 && ipi_count =3D=3D 0); > + > report("self ipi", ipi_count =3D=3D 1); > } >=20 > --=20 > 2.17.1 This is of course a KVM-unit-tests patch.