From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Menage Subject: Re: [PATCH 1/3] cgroups: Add an API to attach a task to current task's cgroup Date: Tue, 25 May 2010 11:34:12 -0700 Message-ID: References: <1274227488.2370.107.camel@w-sridhar.beaverton.ibm.com> <20100525165334.GA27307@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Cc: Sridhar Samudrala , netdev , "kvm@vger.kernel.org" , lkml , containers@lists.linux-foundation.org, lizf@cn.fujitsu.com To: "Michael S. Tsirkin" Return-path: Received: from smtp-out.google.com ([74.125.121.35]:27088 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932530Ab0EYSeR (ORCPT ); Tue, 25 May 2010 14:34:17 -0400 In-Reply-To: <20100525165334.GA27307@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, May 25, 2010 at 9:53 AM, Michael S. Tsirkin wrote: > On Thu, May 20, 2010 at 03:22:15PM -0700, Paul Menage wrote: >> On Tue, May 18, 2010 at 5:04 PM, Sridhar Samudrala >> wrote: >> > Add a new kernel API to attach a task to current task's cgroup >> > in all the active hierarchies. >> > >> > Signed-off-by: Sridhar Samudrala >> >> Reviewed-by: Paul Menage >> >> It would be more efficient to just attach directly to current->cgroups >> rather than potentially creating/destroying one css_set for each >> hierarchy until we've completely converged on current->cgroups - but >> that would require a bunch of refactoring of the guts of >> cgroup_attach_task() to ensure that the right can_attach()/attach() >> callbacks are made. That doesn't really seem worthwhile right now for >> the initial use, that I imagine isn't going to be >> performance-sensitive. >> >> Paul > > Is this patch suitable for 2.6.35? Should be OK, yes. Paul