From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ruben Kerkhof Subject: Re: system_powerdown not working for qemu-kvm 0.12.4? Date: Fri, 15 Oct 2010 03:45:06 +0200 Message-ID: References: <4BEFDC8D.70007@redhat.com> <4BF41051.2010608@redhat.com> <4C67C8D2.5000400@redhat.com> <4CB341E4.3060400@redhat.com> <4CB40515.2030809@redhat.com> <20101012071124.GA10190@morn.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Avi Kivity , Teck Choon Giam , kvm@vger.kernel.org, Gleb Natapov , seabios@seabios.org To: "Kevin O'Connor" Return-path: Received: from mail-qw0-f46.google.com ([209.85.216.46]:63422 "EHLO mail-qw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754157Ab0JOBp1 convert rfc822-to-8bit (ORCPT ); Thu, 14 Oct 2010 21:45:27 -0400 Received: by qwa26 with SMTP id 26so122951qwa.19 for ; Thu, 14 Oct 2010 18:45:26 -0700 (PDT) In-Reply-To: <20101012071124.GA10190@morn.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: Hi Kevin, On Tue, Oct 12, 2010 at 09:11, Kevin O'Connor wrot= e: > On Tue, Oct 12, 2010 at 08:49:58AM +0200, Avi Kivity wrote: >> =C2=A0On 10/11/2010 07:53 PM, Ruben Kerkhof wrote: >> >5c99b6c984682ddb1d4543a7e27a1f4ca633e6a6 is the first bad commit >> >commit 5c99b6c984682ddb1d4543a7e27a1f4ca633e6a6 >> >Author: Kevin O'Connor >> Gleb, Kevin, any ideas? >> >> (summary: qemu-kvm doesn't acpi shutdown freebsd 8.1 with this >> commit; qemu.git does. =C2=A0May be due to interrupt polarity which = kvm >> implements but qemu does not) > > The only thing in commit 5c99b6c9 that could cause an issue is that i= t > has the compiled acpi changes actually made in commit 29f4b912, but I > don't see how that would be a problem to reboots: > > diff --git a/src/acpi-dsdt.dsl b/src/acpi-dsdt.dsl > index cee038a..2bede25 100644 > --- a/src/acpi-dsdt.dsl > +++ b/src/acpi-dsdt.dsl > @@ -58,7 +58,10 @@ DefinitionBlock ( > =C2=A0#define prt_slot2(nr) prt_slot(nr, LNKB, LNKC, LNKD, LNKA) > =C2=A0#define prt_slot3(nr) prt_slot(nr, LNKC, LNKD, LNKA, LNKB) > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0prt_slot0(0x00= 00), > - =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 prt_slot1(0x0001), > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Package() { 0x0001= ffff, 0, 0, 9 }, > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Package() { 0x0001= ffff, 1, LNKB, 0 }, > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Package() { 0x0001= ffff, 2, LNKC, 0 }, > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 Package() { 0x0001= ffff, 3, LNKD, 0 }, > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0prt_slot2(0x00= 02), > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0prt_slot3(0x00= 03), > =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0prt_slot0(0x00= 04), > > Can you confirm that commit 4c94b7ea works reliably while commit > 5c99b6c9 does not? > > -Kevin > Yes, that's correct. Is there anything I can do to help resolve this? Would rolling back this commit have any impact on other operating syste= ms? Regards, Ruben