From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pekka Enberg <penberg@kernel.org>
Subject: Is KVM_GET_SREGS safe from other threads?
Date: Sun, 8 May 2011 11:24:24 +0300
Message-ID: <BANLkTikB0NmgSzOV5YO-+Qm2fh1MFw6utw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
To: KVM General <kvm@vger.kernel.org>, Avi Kivity <avi@redhat.com>,
	Ingo Molnar <mingo@elte.hu>,
	Cyrill Gorcunov <gorcunov@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-vx0-f174.google.com ([209.85.220.174]:51652 "EHLO
	mail-vx0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752126Ab1EHIYZ (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 8 May 2011 04:24:25 -0400
Received: by vxi39 with SMTP id 39so4774075vxi.19
        for <kvm@vger.kernel.org>; Sun, 08 May 2011 01:24:24 -0700 (PDT)
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Hi!

We've noticed that sometimes KVM_GET_SREGS from a signal handler
hangs. We use it like this:

static void handle_sigquit(int sig)
{
         int i;

         for (i = 0; i < nrcpus; i++) {
                 struct kvm_cpu *cpu = kvm_cpus[i];

                 kvm_cpu__show_registers(cpu); <-- here
                 kvm_cpu__show_code(cpu);
                 kvm_cpu__show_page_tables(cpu);
         }

and

void kvm_cpu__show_registers(struct kvm_cpu *self)
{
[...]
	if (ioctl(self->vcpu_fd, KVM_GET_SREGS, &sregs) < 0)
		die("KVM_GET_REGS failed");

is it not OK to call KVM_GET_SREGS from other threads than the one
that's doing KVM_RUN?

                        Pekka