Kernel KVM virtualization development
 help / color / mirror / Atom feed
From: Alexander Graf <agraf-l3A5Bk7waGM@public.gmane.org>
To: Andreas Schwab <schwab-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
Cc: Paul Mackerras <paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>,
	kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org,
	kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] KVM: PPC: elide struct thread_struct instances from stack
Date: Tue, 1 Jun 2010 11:19:17 +0200	[thread overview]
Message-ID: <C9ECD11F-CF09-4C56-A028-3625266E2807@suse.de> (raw)
In-Reply-To: <m3r5krrvy2.fsf-YqIcNwjZo96zQB+pC5nmwQ@public.gmane.org>


On 01.06.2010, at 10:36, Andreas Schwab wrote:

> Paul Mackerras <paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org> writes:
> 
>> I re-read the relevant part of the PowerPC architecture spec
>> yesterday, and it seems pretty clear that the FPSCR doesn't affect the
>> behaviour of lfs and stfs, and is not affected by them.  So in fact 4
>> out of the 7 instructions in each of those procedures are unnecessary
>> (and similarly for the cvt_fd/df used in the alignment fixup code).
> 
> I'd prefer to have this deferred to a separate patch.

I agree. Andreas' patch takes the current logic and moves it to be KVM contained, so we don't clutter the stack. The fact that the old code was inefficient is a separate story.

Avi / Marcelo, please apply the patch nevertheless.


Alex

  parent reply	other threads:[~2010-06-01  9:19 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-31 19:59 [PATCH] KVM: PPC: elide struct thread_struct instances from stack Andreas Schwab
     [not found] ` <m26323onam.fsf-hBGjKatGTSWzQB+pC5nmwQ@public.gmane.org>
2010-05-31 20:00   ` Alexander Graf
2010-05-31 22:40   ` Paul Mackerras
2010-05-31 23:27     ` Alexander Graf
     [not found]     ` <20100531224040.GA22927-oklZEfemRj05kJ7NmlRacFaTQe2KTcn/@public.gmane.org>
2010-06-01  8:36       ` Andreas Schwab
     [not found]         ` <m3r5krrvy2.fsf-YqIcNwjZo96zQB+pC5nmwQ@public.gmane.org>
2010-06-01  9:19           ` Alexander Graf [this message]
2010-06-02 16:00 ` Marcelo Tosatti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C9ECD11F-CF09-4C56-A028-3625266E2807@suse.de \
    --to=agraf-l3a5bk7wagm@public.gmane.org \
    --cc=kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linuxppc-dev-mnsaURCQ41sdnm+yROfE0A@public.gmane.org \
    --cc=paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org \
    --cc=schwab-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox