From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f169.google.com (mail-il1-f169.google.com [209.85.166.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9906B21B9E0 for ; Thu, 17 Jul 2025 16:04:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752768292; cv=none; b=EmUBiB4QqZApyYtvccGjcHXnA5RjR8UK8iglnI4TeiuyuTC/C/JlUTmupFP+FvyEsqsy/I8gynnbhbbfU5nmvCuR5DU6y+dPBugN+zNNNkmICDMin739CV8/0mQbidp8WrkMwRz0OZQve+2IQO6J2NJ4fHUNxYkmT2DqMS5QXHg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752768292; c=relaxed/simple; bh=WOIwx1hKJu8v/kYP52CvuHubvCiOsRZtEEd0Wy1EfwM=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=Azhch1sbSJPYscx4l7zIYxVVko9+TqKsDuay3XxcSQlkwtgk2Fa1firzXA4+JJPmpf72kzDLe92I/qrfPvZvzfEDlBvNhUoF4ji69ESdo4o9vP1s8E50SOMXuwpzLtizIHrdf1TgXg0gbW5qamHnHj4pcIMafFGlkgesI4VKkSQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=brainfault.org; spf=none smtp.mailfrom=brainfault.org; dkim=pass (2048-bit key) header.d=brainfault-org.20230601.gappssmtp.com header.i=@brainfault-org.20230601.gappssmtp.com header.b=TWRmZN1w; arc=none smtp.client-ip=209.85.166.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=brainfault.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=brainfault.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=brainfault-org.20230601.gappssmtp.com header.i=@brainfault-org.20230601.gappssmtp.com header.b="TWRmZN1w" Received: by mail-il1-f169.google.com with SMTP id e9e14a558f8ab-3e058c64a76so4335745ab.0 for ; Thu, 17 Jul 2025 09:04:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brainfault-org.20230601.gappssmtp.com; s=20230601; t=1752768289; x=1753373089; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=mF4ZzdU4KPm05DxQhuE3nJR3OBuoI7+D+aCP85HQkvI=; b=TWRmZN1wWlexMhEcohtauG5rpKX28sYpyn5N01Vva0I044tb2UwJ9JA4CGVv5QULKb S9cHd+2NbjYOD8NXk2PS6ZPNz4pwGSODsv8w2v/Qh+lacq2FkAlcEMWl7bnxxOTBj7Ab EJa3RGIfP9jzTjgDtpGJPZ12/HS1WTEiUgPHCxwgvZCTmpaR/RpVpv6j9jlf94dzIYDi fiicQdXzDFKFJFQPeg2BuLOUgD3DfcU6QR4V9CKHnpk3Cz0mRW+Xa/SSSh+h54JAN8eK v7CJPRQSbywIImj8QiBzsGMtkc7LlV6OVKgS86edw4lRpMj1LW3MKWtXsvVFLxCLBBe0 W0Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752768289; x=1753373089; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mF4ZzdU4KPm05DxQhuE3nJR3OBuoI7+D+aCP85HQkvI=; b=DKbhZDi4fshbWyrIhIB/nnI3KF2UxIJEpkGHp9/nUQfLdQ+hsa/SCKdLmixX7Bvqt1 bgswLIfyh6hK6lH2vlSPQdMXdXF1Hh6yVyUhx/by/DRmbmbtIyg61FtBXfHQ3JY2aDtu MNCs48NHirX45lo5F7wcAVN5AfNiCjyrWery4Rpe3gHPWuEEsoQD+YuAYXr0wlnF2GSu xu0g9GkDP3q8pz3dr8oI2IIAVJX9rDpeF1GdhmPtJRFeArwltZ2/rimxjrugJqtz0H46 oq9xFe5R9bcbKB3H+x4KAnhY1ax528eXos4kPYdHXXL8YfY5xZbwD2aQIbr+h0Mwc/fS +Bwg== X-Forwarded-Encrypted: i=1; AJvYcCUNaH0LJCMiLQuqLCdgQ8zZezudR1tG8T4OQS4botnAYDPyvoONpuvbqDimeBodNdWMHjg=@vger.kernel.org X-Gm-Message-State: AOJu0YyH/RgmKtU9nlTzOvS2rGdvmLsJmIOq8N6cTl19KCWrary7Usmw 4pSX7hemah047HnwOu8pvDf60n49Ke0Ky24Ae2kH35+JsGlT9aE9pagenNo7IAdKInFxqQKNDw4 ndtf2UNkSeHMDRfG1gTG8JC6vnxl6+a2p3xPKMhgmRw== X-Gm-Gg: ASbGncv4zTpQlw46AV7NPo1OOw4tp7MyU+FjpfrLUAhHCAAoPHryp7K3zMuQwnOJssW n3lYXFC6as45QIx/Bl5Snd1UFL/yF4w1HxX1KRgwiIuOIvwSV3yfbcvkAHtxrqANJFrPTCgETRH MAhxBtQWkdOEsFUOPhzsl14biTVfm2b9mDsOUw09TaCZdIRf+RMzTSmMJ9tCWLbPDxeqD8K1DRl EbOOWflfjQ4jIQCXsY= X-Google-Smtp-Source: AGHT+IFAG3wYGrY4xyVVSnggyKQ8Fmk+ZxX7eQXMdYOvL6ZpVVrOgjCMEp0iGPnFH5D2j6kt83DD42IjPEeujKO5F/Q= X-Received: by 2002:a05:6e02:3e07:b0:3df:3598:7688 with SMTP id e9e14a558f8ab-3e28307abacmr89850255ab.21.1752768287054; Thu, 17 Jul 2025 09:04:47 -0700 (PDT) Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20250522-pmu_event_info-v3-0-f7bba7fd9cfe@rivosinc.com> <20250522-pmu_event_info-v3-6-f7bba7fd9cfe@rivosinc.com> In-Reply-To: <20250522-pmu_event_info-v3-6-f7bba7fd9cfe@rivosinc.com> From: Anup Patel Date: Thu, 17 Jul 2025 21:34:36 +0530 X-Gm-Features: Ac12FXxSVTcSMonhmD8rqZBxMoPIHtsKSpNyakGFXvSyptDFl2Kq_s4PkOsoVXE Message-ID: Subject: Re: [PATCH v3 6/9] KVM: Add a helper function to validate vcpu gpa range To: Atish Patra Cc: Will Deacon , Mark Rutland , Paul Walmsley , Palmer Dabbelt , Mayuresh Chitale , linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Palmer Dabbelt , kvm@vger.kernel.org, kvm-riscv@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, May 23, 2025 at 12:33=E2=80=AFAM Atish Patra = wrote: > > The arch specific code may need to validate a gpa range if it is a shared > memory between the host and the guest. Currently, there are few places > where it is used in RISC-V implementation. Given the nature of the functi= on > it may be used for other architectures. Hence, a common helper function > is added. > > Signed-off-by: Atish Patra > --- > include/linux/kvm_host.h | 2 ++ > virt/kvm/kvm_main.c | 21 +++++++++++++++++++++ > 2 files changed, 23 insertions(+) > > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > index 291d49b9bf05..adda61cc4072 100644 > --- a/include/linux/kvm_host.h > +++ b/include/linux/kvm_host.h > @@ -1383,6 +1383,8 @@ static inline int kvm_vcpu_map_readonly(struct kvm_= vcpu *vcpu, gpa_t gpa, > > unsigned long kvm_vcpu_gfn_to_hva(struct kvm_vcpu *vcpu, gfn_t gfn); > unsigned long kvm_vcpu_gfn_to_hva_prot(struct kvm_vcpu *vcpu, gfn_t gfn,= bool *writable); > +int kvm_vcpu_validate_gpa_range(struct kvm_vcpu *vcpu, gpa_t gpa, unsign= ed long len, > + bool write_access); > int kvm_vcpu_read_guest_page(struct kvm_vcpu *vcpu, gfn_t gfn, void *dat= a, int offset, > int len); > int kvm_vcpu_read_guest_atomic(struct kvm_vcpu *vcpu, gpa_t gpa, void *d= ata, > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index e85b33a92624..3f52f5571fa6 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -3301,6 +3301,27 @@ int kvm_vcpu_write_guest(struct kvm_vcpu *vcpu, gp= a_t gpa, const void *data, > } > EXPORT_SYMBOL_GPL(kvm_vcpu_write_guest); > > +int kvm_vcpu_validate_gpa_range(struct kvm_vcpu *vcpu, gpa_t gpa, unsign= ed long len, > + bool write_access) > +{ > + gfn_t gfn =3D gpa >> PAGE_SHIFT; > + int seg; > + int offset =3D offset_in_page(gpa); > + bool writable =3D false; > + unsigned long hva; Nit: rearrange the variables in a inverted pyramid shape. > + > + while ((seg =3D next_segment(len, offset)) !=3D 0) { > + hva =3D kvm_vcpu_gfn_to_hva_prot(vcpu, gfn, &writable); > + if (kvm_is_error_hva(hva) || (writable ^ write_access)) > + return -EPERM; > + offset =3D 0; > + len -=3D seg; > + ++gfn; > + } > + return 0; > +} > +EXPORT_SYMBOL_GPL(kvm_vcpu_validate_gpa_range); > + > static int __kvm_gfn_to_hva_cache_init(struct kvm_memslots *slots, > struct gfn_to_hva_cache *ghc, > gpa_t gpa, unsigned long len) > > -- > 2.43.0 > Otherwise, looks good to me. Reviewed-by: Anup Patel Regards, Anup