From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Db909ZoJ" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0637112C for ; Tue, 21 Nov 2023 09:01:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700586072; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v93FwVXoTzkwCTHloTDbAyzgq12DcyzYpNvU8V0mZJE=; b=Db909ZoJYbcT2G6LLjfnci8yQDj6GeiSOnWmAa8m+VFijTu30q9djImk6aFIkpMgVdtS+Z c236IoYSFo0aEGPv7aYu++U66M0qv/B5ysNWiKeSjLp9LM0SBhlioFeP1Qc6bg1nFu6Qit IQjR/wgf7I/405DltkwXG0Kbe5KyMSs= Received: from mail-ot1-f70.google.com (mail-ot1-f70.google.com [209.85.210.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-497-Nb6h2uXDM4q_xBUfUAJC_A-1; Tue, 21 Nov 2023 12:01:09 -0500 X-MC-Unique: Nb6h2uXDM4q_xBUfUAJC_A-1 Received: by mail-ot1-f70.google.com with SMTP id 46e09a7af769-6d656fd896dso6402483a34.3 for ; Tue, 21 Nov 2023 09:01:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700586069; x=1701190869; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v93FwVXoTzkwCTHloTDbAyzgq12DcyzYpNvU8V0mZJE=; b=f/lKyoZAuDkAM6zH67OO7/4z4txyEY6uWYsx6n+xs/xkwjKEWFeZeNZRgpGdjD0qqM tg+vYhOXM1Y7f3ONnji80oUBHP8NvBso48Vhuk9YqBOPRTPuRSgrxghGPkzsFvAC1IrU 1TlTxQC9HZhZdET3fJZNvx4JbfVDqH+d/ronW4qsnQnTvdGCX5jBF0oa4z7kj7Z0c/TA irJScnTSuOzN+emq9/ZleeXBj0XMsFJKuaGMBYUbONx2h+MkHT5mY/bWJibR7rh9SlSX 3dZLb7fhaXsNFVeEa2hVVYRluDMKFWjSXa1woIDcQYVBCMem2zVFceIcYhhdaof62SE8 Crzw== X-Gm-Message-State: AOJu0YzqNJtUVv5fXz5r83LCkwGVkkhUaOJEJg1XdAWGh4kM8/9XSYQw 9AYglkPBELwrTb8YtSBeZL+rP9gyarUORm0igTkZCNgLXqLqekM0+xwr49j+GyJrWBtQ7lmuByC 6awOZEuU/zO3rQua5mIznkdHKutKU X-Received: by 2002:a05:6358:7e47:b0:169:a9d4:3faf with SMTP id p7-20020a0563587e4700b00169a9d43fafmr12581510rwm.11.1700586069072; Tue, 21 Nov 2023 09:01:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IHzwqwXTcQOMVq6+W/ToO1AFQnqdGCzNKV3DK3CezCKFyIOZTTVBddsfYxnVHAme/q2N84DW6rxhPtI5xPi31c= X-Received: by 2002:a05:6358:7e47:b0:169:a9d4:3faf with SMTP id p7-20020a0563587e4700b00169a9d43fafmr12581454rwm.11.1700586068588; Tue, 21 Nov 2023 09:01:08 -0800 (PST) Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20231105163040.14904-1-pbonzini@redhat.com> <20231105163040.14904-35-pbonzini@redhat.com> <13677ced-e464-4cdb-82ae-4236536e169c@sirena.org.uk> In-Reply-To: <13677ced-e464-4cdb-82ae-4236536e169c@sirena.org.uk> From: Paolo Bonzini Date: Tue, 21 Nov 2023 18:00:56 +0100 Message-ID: Subject: Re: [PATCH 34/34] KVM: selftests: Add a memory region subtest to validate invalid flags To: Mark Brown Cc: Anish Moorthy , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Sean Christopherson , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaoyao Li , Xu Yilun , Chao Peng , Fuad Tabba , Jarkko Sakkinen , David Matlack , Yu Zhang , Isaku Yamahata , =?UTF-8?B?TWlja2HDq2wgU2FsYcO8bg==?= , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A. Shutemov" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Nov 20, 2023 at 3:09=E2=80=AFPM Mark Brown wro= te: > > On Wed, Nov 08, 2023 at 05:08:01PM -0800, Anish Moorthy wrote: > > Applying [1] and [2] reveals that this also breaks non-x86 builds- the > > MEM_REGION_GPA/SLOT definitions are guarded behind an #ifdef > > __x86_64__, while the usages introduced here aren't. > > > > Should > > > > On Sun, Nov 5, 2023 at 8:35=E2=80=AFAM Paolo Bonzini wrote: > > > > > > + test_invalid_memory_region_flags(); > > > > be #ifdef'd, perhaps? I'm not quite sure what the intent is. > > This has been broken in -next for a week now, do we have any progress > on a fix or should we just revert the patch? Sorry, I was away last week. I have now posted a patch. Paolo