kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Xiaoyao Li <xiaoyao.li@intel.com>
Cc: "Kernel Mailing List, Linux" <linux-kernel@vger.kernel.org>,
	kvm <kvm@vger.kernel.org>,
	 Sean Christopherson <seanjc@google.com>,
	Rick Edgecombe <rick.p.edgecombe@intel.com>,
	 "Huang, Kai" <kai.huang@intel.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	reinette.chatre@intel.com,  "Lindgren,
	Tony" <tony.lindgren@intel.com>,
	"Yamahata, Isaku" <isaku.yamahata@intel.com>,
	 Yan Zhao <yan.y.zhao@intel.com>,
	mikko.ylinen@linux.intel.com,  "Shutemov,
	Kirill" <kirill.shutemov@intel.com>,
	"Yao, Jiewen" <jiewen.yao@intel.com>,
	 Binbin Wu <binbin.wu@linux.intel.com>
Subject: Re: [PATCH v2 0/3] TDX attestation support and GHCI fixup
Date: Fri, 20 Jun 2025 19:24:05 +0200	[thread overview]
Message-ID: <CABgObfadU2_XLM8yGQrx9rDswfW3Dby10_nxzTBUdYGASQuOaw@mail.gmail.com> (raw)
In-Reply-To: <b003b2c8-66fc-4600-9873-aa5201415b94@intel.com>

On Fri, Jun 20, 2025 at 2:48 PM Xiaoyao Li <xiaoyao.li@intel.com> wrote:
> > The interface I chose is that KVM always exits, but it initializes the
> > output values such that userspace can leave them untouched for unknown
> > TDVMCALLs or unknown leaves. So there is no need for this.
> >
> > Querying kernel support of other services can be added later, but
> > unless the GHCI adds more input or output fields to TdVmCallInfo there
> > is no need to limit the userspace exit to leaf 1.
>
> I meant the case where KVM is going to support another optional TDVMCALL
> leaf in the future, e.g., SetEventNotifyInterrupt. At that time,
> userspace needs to differentiate between old KVM which only supports
> <GetQuote> and new KVM which supports both <GetQuote> and
> <SetEventNotifyInterrupt>.

Yeah, I see what you mean now. Userspace cannot know which TDVMCALL
will exit, other than GET_QUOTE which we know is in the first part.

By the way I'm tempted to implement SetupEventNotifyInterrupt as well,
it's just a handful of lines of code.

Paolo


  reply	other threads:[~2025-06-20 17:24 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-19 18:01 [PATCH v2 0/3] TDX attestation support and GHCI fixup Paolo Bonzini
2025-06-19 18:01 ` [PATCH 1/3] KVM: TDX: Add new TDVMCALL status code for unsupported subfuncs Paolo Bonzini
2025-06-23 22:42   ` Huang, Kai
2025-06-19 18:01 ` [PATCH 2/3] KVM: TDX: Handle TDG.VP.VMCALL<GetQuote> Paolo Bonzini
2025-06-20  2:57   ` Binbin Wu
2025-06-20  3:05     ` Binbin Wu
2025-06-19 18:01 ` [PATCH 3/3] KVM: TDX: Exit to userspace for GetTdVmCallInfo Paolo Bonzini
2025-06-20  1:20   ` Xiaoyao Li
2025-06-20 12:03     ` Paolo Bonzini
2025-06-20 12:34       ` Xiaoyao Li
2025-06-20  1:30 ` [PATCH v2 0/3] TDX attestation support and GHCI fixup Xiaoyao Li
2025-06-20  2:10   ` Binbin Wu
2025-06-20 12:03   ` Paolo Bonzini
2025-06-20 12:48     ` Xiaoyao Li
2025-06-20 17:24       ` Paolo Bonzini [this message]
2025-06-20 17:47         ` Edgecombe, Rick P
2025-06-20  7:09 ` Binbin Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABgObfadU2_XLM8yGQrx9rDswfW3Dby10_nxzTBUdYGASQuOaw@mail.gmail.com \
    --to=pbonzini@redhat.com \
    --cc=adrian.hunter@intel.com \
    --cc=binbin.wu@linux.intel.com \
    --cc=isaku.yamahata@intel.com \
    --cc=jiewen.yao@intel.com \
    --cc=kai.huang@intel.com \
    --cc=kirill.shutemov@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikko.ylinen@linux.intel.com \
    --cc=reinette.chatre@intel.com \
    --cc=rick.p.edgecombe@intel.com \
    --cc=seanjc@google.com \
    --cc=tony.lindgren@intel.com \
    --cc=xiaoyao.li@intel.com \
    --cc=yan.y.zhao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).