From: Jiaqi Yan <jiaqiyan@google.com>
To: Marc Zyngier <maz@misterjones.org>
Cc: Oliver Upton <oliver.upton@linux.dev>,
kvmarm@lists.linux.dev, kvm@vger.kernel.org
Subject: Re: [Bug Report] external_aborts failure related to efa1368ba9f4 ("KVM: arm64: Commit exceptions from KVM_SET_VCPU_EVENTS immediately")
Date: Tue, 29 Jul 2025 11:33:22 -0700 [thread overview]
Message-ID: <CACw3F53j60QSz=D0HozuazCSaKoOWmODZuydC8152rdxT-fRAQ@mail.gmail.com> (raw)
In-Reply-To: <18df01493fee0547d8b5902b986a2334@misterjones.org>
That commit fixed my issue, thanks a lot Marc!
On Sat, Jul 26, 2025 at 2:18 AM Marc Zyngier <maz@misterjones.org> wrote:
>
> On 2025-07-25 23:38, Jiaqi Yan wrote:
> > On Mon, Jul 21, 2025 at 7:00 AM Jiaqi Yan <jiaqiyan@google.com> wrote:
> >>
> >> Hi Oliver,
> >>
> >> I was doing some SEA injection dev work and found
> >> tools/testing/selftests/kvm/arm64/external_aborts.c is failing at the
> >> head of my locally-tracked kvmarm/next, commit 811ec70dcf9cc ("Merge
> >> branch 'kvm-arm64/config-masks' into kvmarm/next"):
> >>
> >> vobeb33:/export/hda3/tmp/yjq# ./external_aborts
> >> Random seed: 0x6b8b4567
> >> test_mmio_abort <= fail
> >> ==== Test Assertion Failure ====
> >> arm64/external_aborts.c:19: regs->pc == expected_abort_pc
> >> pid=25675 tid=25675 errno=4 - Interrupted system call
> >> (stack trace empty)
> >> 0x0 != 0x21ed20 (regs->pc != expected_abort_pc)
> >> vobeb33:/export/hda3/tmp/yjq#
> >> vobeb33:/export/hda3/tmp/yjq#
> >> vobeb33:/export/hda3/tmp/yjq# ./external_aborts
> >> Random seed: 0x6b8b4567
> >> test_mmio_nisv <= pass
> >> test_mmio_nisv_abort <=fail
> >> ==== Test Assertion Failure ====
> >> arm64/external_aborts.c:19: regs->pc == expected_abort_pc
> >> pid=26153 tid=26153 errno=4 - Interrupted system call
> >> (stack trace empty)
> >> 0x0 != 0x21eb18 (regs->pc != expected_abort_pc)
> >>
> >> It looks like the PC in the guest register is lost / polluted. I only
> >> tested test_mmio_abort (fail), test_mmio_nisv (pass), and
> >> test_mmio_nisv_abort (fail), but from reading the code of
> >> test_mmio_nisv vs test_mmio_nisv_abort, I guess test failure is
> >> probably due to some bug in the code kvm injects SEA into guest.
> >>
> >> If I revert a single commit efa1368ba9f4 ("KVM: arm64: Commit
> >> exceptions from KVM_SET_VCPU_EVENTS immediately"), all tests in
> >> tools/testing/selftests/kvm/arm64/external_aborts.c pass. I have not
> >> yet figured out the bug tho. Want to report since you are the author
> >> maybe you can (or already) spot something.
> >
> > Friendly ping ;)
>
> Please check this:
>
> https://web.git.kernel.org/pub/scm/linux/kernel/git/kvmarm/kvmarm.git/commit/?h=next&id=c6e35dff58d348c1a9489e9b3b62b3721e62631d
>
> M.
> --
> Who you jivin' with that Cosmik Debris?
prev parent reply other threads:[~2025-07-29 18:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-21 14:00 [Bug Report] external_aborts failure related to efa1368ba9f4 ("KVM: arm64: Commit exceptions from KVM_SET_VCPU_EVENTS immediately") Jiaqi Yan
2025-07-25 22:38 ` Jiaqi Yan
2025-07-26 9:18 ` Marc Zyngier
2025-07-29 18:33 ` Jiaqi Yan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACw3F53j60QSz=D0HozuazCSaKoOWmODZuydC8152rdxT-fRAQ@mail.gmail.com' \
--to=jiaqiyan@google.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=maz@misterjones.org \
--cc=oliver.upton@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).