From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jim Mattson <jmattson@google.com>
Subject: Re: [RFC 03/12] KVM/VMX: Use the new host mapping API for virtual_apic_page
Date: Mon, 05 Feb 2018 22:26:44 +0000
Message-ID: <CALMp9eRhHfoy7cL0x3qUMOHn4DUacHGc_497ac1QMPbiGU9O5g@mail.gmail.com>
References: <1517856451-2932-1-git-send-email-karahmed@amazon.de> <1517856451-2932-4-git-send-email-karahmed@amazon.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: LKML <linux-kernel@vger.kernel.org>,
        kvm list <kvm@vger.kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>
To: KarimAllah Ahmed <karahmed@amazon.de>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-io0-f196.google.com ([209.85.223.196]:38368 "EHLO
        mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750846AbeBEW0z (ORCPT <rfc822;kvm@vger.kernel.org>);
        Mon, 5 Feb 2018 17:26:55 -0500
Received: by mail-io0-f196.google.com with SMTP id d13so383300iog.5
        for <kvm@vger.kernel.org>; Mon, 05 Feb 2018 14:26:55 -0800 (PST)
In-Reply-To: <1517856451-2932-4-git-send-email-karahmed@amazon.de>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Mon, Feb 5, 2018 at 10:48 AM KarimAllah Ahmed <karahmed@amazon.de> wrote:

> @@ -5264,9 +5264,8 @@ static void
vmx_complete_nested_posted_interrupt(struct kvm_vcpu *vcpu)

>          max_irr = find_last_bit((unsigned long
*)vmx->nested.pi_desc->pir, 256);
>          if (max_irr != 256) {
> -               vapic_page = kmap(vmx->nested.virtual_apic_page);
> +               vapic_page = vmx->nested.virtual_apic_mapping.kaddr;
>                  __kvm_apic_update_irr(vmx->nested.pi_desc->pir,
vapic_page);
> -               kunmap(vmx->nested.virtual_apic_page);

Your kernel mapping now survives exits to userspace. I didn't think that
was kosher, but I'd be happy to hear that I'm wrong.

> @@ -7502,10 +7501,8 @@ static void free_nested(struct vcpu_vmx *vmx)
>          /* Unpin physical memory we referred to in the vmcs02 */
>          if (vmx->nested.apic_access_mapping.pfn)

kvm_release_host_mapping(&vmx->nested.apic_access_mapping, true);
> -       if (vmx->nested.virtual_apic_page) {
> -               kvm_release_page_dirty(vmx->nested.virtual_apic_page);
> -               vmx->nested.virtual_apic_page = NULL;
> -       }
> +       if (vmx->nested.virtual_apic_mapping.pfn)
> +
kvm_release_host_mapping(&vmx->nested.virtual_apic_mapping, true);

Is the host PFN guaranteed to be non-zero?