From: Pekka Enberg <penberg@kernel.org>
To: Michael Ellerman <michael@ellerman.id.au>
Cc: Asias He <asias.hejun@gmail.com>, kvm@vger.kernel.org
Subject: Re: [PATCH 2/2] kvm tools: Check for unknown parameters in network option handling
Date: Mon, 13 Aug 2012 10:27:51 +0300 [thread overview]
Message-ID: <CAOJsxLGA7LmUWpGR+aHN3rC8XL0rvhc-G3s8u-nWRG6OKzejag@mail.gmail.com> (raw)
In-Reply-To: <1344828719.7376.1.camel@concordia>
On Mon, Aug 13, 2012 at 6:31 AM, Michael Ellerman
<michael@ellerman.id.au> wrote:
>> > diff --git a/tools/kvm/builtin-run.c b/tools/kvm/builtin-run.c
>> > index a36bd00..9e5c1d4 100644
>> > --- a/tools/kvm/builtin-run.c
>> > +++ b/tools/kvm/builtin-run.c
>> > @@ -257,7 +257,8 @@ static int set_net_param(struct virtio_net_params *p, const char *param,
>> > p->vhost = atoi(val);
>> > } else if (strcmp(param, "fd") == 0) {
>> > p->fd = atoi(val);
>> > - }
>> > + } else
>> > + die("Unknown network parameter %s", param);
>>
>> we need braces here:
>
> We don't _need_ braces, but I assume you mean you'd prefer braces?
This is Linux coding style so we don't prefer them either.
next prev parent reply other threads:[~2012-08-13 7:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-10 5:38 [PATCH 1/2] kvm tools: Fix formatting of error message in TAP handling Michael Ellerman
2012-08-10 5:38 ` [PATCH 2/2] kvm tools: Check for unknown parameters in network option handling Michael Ellerman
2012-08-11 0:21 ` Asias He
2012-08-13 3:31 ` Michael Ellerman
2012-08-13 7:27 ` Pekka Enberg [this message]
2012-08-14 1:27 ` Asias He
2012-08-10 23:58 ` [PATCH 1/2] kvm tools: Fix formatting of error message in TAP handling Asias He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOJsxLGA7LmUWpGR+aHN3rC8XL0rvhc-G3s8u-nWRG6OKzejag@mail.gmail.com \
--to=penberg@kernel.org \
--cc=asias.hejun@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=michael@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).