From mboxrd@z Thu Jan 1 00:00:00 1970 From: Akio Takebe Subject: Re: [Patch][RFC] fix make rpm Date: Tue, 30 Oct 2007 21:16:04 +0900 Message-ID: References: <47271CB2.1020503@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Akio Takebe To: Avi Kivity Return-path: In-Reply-To: <47271CB2.1020503-atKUWr5tajBWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Hi, Avi Thank you for your comments. >> This patch fix "make rpm". >> When I used the rpm option, I got some error. >> So I fixed it, but it is a just sample? >> >> > >'make rpm' works for me on F7 (after I fixed fallout from the libkvm >separation patch). What distribution did you run it on? What error did >you get? > I used RHEL5. I got the following error at fist. [root@vmx08 kvm-49]# make rpm mkdir -p SOURCES SRPMS mkdir: `SOURCES' exists but is not a directory make: *** [srpm] Error 1 [root@vmx08 kvm-49]# So I retried it after remaking SOURCES. [root@vmx08 kvm-49]# rm SOURCES rm: remove regular file `SOURCES'? yes [root@vmx08 kvm-49]# mkdir SOURCES [root@vmx08 kvm-49]# make rpm mkdir -p SOURCES SRPMS sed 's/^Release:.*/Release: devel/' kvm.spec > .tmp.kvm.spec tar czf SOURCES/kvm.tar.gz qemu tar czf SOURCES/user.tar.gz user tar czf SOURCES/kernel.tar.gz kernel tar czf SOURCES/scripts.tar.gz scripts cp Makefile configure kvm_stat SOURCES rpmbuild --define="_topdir $(pwd)" -bs .tmp.kvm.spec error: types must match error: /root/kvm-49/.tmp.kvm.spec:18: parseExpressionBoolean returns -1 error: Package has no %description: kvm make: *** [srpm] Error 1 [root@vmx08 kvm-49]# After I fixed above, I got some more errors... >I think we can't treat it as more than a sample because we can't expect >it to work everywhere (e.g. debian). But i will accept patches to >improve it. > OK, I agree. >> What do you think about it? >> >> Signed-off-by: Akio Takebe >> -/usr/kvm >> +%dir /usr/kvm >> +%dir /usr/kvm/bin >> +/usr/kvm/bin/qemu-img >> +/usr/kvm/bin/qemu-system-x86_64 >> +%dir /usr/kvm/share >> +%dir /usr/kvm/share/qemu >> +/usr/kvm/share/qemu/bios.bin >> +%dir /usr/kvm/share/qemu/keymaps >> +/usr/kvm/share/qemu/keymaps/ar >> +/usr/kvm/share/qemu/keymaps/common >> +/usr/kvm/share/qemu/keymaps/da >> +/usr/kvm/share/qemu/keymaps/de >> +/usr/kvm/share/qemu/keymaps/de-ch >> +/usr/kvm/share/qemu/keymaps/en-gb >> +/usr/kvm/share/qemu/keymaps/en-us >> +/usr/kvm/share/qemu/keymaps/es >> +/usr/kvm/share/qemu/keymaps/et >> +/usr/kvm/share/qemu/keymaps/fi >> +/usr/kvm/share/qemu/keymaps/fo >> +/usr/kvm/share/qemu/keymaps/fr >> +/usr/kvm/share/qemu/keymaps/fr-be >> +/usr/kvm/share/qemu/keymaps/fr-ca >> +/usr/kvm/share/qemu/keymaps/fr-ch >> +/usr/kvm/share/qemu/keymaps/hr >> +/usr/kvm/share/qemu/keymaps/hu >> +/usr/kvm/share/qemu/keymaps/is >> +/usr/kvm/share/qemu/keymaps/it >> +/usr/kvm/share/qemu/keymaps/ja >> +/usr/kvm/share/qemu/keymaps/lt >> +/usr/kvm/share/qemu/keymaps/lv >> +/usr/kvm/share/qemu/keymaps/mk >> +/usr/kvm/share/qemu/keymaps/modifiers >> +/usr/kvm/share/qemu/keymaps/nl >> +/usr/kvm/share/qemu/keymaps/nl-be >> +/usr/kvm/share/qemu/keymaps/no >> +/usr/kvm/share/qemu/keymaps/pl >> +/usr/kvm/share/qemu/keymaps/pt >> +/usr/kvm/share/qemu/keymaps/pt-br >> +/usr/kvm/share/qemu/keymaps/ru >> +/usr/kvm/share/qemu/keymaps/sl >> +/usr/kvm/share/qemu/keymaps/sv >> +/usr/kvm/share/qemu/keymaps/th >> +/usr/kvm/share/qemu/keymaps/tr >> +/usr/kvm/share/qemu/openbios-sparc32 >> +/usr/kvm/share/qemu/ppc_rom.bin >> +/usr/kvm/share/qemu/pxe-ne2k_pci.bin >> +/usr/kvm/share/qemu/pxe-pcnet.bin >> +/usr/kvm/share/qemu/pxe-rtl8139.bin >> +/usr/kvm/share/qemu/vgabios-cirrus.bin >> +/usr/kvm/share/qemu/vgabios.bin >> +/usr/kvm/share/qemu/video.x >> +%dir /lib/modules/%{uname}/extra >> +/lib/modules/%{uname}/extra/kvm.ko >> +/lib/modules/%{uname}/extra/kvm-intel.ko >> +/lib/modules/%{uname}/extra/kvm-amd.ko >> %changelog >> >> > >Why is this change necessary? Doesn't '/usr/kvm' work? This way, every >time qemu adds a file we have to update the rpm spec. Exactly, I think better writing these, but actually these are not needed. So when qemu is updated, we need to update these as you said. I'll put back them because it's messy. Best Regards, Akio Takebe ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/