From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA306168A6 for ; Tue, 2 Jan 2024 21:37:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ggWWJVG5" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-40d8909a6feso18002715e9.2 for ; Tue, 02 Jan 2024 13:37:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704231435; x=1704836235; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=/j7/rdcZmoVQjecAI6/HxXOPJUcRBJCUvX9qQzCAcW8=; b=ggWWJVG5FVbXeek9IpyzIHq4RNKlZa5M1hue33a74swFmWAIrwR3e6W8KjDuCmSKP9 9bz8jspKLt+y6v9sRRrrF+slqx71SXpcGq3rA0c0lPwnhViYvD7EMH9cfEf/3QprTBCo bp9IynDl2Y5HwcqQlconpsBQADow3mzqu2QMNojzMGjWXt/qI+ILhFNdmHA6Nu5A6csx 8kfdnCOXPdaVcfn4UcZfo1qxH0mT3IMGogr+krqyZE5UxHk4Nz++xoMmxr7aZ/kyNo3i G/icHpGSfvWwBd4qx9B09qPbkP67RwrK/plnuD5tC3wxwZt0PMhge800jzmQt9jLdYFP Rc0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704231435; x=1704836235; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/j7/rdcZmoVQjecAI6/HxXOPJUcRBJCUvX9qQzCAcW8=; b=S+JMnjhBJYaNU9aHu2e5D3iNXG0/N2XbKgitBIoHHDarKPmaVvrIFQKnAjyQOC+8Cq O/AcYZuKbZpXLJz3KYWoaBnLuerVydhbCeJ7jh8p4rVV1bpe798VH+E8Ct3mMwa2w/Ah coay3cysa7P/uvAmJoq0/Hfcv0vjkl7tlny9i/PNyWWZzcuWQX+l86uQD2E5S4pFM/Ur dsR9NfYJIShXrQpcUzKH84jbajEXSZTRw/hlsmurVipFM3adBV1QI1Vw/85n7sTvHE5R P3OERHejXcpe4zVBJ+udIKEIq/utSHfYmjuUU0TBxlKOXwq4/bq68aUSPwNET2Y1rGQ5 uFoA== X-Gm-Message-State: AOJu0Yx5bNt4Yp1rAnjjEBX1pEngKSup3kICSq+hCQP4jeSdD8avq18o f1Q1zu8vKubX0nr0N25Z8XU= X-Google-Smtp-Source: AGHT+IFrz+8G4XaufDC1u0mAfvhOGqc3F19J3DroZasFggdJGsufr8PGV5ZiaTqLN5DOoVoj9N8dAg== X-Received: by 2002:a7b:ce13:0:b0:40d:6f34:5c13 with SMTP id m19-20020a7bce13000000b0040d6f345c13mr2971570wmc.231.1704231434891; Tue, 02 Jan 2024 13:37:14 -0800 (PST) Received: from [127.0.0.1] (dynamic-089-014-091-072.89.14.pool.telefonica.de. [89.14.91.72]) by smtp.gmail.com with ESMTPSA id p34-20020a05600c1da200b0040d8b4ebd55sm252596wms.0.2024.01.02.13.37.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Jan 2024 13:37:14 -0800 (PST) Date: Tue, 02 Jan 2024 21:37:00 +0000 From: Bernhard Beschow To: Stefan Hajnoczi , qemu-devel@nongnu.org CC: =?ISO-8859-1?Q?Daniel_P=2E_Berrang=E9?= , Marcel Apfelbaum , Akihiko Odaki , Artyom Tarasenko , Paul Durrant , Daniel Henrique Barboza , =?ISO-8859-1?Q?C=E9dric_Le_Goater?= , Paolo Bonzini , BALATON Zoltan , Jagannathan Raman , Anthony Perard , Nicholas Piggin , David Gibson , Aleksandar Rikalo , Alexander Graf , Hailiang Zhang , Marcelo Tosatti , Jiaxun Yang , Huacai Chen , Harsh Prateek Bora , Ilya Leoshkevich , Peter Xu , Hyman Huang , Fam Zheng , Song Gao , Alistair Francis , =?ISO-8859-1?Q?Marc-Andr=E9_Lureau?= , Stefano Stabellini , David Woodhouse , Christian Borntraeger , Palmer Dabbelt , Aurelien Jarno , Leonardo Bras , Jiri Slaby , Eric Farman , Thomas Huth , Richard Henderson , David Hildenbrand , Michael Roth , Elena Ufimtseva , Gerd Hoffmann , Cameron Esfahani , qemu-ppc@nongnu.org, John Snow , Mark Cave-Ayland , Weiwei Li , Hanna Reitz , qemu-s390x@nongnu.org, qemu-block@nongnu.org, =?ISO-8859-1?Q?Alex_Benn=E9e?= , kvm@vger.kernel.org, "Michael S. Tsirkin" , Pavel Dovgalyuk , Vladimir Sementsov-Ogievskiy , Andrey Smirnov , Reinoud Zandijk , Kevin Wolf , Bin Meng , Sunil Muthuswamy , Peter Maydell , qemu-riscv@nongnu.org, Liu Zhiwei , Stafford Horne , Fabiano Rosas , Juan Quintela , Markus Armbruster , qemu-arm@nongnu.org, Jason Wang , Eduardo Habkost , Max Filippov , Jean-Christophe Dubois , Eric Blake , Roman Bolshakov , Halil Pasic , xen-devel@lists.xenproject.org, =?ISO-8859-1?Q?Philippe_Mathieu-Daud=E9?= , David Woodhouse Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v2_1/5=5D_system/cpus=3A_rename_?= =?US-ASCII?Q?qemu=5Fmutex=5Flock=5Fiothread=28=29_to_bql=5Flock=28=29?= In-Reply-To: <20231212153905.631119-2-stefanha@redhat.com> References: <20231212153905.631119-1-stefanha@redhat.com> <20231212153905.631119-2-stefanha@redhat.com> Message-ID: Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Am 12=2E Dezember 2023 15:39:00 UTC schrieb Stefan Hajnoczi : >The Big QEMU Lock (BQL) has many names and they are confusing=2E The >actual QemuMutex variable is called qemu_global_mutex but it's commonly >referred to as the BQL in discussions and some code comments=2E The >locking APIs, however, are called qemu_mutex_lock_iothread() and >qemu_mutex_unlock_iothread()=2E > >The "iothread" name is historic and comes from when the main thread was >split into into KVM vcpu threads and the "iothread" (now called the main Duplicate "into" here=2E >loop thread)=2E I have contributed to the confusion myself by introducing >a separate --object iothread, a separate concept unrelated to the BQL=2E > >The "iothread" name is no longer appropriate for the BQL=2E Rename the >locking APIs to: >- void bql_lock(void) >- void bql_unlock(void) >- bool bql_locked(void) > >There are more APIs with "iothread" in their names=2E Subsequent patches >will rename them=2E There are also comments and documentation that will b= e >updated in later patches=2E > >Signed-off-by: Stefan Hajnoczi >Reviewed-by: Paul Durrant >Acked-by: Fabiano Rosas >Acked-by: David Woodhouse >Reviewed-by: C=C3=A9dric Le Goater >Acked-by: Peter Xu >Acked-by: Eric Farman >Reviewed-by: Harsh Prateek Bora