Re: [kvm-unit-tests v3 08/13] powerpc/spapr_vpa: Add basic VPA tests

Thomas Huth
2023-04-04T07:17:56Z

On 27/03/2023 14.45, Nicholas Piggin wrote:
> The VPA is an optional memory structure shared between the hypervisor
> and operating system, defined by PAPR. This test defines the structure
> and adds registration, deregistration, and a few simple sanity tests.
>
> [Thanks to Thomas Huth for suggesting many of the test cases.]
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> ---
...
> diff --git a/powerpc/Makefile.ppc64 b/powerpc/Makefile.ppc64
> index ea68447..b0ed2b1 100644
> --- a/powerpc/Makefile.ppc64
> +++ b/powerpc/Makefile.ppc64
> @@ -19,7 +19,7 @@ reloc.o = $(TEST_DIR)/reloc64.o
> OBJDIRS += lib/ppc64
>
> # ppc64 specific tests
> -tests =
> +tests = $(TEST_DIR)/spapr_vpa.elf
>
> include $(SRCDIR)/$(TEST_DIR)/Makefile.common

That reminds me: We added all other tests to Makefile.common ... without
ever checking them on 32-bit. Since we removed the early 32-bit code long
ago already (see commit 2a814baab80af990eaf), it just might not make sense
anymore to keep the separation for 64-bit and 32-bit Makefiles around here
anymore --> could be a future cleanup to merge the Makefiles in the powerpc
folder.

Anyway, that's not a problem of your patch here which looks fine, so:

Reviewed-by: Thomas Huth <thuth@redhat.com>