Re: [kvm-unit-tests PATCH] lib/arm/io: Fix calling getchar() multiple times

["Nicholas Piggin" <npiggin@gmail.com>]

On Sat Feb 17, 2024 at 12:02 AM AEST, Thomas Huth wrote:
> getchar() can currently only be called once on arm since the implementation
> is a little bit too  naïve: After the first character has arrived, the
> data register never gets set to zero again. To properly check whether a
> byte is available, we need to check the "RX fifo empty" on the pl011 UART
> or the "RX data ready" bit on the ns16550a UART instead.
>
> With this proper check in place, we can finally also get rid of the
> ugly assert(count < 16) statement here.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Nice, thanks for fixing this up.

I see what you mean about multi-migration not waiting. It seems
to be an arm issue, ppc works properly. This patch changed things
so it works a bit better (or at least differently) now, but
still has some bugs. Maybe buggy uart migration?

Thanks,
Nick