* [kvm-unit-tests PATCH] scripts/s390x: Fix the execution of the PV tests
@ 2024-06-03 7:59 Thomas Huth
2024-06-03 11:05 ` Janosch Frank
2024-06-04 4:50 ` Nicholas Piggin
0 siblings, 2 replies; 4+ messages in thread
From: Thomas Huth @ 2024-06-03 7:59 UTC (permalink / raw)
To: kvm, Nico Böhr
Cc: Janosch Frank, Nicholas Piggin, linux-s390, Claudio Imbrenda,
Marc Hartmayer
Commit ccb37496 ("scripts: allow machine option to be specified in
unittests.cfg") added an additonal parameter (the "machine"), but
we forgot to add it to the spot that runs the PV test cases, so
those are currently broken without this fix.
Fixes: ccb37496 ("scripts: allow machine option to be specified in unittests.cfg")
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
scripts/s390x/func.bash | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/s390x/func.bash b/scripts/s390x/func.bash
index 6b817727..f04e8e2a 100644
--- a/scripts/s390x/func.bash
+++ b/scripts/s390x/func.bash
@@ -35,5 +35,5 @@ function arch_cmd_s390x()
print_result 'SKIP' $testname '' 'PVM image was not created'
return 2
fi
- "$cmd" "$testname" "$groups pv" "$smp" "$kernel" "$opts" "$arch" "$check" "$accel" "$timeout"
+ "$cmd" "$testname" "$groups pv" "$smp" "$kernel" "$opts" "$arch" "$machine" "$check" "$accel" "$timeout"
}
--
2.45.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [kvm-unit-tests PATCH] scripts/s390x: Fix the execution of the PV tests
2024-06-03 7:59 [kvm-unit-tests PATCH] scripts/s390x: Fix the execution of the PV tests Thomas Huth
@ 2024-06-03 11:05 ` Janosch Frank
2024-06-03 11:56 ` Thomas Huth
2024-06-04 4:50 ` Nicholas Piggin
1 sibling, 1 reply; 4+ messages in thread
From: Janosch Frank @ 2024-06-03 11:05 UTC (permalink / raw)
To: Thomas Huth, kvm, Nico Böhr
Cc: Nicholas Piggin, linux-s390, Claudio Imbrenda, Marc Hartmayer
On 6/3/24 09:59, Thomas Huth wrote:
> Commit ccb37496 ("scripts: allow machine option to be specified in
> unittests.cfg") added an additonal parameter (the "machine"), but
> we forgot to add it to the spot that runs the PV test cases, so
> those are currently broken without this fix.
>
> Fixes: ccb37496 ("scripts: allow machine option to be specified in unittests.cfg")
> Signed-off-by: Thomas Huth <thuth@redhat.com>
LGTM
Has this issue come up in the Gitlab CI or in your internal CI?
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [kvm-unit-tests PATCH] scripts/s390x: Fix the execution of the PV tests
2024-06-03 11:05 ` Janosch Frank
@ 2024-06-03 11:56 ` Thomas Huth
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Huth @ 2024-06-03 11:56 UTC (permalink / raw)
To: Janosch Frank, kvm, Nico Böhr
Cc: Nicholas Piggin, linux-s390, Claudio Imbrenda, Marc Hartmayer
On 03/06/2024 13.05, Janosch Frank wrote:
> On 6/3/24 09:59, Thomas Huth wrote:
>> Commit ccb37496 ("scripts: allow machine option to be specified in
>> unittests.cfg") added an additonal parameter (the "machine"), but
>> we forgot to add it to the spot that runs the PV test cases, so
>> those are currently broken without this fix.
>>
>> Fixes: ccb37496 ("scripts: allow machine option to be specified in
>> unittests.cfg")
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>
> LGTM
> Has this issue come up in the Gitlab CI or in your internal CI?
Gitlab CI does not run the PV tests yet - I just noticed it while running
the tests on the s390x machine that I've got access to.
Thomas
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [kvm-unit-tests PATCH] scripts/s390x: Fix the execution of the PV tests
2024-06-03 7:59 [kvm-unit-tests PATCH] scripts/s390x: Fix the execution of the PV tests Thomas Huth
2024-06-03 11:05 ` Janosch Frank
@ 2024-06-04 4:50 ` Nicholas Piggin
1 sibling, 0 replies; 4+ messages in thread
From: Nicholas Piggin @ 2024-06-04 4:50 UTC (permalink / raw)
To: Thomas Huth, kvm, Nico Böhr
Cc: Janosch Frank, linux-s390, Claudio Imbrenda, Marc Hartmayer
On Mon Jun 3, 2024 at 5:59 PM AEST, Thomas Huth wrote:
> Commit ccb37496 ("scripts: allow machine option to be specified in
> unittests.cfg") added an additonal parameter (the "machine"), but
> we forgot to add it to the spot that runs the PV test cases, so
> those are currently broken without this fix.
Thanks, this is the one you already found? Looks good to me.
Thanks,
Nick
>
> Fixes: ccb37496 ("scripts: allow machine option to be specified in unittests.cfg")
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> scripts/s390x/func.bash | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/s390x/func.bash b/scripts/s390x/func.bash
> index 6b817727..f04e8e2a 100644
> --- a/scripts/s390x/func.bash
> +++ b/scripts/s390x/func.bash
> @@ -35,5 +35,5 @@ function arch_cmd_s390x()
> print_result 'SKIP' $testname '' 'PVM image was not created'
> return 2
> fi
> - "$cmd" "$testname" "$groups pv" "$smp" "$kernel" "$opts" "$arch" "$check" "$accel" "$timeout"
> + "$cmd" "$testname" "$groups pv" "$smp" "$kernel" "$opts" "$arch" "$machine" "$check" "$accel" "$timeout"
> }
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-06-04 4:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-03 7:59 [kvm-unit-tests PATCH] scripts/s390x: Fix the execution of the PV tests Thomas Huth
2024-06-03 11:05 ` Janosch Frank
2024-06-03 11:56 ` Thomas Huth
2024-06-04 4:50 ` Nicholas Piggin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox