Re: [kvm-unit-tests PATCH 1/2] s390x: Only run genprotimg if necessary

["Nicholas Piggin" <npiggin@gmail.com>]

On Mon Jun 3, 2024 at 9:54 PM AEST, Janosch Frank wrote:
> On 6/2/24 15:06, Nicholas Piggin wrote:
> > genprotimg is not required if the --host-key-document= configure option
> > is not specified, so avoid running it in that case. This prevents the
> > build message:
> > 
> >    bash: line 1: genprotimg: command not found
> > 
> > Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
>
> This solves the immediate problem but I think we're really missing a lot 
> more checks in the makefile and configure to sanitize the SE option space.

Agree, it would be ideal to find genprotimg at configure time
and warn or fail if other options were specified. That looked
like a bigger job and I don't have a PV environment to test with
at the moment.

> Anyway:
> Reviewed-by: Janosch Frank <frankja@linux.ibm.com>

Thanks,
Nick