From: "Nicholas Piggin" <npiggin@gmail.com>
To: "Thomas Huth" <thuth@redhat.com>, <kvm@vger.kernel.org>,
"Nico Boehr" <nrb@linux.ibm.com>,
"Andrew Jones" <andrew.jones@linux.dev>
Subject: Re: [kvm-unit-tests PATCH] gitlab-ci: Test that "make check-kerneldoc" does not report any errors
Date: Fri, 14 Jun 2024 10:45:50 +1000 [thread overview]
Message-ID: <D1ZBPNWUNEUL.2SA91WMODAX9B@gmail.com> (raw)
In-Reply-To: <20240607063616.60408-1-thuth@redhat.com>
On Fri Jun 7, 2024 at 4:36 PM AEST, Thomas Huth wrote:
> To make sure that we don't regress with the formatting of the
> comments, we should check this in the CI, too.
Could make it a script, but this works well enough too.
Reviewed-by: Nicholas Piggin <npiggin@gmail.com>
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> .gitlab-ci.yml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 23bb69e2..2af47328 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -310,6 +310,8 @@ build-centos7:
> setjmp sieve tsc rmap_chain umip
> | tee results.txt
> - grep -q PASS results.txt && ! grep -q FAIL results.txt
> + - make -s check-kerneldoc 2>&1 | tee docwarnings.txt
> + - test -z `cat docwarnings.txt`
>
> # Cirrus-CI provides containers with macOS and Linux with KVM enabled,
> # so we can test some scenarios there that are not possible with the
prev parent reply other threads:[~2024-06-14 0:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-07 6:36 [kvm-unit-tests PATCH] gitlab-ci: Test that "make check-kerneldoc" does not report any errors Thomas Huth
2024-06-14 0:45 ` Nicholas Piggin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D1ZBPNWUNEUL.2SA91WMODAX9B@gmail.com \
--to=npiggin@gmail.com \
--cc=andrew.jones@linux.dev \
--cc=kvm@vger.kernel.org \
--cc=nrb@linux.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox