* [kvm-unit-tests PATCH] gitlab-ci: Test that "make check-kerneldoc" does not report any errors
@ 2024-06-07 6:36 Thomas Huth
2024-06-14 0:45 ` Nicholas Piggin
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Huth @ 2024-06-07 6:36 UTC (permalink / raw)
To: kvm, Nico Boehr, Andrew Jones; +Cc: Nicholas Piggin
To make sure that we don't regress with the formatting of the
comments, we should check this in the CI, too.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
.gitlab-ci.yml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 23bb69e2..2af47328 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -310,6 +310,8 @@ build-centos7:
setjmp sieve tsc rmap_chain umip
| tee results.txt
- grep -q PASS results.txt && ! grep -q FAIL results.txt
+ - make -s check-kerneldoc 2>&1 | tee docwarnings.txt
+ - test -z `cat docwarnings.txt`
# Cirrus-CI provides containers with macOS and Linux with KVM enabled,
# so we can test some scenarios there that are not possible with the
--
2.45.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [kvm-unit-tests PATCH] gitlab-ci: Test that "make check-kerneldoc" does not report any errors
2024-06-07 6:36 [kvm-unit-tests PATCH] gitlab-ci: Test that "make check-kerneldoc" does not report any errors Thomas Huth
@ 2024-06-14 0:45 ` Nicholas Piggin
0 siblings, 0 replies; 2+ messages in thread
From: Nicholas Piggin @ 2024-06-14 0:45 UTC (permalink / raw)
To: Thomas Huth, kvm, Nico Boehr, Andrew Jones
On Fri Jun 7, 2024 at 4:36 PM AEST, Thomas Huth wrote:
> To make sure that we don't regress with the formatting of the
> comments, we should check this in the CI, too.
Could make it a script, but this works well enough too.
Reviewed-by: Nicholas Piggin <npiggin@gmail.com>
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> .gitlab-ci.yml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 23bb69e2..2af47328 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -310,6 +310,8 @@ build-centos7:
> setjmp sieve tsc rmap_chain umip
> | tee results.txt
> - grep -q PASS results.txt && ! grep -q FAIL results.txt
> + - make -s check-kerneldoc 2>&1 | tee docwarnings.txt
> + - test -z `cat docwarnings.txt`
>
> # Cirrus-CI provides containers with macOS and Linux with KVM enabled,
> # so we can test some scenarios there that are not possible with the
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-06-14 0:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-07 6:36 [kvm-unit-tests PATCH] gitlab-ci: Test that "make check-kerneldoc" does not report any errors Thomas Huth
2024-06-14 0:45 ` Nicholas Piggin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox