Re: [PATCH v1 07/13] KVM: s390: move some gmap shadowing functions away from mm/gmap.c

Janosch Frank
2025-01-15T08:56:22Z

On 1/8/25 7:14 PM, Claudio Imbrenda wrote:
> Move some gmap shadowing functions from mm/gmap.c to kvm/vsie.c and
> kvm/kvm-s390.c .
>

Why though?

I don't really want to have gmap code in vsie.c
If you want to add a new mm/gmap-vsie.c then do so but I don't see a
need to move gmap code from mm to kvm and you give no explanation
whatsoever.

Maybe add a vsie-gmap.c in kvm but I'm not so thrilled about that for
the reasons mentioned above.