Re: [PATCH v1 0/4] KVM: s390: vsie: vsie page handling fixes + rework

Claudio Imbrenda
2025-01-08T18:21:36Z

On Tue, 7 Jan 2025 16:43:40 +0100
David Hildenbrand <david@redhat.com> wrote:

> We want to get rid of page->index, so let's make vsie code stop using it
> for the vsie page.
>
> While at it, also remove the usage of page refcount, so we can stop messing
> with "struct page" completely.
>
> ... of course, looking at this code after quite some years, I found some
> corner cases that should be fixed.
>
> Briefly sanity tested with kvm-unit-tests running inside a KVM VM, and
> nothing blew up.

I like this! (aside from a very tiny nit in patch 4)

if a v2 is not needed, I'll put the split line in patch 4 back together
myself when picking, no need to send a v2 just for that.

whole series:
Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>

>
> Cc: Christian Borntraeger <borntraeger@linux.ibm.com>
> Cc: Janosch Frank <frankja@linux.ibm.com>
> Cc: Claudio Imbrenda <imbrenda@linux.ibm.com>
> Cc: Heiko Carstens <hca@linux.ibm.com>
> Cc: Vasily Gorbik <gor@linux.ibm.com>
> Cc: Alexander Gordeev <agordeev@linux.ibm.com>
> Cc: Sven Schnelle <svens@linux.ibm.com>
> Cc: Thomas Huth <thuth@redhat.com>
> Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
>
> David Hildenbrand (4):
> KVM: s390: vsie: fix some corner-cases when grabbing vsie pages
> KVM: s390: vsie: stop using page->index
> KVM: s390: vsie: stop messing with page refcount
> KVM: s390: vsie: stop using "struct page" for vsie page
>
> arch/s390/include/asm/kvm_host.h | 4 +-
> arch/s390/kvm/vsie.c | 104 ++++++++++++++++++++-----------
> 2 files changed, 69 insertions(+), 39 deletions(-)
>
>
> base-commit: fbfd64d25c7af3b8695201ebc85efe90be28c5a3