From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5449A19F424 for ; Mon, 26 May 2025 09:00:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748250035; cv=none; b=BS8a3qzFcvFbWGkoazF3ZUkY1dz4FOA/DaDclxMcl5X74bkLVq0Hzi8p1V6CbdAG9sPx5HxpQRwkMgxUHZjeQ1AuiENvcwFp/xWZQ8eA9LXRMkvPz3h/o2hNwunS+vZQQt7i29xVeaeSv6bYca+9FUUHF/0UCKFSKKwIIovijGc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748250035; c=relaxed/simple; bh=Px13KBn3Ab4PML/y+5ws+0a8JDTrznN8pyXvkr61Wiw=; h=Mime-Version:Content-Type:Date:Message-Id:Subject:Cc:To:From: References:In-Reply-To; b=YixF/s4OK6IM6F24ntjmB7rb71SG1CyiWxT90yuHCyDhObnTVSDuEaKF2kzvh/yJ2IAB4HqKXYzmx8y764EEWHrJFai129fEDZXFj05zICKaWo4oMDtsc2MtfjikcP587gi1S0i3oP3NGx+Zlj/K+qmzOaSj5Mw9po6PdS3e89U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com; spf=pass smtp.mailfrom=ventanamicro.com; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b=Sbb7dCGT; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ventanamicro.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ventanamicro.com header.i=@ventanamicro.com header.b="Sbb7dCGT" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-43d4ff56136so3731835e9.3 for ; Mon, 26 May 2025 02:00:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1748250032; x=1748854832; darn=vger.kernel.org; h=in-reply-to:references:from:to:cc:subject:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Px13KBn3Ab4PML/y+5ws+0a8JDTrznN8pyXvkr61Wiw=; b=Sbb7dCGTWb0+9jCPO0UczcwQrSEdVCPZbh/9trsg8Rvu70wtnJ9JMDa7l8m8yfJf9v F6zS5U0OSI9MJZg35+FV8D8iwImU5cit8q+w3LHMU3aFyZ+4qmb+4FELhSt+kdGDSRCt 3dpa59pk/IZfhejmGyool2zm8w8Exn++hnfdrC+kOpKvX0ANo/c7EL8+dXkpS8rAvhS/ pIhNd08H9B0KvUOOiWogBXmMPp/UcfeddH5lhm5q7CrDOGHvGyY4U9LdGg+BHLD3OAag VI+96BJrlcQ2m3mJM1GuuFlR+50S14fQpgIKVTJkEQ7VCw99K7Mm0XNBmop3dkFOeNeI DBvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748250032; x=1748854832; h=in-reply-to:references:from:to:cc:subject:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Px13KBn3Ab4PML/y+5ws+0a8JDTrznN8pyXvkr61Wiw=; b=MCoq9THe8CM1wMQA9VIHuMuD5tOTQGqq8glUKXuFWbtEmPsRCtlYqiurW2pz/pNYXB SwSaCXix6G1tXiNZSB3LYu61RpHfbNvqsoeIGO/MjnyVZSkL/+0EhrorgpqPG4SgkFtb IwlybWuwCgDHb1p/jiLn1IThZEx0l/UjfX2LQ+RowNfPcg1h0iOhTDOq4g6IMoXBrBOm L8mSfn9yF2fqKaNF66WUgE8ur972fyuCx7B1ArKQY69Y6d7mdo83yrlQJuBjWHFzA2NQ jWDxTQoC4jRFZYOZj986UZhrScRI+PBkx2nyZBSsYLeAbMmklvKaygO8PvMQMGYy4lVh iIOw== X-Forwarded-Encrypted: i=1; AJvYcCW/VwzyExXsIUruA3JGKCSlUFRFGRiEWj9GBZrxJJKHkQm1ZF83Bpdd2aQSEEpNi7NrojE=@vger.kernel.org X-Gm-Message-State: AOJu0YyMCLXTeuiZL2H3T4SQgzYaAjyPFK8SXizDSubamj154r0vgSlZ og3WI4OERl56FltgoFsfWWNfdovFvnkjy2ltPufi0LC+6Tn43CZtbiz1BxE819dEfcI= X-Gm-Gg: ASbGncsL/W6d2sjgUlpamX/w4pSRAxI7RY6TSxh4mGd7YR1gKe3gii1lEFziDl8wZIX VKMJLFOSCfXXiUaJe/2nFlG41siYxeVYCICrBa4uHhglF6cdAwTB2pp88EjJQgiMnA+SrgLQuDv /FPHJYhTPbYfljizxELOtdShgHMZGUYvSZH5qyVHo6EfEoSI4yoFdYlSuCebk1GOo5nSe1BUN+X C5pJzx3BSQbGXuPK323J58vEtqQ02k2Ce0cnOZ6uO1gui+FYQru6iVgMigVv9vC85Asf5YWIUDG 2wZRtWQ060gTNDQj8EXBmcR7Rawa/VF9atBV7wgnvSWiV7I818JAmDrfxcQ= X-Google-Smtp-Source: AGHT+IF/tn9b6UQhPJeT+xCpvDd/FmqeY7qs1H9ffakgmE7eWhdvKQVPuHh5QupMD48NcHbdDQ76XQ== X-Received: by 2002:a05:600c:1547:b0:439:9909:c785 with SMTP id 5b1f17b1804b1-44c935dd918mr24933285e9.7.1748250031502; Mon, 26 May 2025 02:00:31 -0700 (PDT) Received: from localhost ([2a02:8308:a00c:e200:b85a:a7d4:fa4e:bb11]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-447f3dd94f1sm235682295e9.35.2025.05.26.02.00.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 May 2025 02:00:31 -0700 (PDT) Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 26 May 2025 11:00:30 +0200 Message-Id: Subject: Re: [PATCH v3 9/9] RISC-V: KVM: Upgrade the supported SBI version to 3.0 Cc: , , , "Palmer Dabbelt" , , , "linux-riscv" To: "Atish Patra" , "Anup Patel" , "Will Deacon" , "Mark Rutland" , "Paul Walmsley" , "Palmer Dabbelt" , "Mayuresh Chitale" From: =?utf-8?q?Radim_Kr=C4=8Dm=C3=A1=C5=99?= References: <20250522-pmu_event_info-v3-0-f7bba7fd9cfe@rivosinc.com> <20250522-pmu_event_info-v3-9-f7bba7fd9cfe@rivosinc.com> <61627296-6f94-45ea-9410-ed0ea2251870@linux.dev> In-Reply-To: <61627296-6f94-45ea-9410-ed0ea2251870@linux.dev> 2025-05-23T10:16:11-07:00, Atish Patra : > On 5/23/25 6:31 AM, Radim Kr=C4=8Dm=C3=A1=C5=99 wrote: >> 2025-05-22T12:03:43-07:00, Atish Patra : >>> Upgrade the SBI version to v3.0 so that corresponding features >>> can be enabled in the guest. >>> >>> Signed-off-by: Atish Patra >>> --- >>> diff --git a/arch/riscv/include/asm/kvm_vcpu_sbi.h b/arch/riscv/include= /asm/kvm_vcpu_sbi.h >>> -#define KVM_SBI_VERSION_MAJOR 2 >>> +#define KVM_SBI_VERSION_MAJOR 3 >> I think it's time to add versioning to KVM SBI implementation. >> Userspace should be able to select the desired SBI version and KVM would >> tell the guest that newer features are not supported. > > We can achieve that through onereg interface by disabling individual SBI= =20 > extensions. > We can extend the existing onereg interface to disable a specific SBI=20 > version directly > instead of individual ones to save those IOCTL as well. Yes, I am all in favor of letting userspace provide all values in the BASE extension.